• Timothy Gu's avatar
    x86inc: Clear __SECT__ · dd4d709b
    Timothy Gu authored
    Silences warning(s) like:
    
        libavcodec/x86/fft.asm:93: warning: section flags ignored on
        section redeclaration
    
    The cause of this warning is that because `struc` and `endstruc`
    attempts to revert to the previous section state [1].
    
    The section state is stored in the macro __SECT__, defined by
    x86inc.asm to be `.note.GNU-stack ...`, through the `SECTION`
    directive [2].
    
    Thus, the `.note.GNU-stack` section is defined twice
    (once in x86inc.asm, once during `endstruc`), causing the warning.
    
    That is the first part of the commit: using the primitive `[section]` format
    for .note.GNU-stack etc., which does not update `__SECT__` [2].
    
    That fixes only half of the problem. Even without any `SECTION` directives,
    `__SECT__` is predefined as `.text`, which conflicting with the later
    `SECTION_TEXT` (which expands to `.text align=16`).
    
    [1]: http://www.nasm.us/doc/nasmdoc6.html#section-6.4
    [2]: http://www.nasm.us/doc/nasmdoc6.html#section-6.3Signed-off-by: 's avatarLuca Barbato <lu_zero@gentoo.org>
    dd4d709b
x86inc.asm 39.4 KB