• Rostislav Pehlivanov's avatar
    aacenc_pred: rework the way prediction is done · 44ddee94
    Rostislav Pehlivanov authored
    This commit completely alters the algorithm of prediction.
    The original commit which introduced prediction was completely
    incorrect to even remotely care about what the actual coefficients
    contain or whether any options were enabled. Not my actual fault.
    
    This commit treats prediction the way the decoder does and expects
    to do: like lossy encryption. Everything related to prediction now
    happens at the very end but just before quantization and encoding
    of coefficients. On the decoder side, prediction happens before
    anything has had a chance to even access the coefficients.
    
    Also the original implementation had problems because it actually
    touched the band_type of special bands which already had their
    scalefactor indices marked and it's a wonder the asserion wasn't
    triggered when transmitting those.
    
    Overall, this now drastically increases audio quality and you should
    think about enabling it if you don't plan on playing anything encoded
    on really old low power ultra-embedded devices since they might not
    support decoding of prediction or AAC-Main. Though the specifications
    were written ages ago and as times change so do the FLOPS.
    Signed-off-by: 's avatarRostislav Pehlivanov <atomnuker@gmail.com>
    44ddee94
aacenc_pred.h 1.64 KB