• Marton Balint's avatar
    avformat/utils: return pending IO error on EOF in av_read_frame() · ce1fcc8c
    Marton Balint authored
    avio_feof() returns true both in case of actual EOF and in case of IO errors.
    Some demuxers (matroska) have special handling to be able to return the proper
    error for this exact reason, e.g.:
    
    if (avio_feof(pb)) {
         if (pb->error) {
             return pb->error;
         } else {
             return AVERROR_EOF;
         }
    }
    
    However, most of the demuxers do not, and they simply return AVERROR_EOF if
    avio_feof() is true, so there is a real chance that IO errors are mistaken for
    EOF.
    
    We might just say that the API user should always check the IO context error
    attribute on EOF to make sure no IO errors happened, but not even ffmpeg.c does
    this. It should be more intuitive to the API user if we simply return the IO
    error as the return value of av_read_frame() instead of AVERROR_EOF.
    Signed-off-by: 's avatarMarton Balint <cus@passwd.hu>
    ce1fcc8c
utils.c 200 KB