• Andreas Rheinhardt's avatar
    avformat/matroskaenc: Make output more deterministic · ccadd00a
    Andreas Rheinhardt authored
    Using random values for TrackUID and FileUID (as happens when the
    AVFMT_FLAG_BITEXACT flag is not set) has the obvious downside of making
    the output indeterministic. This commit mitigates this by writing the
    potentially random values with a fixed size of eight byte, even if their
    actual values would fit into less than eight bytes. This ensures that
    even in non-bitexact mode, the differences between two files generated
    with the same settings are restricted to a few bytes in the header.
    (Namely the SegmentUID, the TrackUIDs (in Tracks as well as when
    referencing them via TagTrackUID), the FileUIDs (in Attachments as
    well as in TagAttachmentUID) as well as the CRC-32 checksums of the
    Info, Tracks, Attachments and Tags level-1-elements.) Without this
    patch, there might be an offset/a size difference between two such
    files.
    
    The FATE-tests had to be updated because the fixed-sized UIDs are also
    used in bitexact mode.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    ccadd00a
lavf-mkv 2.83 KB