• Aaron Levinson's avatar
    libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1 · 5b281b47
    Aaron Levinson authored
    Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL
    is greater than 1.  This is only relevant when thread.h is included by
    C++ files.  In this case, the relevant code is only defined if
    HAVE_PTHREADS is defined as 1.  Use configure --assert-level=2 to do
    so.
    
    Note: Issue discovered as a result of Coverity build failure.  Cause
    of build failure pinpointed by Hendrik Leppkes.
    
    Comments:
    
    -- libavutil/thread.h: Altered ASSERT_PTHREAD_NORET definition such
       that it uses av_make_error_string instead of av_err2str().
       av_err2str() uses a "parenthesized type followed by an initializer
       list", which is apparently not valid C++.  This issue started
       occurring because thread.h is now included by the DeckLink C++
       files.  The alteration does the equivalent of what av_err2str()
       does, but instead declares the character buffer as a local
       variable.
    Signed-off-by: 's avatarMarton Balint <cus@passwd.hu>
    5b281b47
thread.h 5.37 KB