• wm4's avatar
    matroskadec: export cover art correctly · 511585ce
    wm4 authored
    Generally, libavformat exports cover art pictures as video streams with
    1 packet and AV_DISPOSITION_ATTACHED_PIC set. Only matroskadec exported
    it as attachment with codec_id set to AV_CODEC_ID_MJPEG.
    
    Obviously, this should be consistent, so change the Matroska demuxer to
    export a AV_DISPOSITION_ATTACHED_PIC pseudo video stream.
    
    Matroska muxing is probably incorrect too. I know that it can create
    broken files with an audio track and just 1 video frame when e.g.
    remuxing mp3 with APIC to mkv. But for now this commit does not change
    anything about muxing, and also continues to write attachments with
    AV_CODEC_ID_MJPEG should the muxer application have special knowledge
    that the Matroska is broken in this way.
    
    Fixes trac #4423.
    Signed-off-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
    511585ce
matroskaenc.c 73.6 KB