• Andreas Rheinhardt's avatar
    avcodec/ttaenc: Fix undefined shift · 3ab488a5
    Andreas Rheinhardt authored
    ttaenc contained (1 << unary) - 1 as an argument for a function
    expecting an unsigned int. unary can be as big as 31 in this case.
    The type of the shift and the whole expression is int, because 1 fits
    into an integer, so that the behaviour is undefined if unary == 31
    as the result of the shift can't be represented in an int §. Subtraction
    by 1 (which makes the result of the whole expression representable in
    an int) doesn't change that this is undefined (it usually leads to
    signed integer overflow which is undefined, too).
    
    The solution is simple: Make 1 unsigned to change the type of the
    whole expression to unsigned int (as the function expects anyway).
    
    Fixes ticket #8153.
    
    §: This of course presupposes the common int range of -2^31..2^31-1
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    Reviewed-by: 's avatarPaul B Mahol <onemda@gmail.com>
    Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    3ab488a5
ttaenc.c 6.81 KB