• Martin Storsjö's avatar
    rtmpproto: Move the flv header/trailer addition to append_flv_data · 24fee953
    Martin Storsjö authored
    update_offset is also called from handle_metadata, where the
    packet header sizes is already included in the size.
    
    Previously this lead to flv_data/flv_size including 15 uninitialized
    bytes at the end after each call to handle_metadata, making the
    flv demuxer lose sync with the stream.
    
    Also remove leftover copying in handle_metadata. This is a leftover
    from the refactoring in 58404738. (Previously this final mempcy was
    the one that copied all the packets at once, while this is done
    within the loop right now.) After making sure flv_size is set to
    the right size, this write was out of bounds.
    Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
    24fee953
rtmpproto.c 90.4 KB