• Andreas Rheinhardt's avatar
    avformat/oggenc: Avoid allocating and copying when writing page data · d0bd00c8
    Andreas Rheinhardt authored
    When the Ogg muxer writes a page, it has to do three things: It needs to
    write a page header, then it has to actually copy the page data and then
    it has to calculate and write a CRC checksum of both header as well as
    data at a certain position in the page header.
    
    To do this, the muxer used a dynamic buffer for both writing as well as
    calculating the checksum via an AVIOContext's feature to automatically
    calculate checksums on the data it writes. This entails an allocation of
    an AVIOContext, of the opaque specific to dynamic buffers and of the
    buffer itself (which may be reallocated multiple times) as well as
    memcopying the data (first into the AVIOContext's small write buffer,
    then into the dynamic buffer's big buffer).
    
    This commit changes this: The page header is no longer written into a
    dynamic buffer any more; instead the (small) page header is written into
    a small buffer on the stack. The CRC is then calculated directly via
    av_crc() on both the page header as well as the page data. Then both the
    page header and the page data are written.
    
    Finally, ogg_write_page() can now no longer fail, so it has been
    modified to return nothing; this also fixed a bug in the only caller of
    this function: It didn't check the return value.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    d0bd00c8
oggenc.c 29.3 KB