• Martin Storsjö's avatar
    rtmpproto: Only prepend @setDataFrame for onMetaData and |RtmpSampleAccess · 01eac895
    Martin Storsjö authored
    Currently, when streaming to an RTMP server, any time a packet of type
    RTMP_PT_NOTIFY is encountered, the packet is prepended with @setDataFrame
    before it gets sent to the server. This is incorrect; only packets for
    onMetaData and |RtmpSampleAccess should invoke @setDataFrame on the RTMP
    server. Specifically, the current bug manifests itself when trying to
    stream onTextData or onCuePoint invocations.
    
    This fix addresses that problem and ensures that the @setDataFrame is
    only prepended for onMetaData and |RtmpSampleAccess.
    
    Since data is fed to the rtmp_write function in smaller pieces (depending
    on the calling IO buffer size), we can't generally assume that the
    whole packet (or even the whole command string) is available at once,
    therefore we can only check the command string once the full packet
    has been transferred to us for sending.
    
    Based on a patch by Jeffrey Wescott.
    Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
    01eac895
rtmpproto.c 103 KB