-
Chris Blume authored
This reverts commit 9ce8be33. Reason for revert: To apply fix Original change's description: > Revert "Support multiple VS installations" > > This reverts commit 36d41cef. > > Reason for revert: Script references VS_VERSION variable that was > renamed in the prior change, so it doesn't work. > > Original change's description: > > Support multiple VS installations > > > > Currently, package_from_installed.py assumes only one version of VS is > > installed. It takes the path of the first installation. > > > > This could be incorrect in several ways: > > - Maybe both 2017 and 2019 (the supported versions) are installed and > > although the user specified using 2019, the 2017 path comes first. > > - Maybe 2019 and 2022 are installed, and the 2022 path is used even > > though it isn't supported. > > > > This CL fixes that issue by parsing the vswhere.exe output to confirm > > the VS version matches what the user specified, using its corresponding > > path. > > > > Change-Id: I2029a4f7126d0a45b5370ad58ab257df55571b3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722 > > Reviewed-by: Gavin Mak <gavinmak@google.com> > > Reviewed-by: Chris Blume <cblume@chromium.org> > > Commit-Queue: Chris Blume <cblume@chromium.org> > > Auto-Submit: Chris Blume <cblume@chromium.org> > > Change-Id: I3d9147a7786f7f54f861087d16967b75d4afe2c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3504193 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Change-Id: Ica90cb8d5ce08b8b127da64969401cb40d4aee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497899Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org>
bd68291e
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
OWNERS | ||
README.md | ||
get_toolchain_if_necessary.py | ||
package_from_installed.py |