• Aaron Gable's avatar
    Let git_footers split final paragraphs in specific cases · 4be31878
    Aaron Gable authored
    Suppose the final paragraph of a commit message looks like this:
        """
        And here's the final paragraph.
        Bug: 1234
        TBR=soandso
        Change-Id: deadbeef
        """
    In this case, we don't want to lose the Bug and Change-Id footers,
    so we process the whole final paragraph. *But* we'd also like to
    help the user get things formatted correctly. This change lets
    git_footers notice this situation, and insert a newline before the
    first well-formed footer (Bug: in this case), so that the set of
    well- and mal-formed footers are separated from the rest of the
    malformed body text.
    
    In the rare case where the last line of the last non-trailer paragraph
    is a url, this will also visibly push the url into the block of
    trailers (where it doesn't belong), prompting the user to fix it.
    A more comprehensive fix for that particular case is coming later.
    
    Bug: 766234
    Change-Id: I6ae0072fff68ddf06e6f43b70f9a82a7f247f4ab
    Reviewed-on: https://chromium-review.googlesource.com/849481Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Aaron Gable <agable@chromium.org>
    4be31878
Name
Last commit
Last update
..
gstools Loading commit data...
auth_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
checkout_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch_test.py Loading commit data...
presubmit_unittest.py Loading commit data...
recipes_test.py Loading commit data...
scm_unittest.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...