• Andrii Shyshkalov's avatar
    bot_update: really check whether repo is pinned at an actual sha1 revision. · c6e57bb7
    Andrii Shyshkalov authored
    Previously, anything not equal to HEAD meant pinned revision.
    This backfired on values like "origin/master" which are meant as
    equivalent to HEAD, but which bot_update tried to ensure exist in
    checkout, which was refreshed several times under assumption that
    this is eventual consistency of git servers.
    
    Instead, this CL treats repo as pinned if and only if the treeish
    of the repo is matching sha1 regex.
    
    R=hinoka@chromium.org
    
    Bug: 838292
    Change-Id: I9cb46535f46b2898cf54900ede7960ba08770d77
    Post-Scriptum: git bisect + Led is awesome, took only 8 manual steps.
    Reviewed-on: https://chromium-review.googlesource.com/1035793Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
    Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    c6e57bb7
Name
Last commit
Last update
..
bot_update Loading commit data...
cipd Loading commit data...
depot_tools Loading commit data...
gclient Loading commit data...
gerrit Loading commit data...
git Loading commit data...
git_cl Loading commit data...
gitiles Loading commit data...
gsutil Loading commit data...
infra_paths Loading commit data...
presubmit Loading commit data...
tryserver Loading commit data...
OWNERS Loading commit data...