• Josip Sokcevic's avatar
    Revert "Set a default got_revision property in the bot_update json output." · a0382d39
    Josip Sokcevic authored
    This reverts commit 05381726.
    
    Reason for revert: we reverted got_revision change, and this change
    itself may be causing some other failues.
    
    Original change's description:
    > Set a default got_revision property in the bot_update json output.
    >
    > The bot_update.py script sets a got_revision property by default even if
    > it is not present in the reverse revision mapping. This results in an
    > uncaught exception when set_output_commit is set to True if got_revision
    > isn't present in the reverse revision mapping, but it isn't caught until
    > production because the test API doesn't match that behavior. This change
    > updates the test API method to match the behavior of the script.
    >
    > Recipe-Nontrivial-Roll: build
    > Recipe-Nontrivial-Roll: build_limited
    > Recipe-Nontrivial-Roll: chromiumos
    > Recipe-Nontrivial-Roll: infra
    > Change-Id: Ideefa9d77d2a816ae66a2bb52737264ed3f5bcee
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575361
    > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
    > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
    > Commit-Queue: Garrett Beaty <gbeaty@google.com>
    > Auto-Submit: Garrett Beaty <gbeaty@google.com>
    
    Change-Id: Ie975dfe39e7b8997336761e12f53f3046359d825
    Recipe-Nontrivial-Roll: build
    Recipe-Nontrivial-Roll: build_limited
    Recipe-Nontrivial-Roll: chromiumos
    Recipe-Nontrivial-Roll: infra
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3578820
    Auto-Submit: Josip Sokcevic <sokcevic@google.com>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    a0382d39
Name
Last commit
Last update
..
add_blamelists.json Loading commit data...
add_blamelists_bot_update_failure.json Loading commit data...
basic.json Loading commit data...
basic_with_branch_heads.json Loading commit data...
bot_update_failure.json Loading commit data...
clobber.json Loading commit data...
deprecated_got_revision_mapping.json Loading commit data...
gerrit_no_rebase_patch_ref.json Loading commit data...
gerrit_no_reset.json Loading commit data...
input_commit_with_id_without_repo.json Loading commit data...
multiple_patch_refs.json Loading commit data...
no_apply_patch_on_gclient.json Loading commit data...
no_cp_checkout_HEAD.json Loading commit data...
no_cp_checkout_a_branch_head.json Loading commit data...
no_cp_checkout_a_specific_commit.json Loading commit data...
no_cp_checkout_main.json Loading commit data...
origin_main.json Loading commit data...
refs.json Loading commit data...
reset_root_solution_revision.json Loading commit data...
resolve_chromium_fixed_version.json Loading commit data...
revision_fallback_chain_set_output_commit.json Loading commit data...
revision_specifying_ref.json Loading commit data...
tryjob_fail.json Loading commit data...
tryjob_fail_patch.json Loading commit data...
tryjob_fail_patch_download.json Loading commit data...
tryjob_gerrit_angle.json Loading commit data...
tryjob_gerrit_branch_heads.json Loading commit data...
tryjob_gerrit_feature_branch.json Loading commit data...
tryjob_gerrit_v8_feature_branch.json Loading commit data...
tryjob_gerrit_webrtc.json Loading commit data...
tryjob_v8.json Loading commit data...
tryjob_v8_head_by_default.json Loading commit data...
unrecognized_commit_repo.json Loading commit data...
with_experiments.json Loading commit data...
with_tags.json Loading commit data...