• Quinten Yearsley's avatar
    Remove some unused private things in git_cl · 90a67e2f
    Quinten Yearsley authored
    There are many functions in git_cl that appear unused, although
    it's possible that some of them are used in other places, where
    git_cl may be imported as a library.
    
    This CL just removes some of the private ones, which at least
    were not supposed to be used from other places.
    
    Things removed here:
    
     - _get_commiter_timestamp
     - _git_amend_head
     - GitCookiesChecker._get_usernames_of_domain
     - constants MERGE_BRANCH, CHERRY_PICK_BRANCH;
       the comment says that these are supposed to
       be used in CMDland, but apparently they aren't.
       contextlib which is only used by this, is also
       removed
     - CodereviewSettingsFileMock in git_cl_test;
       it is not used anywhere in the test, and I
       assume that nobody's importing and using
       git_cl_test...
    
    git_cl_test still passes, git cl seems to still work
    
    Change-Id: Ib8eee0dfb181c8cda04c0894d2daea52b3ad42ac
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818621Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@google.com>
    Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
    90a67e2f
Name
Last commit
Last update
..
gstools Loading commit data...
OWNERS Loading commit data...
auth_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
cipd_bootstrap_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
metrics_test.py Loading commit data...
ninjalog_uploader_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
presubmit_unittest.py Loading commit data...
recipes_test.py Loading commit data...
roll_dep_test.py Loading commit data...
scm_unittest.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...