• Andrii Shyshkalov's avatar
    Fix git cl on windows for git-numberer repos. · 351c61da
    Andrii Shyshkalov authored
    Git cl decides if git-numberer is enabled on a repository by writing
    Gerrit's project.config from refs/meta/config into a tempfile, which is
    then queried using `git config -f tempfile --get ...`.  The file itself
    is only flushed, but not closed after writing because Python's
    tempfile.NamedTemporaryFile is deleted on closing. This worked fine on
    Linix/Mac, but not on Windows, where `git config` apparently doesn't see
    file or its contents.
    
    This CL rewrites the above using yet another contexmanager temp
    directory into which a file is written and closed before git config is
    ran.
    
    R=machenbach@chromium.org,grt@chromium.org
    BUG=683202
    
    Change-Id: I7974d66b1b2b0478ab4b6f7ac04e547a4981c46c
    Reviewed-on: https://chromium-review.googlesource.com/430719
    Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    Reviewed-by: 's avatarVadim Shtayura <vadimsh@chromium.org>
    351c61da
Name
Last commit
Last update
..
gstools Loading commit data...
subversion_config Loading commit data...
abandon.sh Loading commit data...
basic.sh Loading commit data...
bot_update_coverage_test.py Loading commit data...
checkout_test.py Loading commit data...
download_from_google_storage_unittests.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
hooks.sh Loading commit data...
owners.sh Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch.sh Loading commit data...
patch_test.py Loading commit data...
post-land-hook-test.sh Loading commit data...
presubmit_unittest.py Loading commit data...
push-from-logs.sh Loading commit data...
recipes_test.py Loading commit data...
rietveld_test.py Loading commit data...
sample_pre_commit_hook Loading commit data...
save-description-on-failure.sh Loading commit data...
scm_unittest.py Loading commit data...
submit-from-new-dir.sh Loading commit data...
subprocess2_test.py Loading commit data...
test-lib.sh Loading commit data...
upload-local-tracking-branch.sh Loading commit data...
upload-stale.sh Loading commit data...
upload_to_google_storage_unittests.py Loading commit data...
watchlists_unittest.py Loading commit data...