-
Ben Pastene authored
This reverts commit dba1d65a. Reason for revert: "Check* takes exactly 3 arguments (2 given)" presubmit errors eg: https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/933062? https://crbug.com/1113506 Original change's description: > [Fixed from older branch] Timing/RDB for lower-level checks > > presubmit: Report timing to rdb for individual checks > Rather than using CheckChangeOnCommit() or CheckChangeOnUpload() as the > sole entry points for PRESUBMIT.py files, this cl enables presubmit_support.py > to use any CheckXYZ[OnCommit/Upload] function to serve as an entry point. > > This way, we can perform timing and RDB reporting for each of the > presubmit check functions and have check-specific data. > > Bug: 1106943 > Change-Id: Ifdabd68c0904a6d70a828f12de157369c6c1571d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2332321 > Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> TBR=dpranke@google.com,estaab@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,saagarsanghavi@google.com Change-Id: Ibd80f70661d2196f903f0c6b79eb74eda6c94d44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106943, 1113506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340692Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
8351dc1f