• Bruce Dawson's avatar
    Print presubmit messages in a consistent order · 76fe1a70
    Bruce Dawson authored
    Presubmit message types were printed in an inconsistent order, generally
    determined by which type was encountered first. This unpredictability
    can be confusing when comparing runs. This change enforces a consistent
    order, in increasing order of severity. ERRORS always go last so that
    they will be the most visible when running presubmits locally.
    
    This also adds a "There were Python %d presubmit errors." message to
    the end to make it easier to tell when there were presubmit errors.
    This is particularly useful when manually running presubmits.
    
    Bug: 1309977
    Change-Id: Ib2b73c7625789bad5b21ae12abf238b746cd11e1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3668724Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    76fe1a70
Name
Last commit
Last update
..
gstools Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
auth_test.py Loading commit data...
autoninja_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
cipd_bootstrap_test.py Loading commit data...
detect_host_arch_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fetch_test.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_cipd_smoketest.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_git_mutates_smoketest.py Loading commit data...
gclient_git_smoketest.py Loading commit data...
gclient_paths_test.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_smoketest_base.py Loading commit data...
gclient_test.py Loading commit data...
gclient_transitions_smoketest.py Loading commit data...
gclient_utils_test.py Loading commit data...
gerrit_client_test.py Loading commit data...
gerrit_util_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_find_releases_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_map_test.py Loading commit data...
git_migrate_default_branch_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
lockfile_test.py Loading commit data...
metrics_test.py Loading commit data...
my_activity_test.py Loading commit data...
ninjalog_uploader_test.py Loading commit data...
owners_client_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
presubmit_unittest.py Loading commit data...
rdb_wrapper_test.py Loading commit data...
recipes_test.py Loading commit data...
roll_dep_test.py Loading commit data...
scm_unittest.py Loading commit data...
split_cl_test.py Loading commit data...
subcommand_test.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
utils_test.py Loading commit data...
watchlists_unittest.py Loading commit data...