• Aaron Gable's avatar
    Capture ctrl-c in presubmit multiprocessing pool · 873c28d1
    Aaron Gable authored
    Presubmit spins up lots of multiprocessing processes to run
    each individual test. If you cancel your presubmit run with
    <ctrl>+c, that signal gets passed through to each of those,
    which then raises its own KeyboardInterrupt, and prints its
    own stacktrace.
    
    This change has each member of the multiprocessing pool instead
    exit gracefully (albeit with an error code) so that only the
    parent process prints its stacktrace.
    
    R=michaelpg@chromium.org
    
    Bug: 635196
    Change-Id: If9081910a359889a43bc1b72c91a859ebe37a1d6
    Reviewed-on: https://chromium-review.googlesource.com/651764Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
    Commit-Queue: Aaron Gable <agable@chromium.org>
    873c28d1
Name
Last commit
Last update
..
gstools Loading commit data...
abandon.sh Loading commit data...
basic.sh Loading commit data...
bot_update_coverage_test.py Loading commit data...
checkout_test.py Loading commit data...
download_from_google_storage_unittests.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
hooks.sh Loading commit data...
owners.sh Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch.sh Loading commit data...
patch_test.py Loading commit data...
post-land-hook-test.sh Loading commit data...
presubmit_unittest.py Loading commit data...
push-from-logs.sh Loading commit data...
recipes_test.py Loading commit data...
rietveld_test.py Loading commit data...
save-description-on-failure.sh Loading commit data...
scm_unittest.py Loading commit data...
submit-from-new-dir.sh Loading commit data...
subprocess2_test.py Loading commit data...
test-lib.sh Loading commit data...
upload-local-tracking-branch.sh Loading commit data...
upload-stale.sh Loading commit data...
upload_to_google_storage_unittests.py Loading commit data...
watchlists_unittest.py Loading commit data...