• Edward Lemur's avatar
    metrics: Separate metrics collection and print notice logic. · 6f812e13
    Edward Lemur authored
    As it is right now, when a function is collecting metrics it prints
    the notice and calls sys.exit() to ensure the notice is the last thing
    that is printed.
    
    git-cl split has to call git-cl upload multiple times, but once it has
    been called once, it exits, so only the first cl is uploaded.
    
    This separates metrics collection from notice printing, so that the
    function that is collecting metrics behaves like a function that isn't.
    It also makes sure we don't collect metrics for multiple functions at
    the same time.
    
    Bug: 868280
    Change-Id: Ic58ebe7d19e09ed85fa8b0af76dcbf608ee4c9bc
    Reviewed-on: https://chromium-review.googlesource.com/1153503Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
    Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    6f812e13
Name
Last commit
Last update
..
gstools Loading commit data...
auth_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
checkout_test.py Loading commit data...
cipd_bootstrap_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
metrics_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch_test.py Loading commit data...
presubmit_unittest.py Loading commit data...
recipes_test.py Loading commit data...
roll_dep_test.py Loading commit data...
scm_unittest.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...