• tandrii's avatar
    git cl: cleanup branch config get/set/unset. · 5d48c32f
    tandrii authored
    Previously there was a soup with add-hoc formatting with
    current branch name, which wasn't always set (see bug 611020).
    This CL makes sure all such operations now:
     * properly use types --int and --bool
     * go through the *only* appropriate get/set/unset function.
    
    Furthermore, tests were a mess wrt to raising exceptions when
    git processes terminated with an exception. This CL cleaned up,
    though I didn't go through all expectations, so some returns of
    empty stdout instead of raising CalledProcess error are likely
    remaining.
    
    Disclaimer: this CL is not necessarily fixing the referenced bug
    below, but it should at least provide better stacktrace when
    the bug manifestst itself.
    
    BUG=611020
    R=agable@chromium.org
    
    Review-Url: https://codereview.chromium.org/2259043002
    5d48c32f
Name
Last commit
Last update
..
gstools Loading commit data...
subversion_config Loading commit data...
abandon.sh Loading commit data...
basic.sh Loading commit data...
checkout_test.py Loading commit data...
download_from_google_storage_unittests.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
hooks.sh Loading commit data...
owners.sh Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
patch.sh Loading commit data...
patch_test.py Loading commit data...
post-dcommit-hook-test.sh Loading commit data...
presubmit_unittest.py Loading commit data...
push-basic.sh Loading commit data...
push-from-logs.sh Loading commit data...
recipes_test.py Loading commit data...
rename.sh Loading commit data...
rietveld_test.py Loading commit data...
sample_pre_commit_hook Loading commit data...
save-description-on-failure.sh Loading commit data...
scm_unittest.py Loading commit data...
submit-from-new-dir.sh Loading commit data...
submodule-merge-test.sh Loading commit data...
subprocess2_test.py Loading commit data...
test-lib.sh Loading commit data...
trychange_unittest.py Loading commit data...
upload-local-tracking-branch.sh Loading commit data...
upload-stale.sh Loading commit data...
upload_to_google_storage_unittests.py Loading commit data...
upstream.sh Loading commit data...
watchlists_unittest.py Loading commit data...