• dpranke@chromium.org's avatar
    Use author as determined from scm if we can not get it from rietveld · f6ddfa4b
    dpranke@chromium.org authored
    Until an issue is uploaded to Rietveld, we don't know the official
    email address to use for an owners check. There are three ways to fix
    this: we could attempt to log in to rietveld prior to doing the check
    and extract the address to use, or we could use ~/.last_codereview_email_address,
    or we can use the email address we can determine from the checkout.
    
    All three options have flaws; the first is particularly awkward since there
    doesn't seem to be a good way to fetch the email without posting an issue.
    The second is flawed if we use different addresses for different repos,
    and the third is flawed if the checkout's email address is different from
    the rietveld address, or if it is anonymous.
    
    However, since this is only being used for owners checks (in this case),
    anonymous checkouts probably don't matter, and hopefully the cases where
    the email addresses differ are rare.
    
    R=maruel@chromium.org
    BUG=118388, 150049
    
    
    Review URL: https://chromiumcodereview.appspot.com/12377023
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98
    f6ddfa4b
Name
Last commit
Last update
..
subversion_config Loading commit data...
abandon.sh Loading commit data...
basic.sh Loading commit data...
breakpad_unittest.py Loading commit data...
checkout_test.py Loading commit data...
fix_encoding_test.py Loading commit data...
gcl_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cl_test.py Loading commit data...
hooks.sh Loading commit data...
owners.sh Loading commit data...
owners_unittest.py Loading commit data...
patch.sh Loading commit data...
patch_test.py Loading commit data...
post-dcommit-hook-test.sh Loading commit data...
presubmit_unittest.py Loading commit data...
push-basic.sh Loading commit data...
push-from-logs.sh Loading commit data...
rename.sh Loading commit data...
rietveld_test.py Loading commit data...
sample_pre_commit_hook Loading commit data...
save-description-on-failure.sh Loading commit data...
scm_unittest.py Loading commit data...
submit-from-new-dir.sh Loading commit data...
submodule-merge-test.sh Loading commit data...
subprocess2_test.py Loading commit data...
test-lib.sh Loading commit data...
trychange_unittest.py Loading commit data...
upload-local-tracking-branch.sh Loading commit data...
upload-stale.sh Loading commit data...
upstream.sh Loading commit data...
watchlists_unittest.py Loading commit data...