-
Chris Blume authored
Currently, package_from_installed.py assumes only one version of VS is installed. It takes the path of the first installation. This could be incorrect in several ways: - Maybe both 2017 and 2019 (the supported versions) are installed and although the user specified using 2019, the 2017 path comes first. - Maybe 2019 and 2022 are installed, and the 2022 path is used even though it isn't supported. This CL fixes that issue by parsing the vswhere.exe output to confirm the VS version matches what the user specified, using its corresponding path. Change-Id: I2029a4f7126d0a45b5370ad58ab257df55571b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org>
36d41cef
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
OWNERS | ||
README.md | ||
get_toolchain_if_necessary.py | ||
package_from_installed.py |