Commits · ff8ce0e5a0d1dd510824c26976cf15001f4a053e · Linshizhi / Chromium_Depot_tools

25 Apr, 2016 2 commits

depot_tools: expose path to cros · ff8ce0e5

phajdan.jr@chromium.org authored Apr 25, 2016

Needed for https://codereview.chromium.org/1922503002

BUG=chromium:585401

Review URL: https://codereview.chromium.org/1917803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300135 0039d316-1c4b-4281-b951-d872f2087c98

ff8ce0e5

Use CLs more consistently instead of branch names · 81156e6c

clemensh@chromium.org authored Apr 25, 2016

Review URL: https://codereview.chromium.org/1893563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300132 0039d316-1c4b-4281-b951-d872f2087c98

81156e6c

22 Apr, 2016 4 commits

Revert of Convert cpplint.py to work with nested git repositories. (patchset... · 95a5ad89

kjellander@chromium.org authored Apr 22, 2016

Revert of Convert cpplint.py to work with nested git repositories. (patchset #1 id:1 of https://codereview.chromium.org/1897153003/ )

Reason for revert:
This breaks WebRTC presubmit on the buildbots (due to /b/build being a Git repo, which in turn contains the checkout). See  https://bugs.chromium.org/p/webrtc/issues/detail?id=5818 for more details.

It seems it also broke other projects (rakuco's comment #15).



Original issue's description:
> Convert cpplint.py to work with nested git repositories.
> 
> Chrome on iOS downstream repository tracks Chromium via DEPS and wants
> to use cpplint canned presubmit check but the cpplint.py errors due at
> the include guard as it stops at the inner most git repository.
> 
> Change cpplint.py to look for the outermost git repository when looking
> for the repository root.
> 
> BUG=598090
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300085

TBR=iannucci@chromium.org,skym@chromium.org,sdefresne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598090

Review URL: https://codereview.chromium.org/1919483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300119 0039d316-1c4b-4281-b951-d872f2087c98

95a5ad89

Roll recipe dependencies (trivial). · 47a782f5

recipe-roller@chromium.org authored Apr 22, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/633abf8d47e44241203369a7e4eb926b832c6dff recipe_engine: properly print error even if invalid base path is a tuple (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1906383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300110 0039d316-1c4b-4281-b951-d872f2087c98

47a782f5

bot_update: call gclient sync after checking out a gerrit ref · 76a4900e

phajdan.jr@chromium.org authored Apr 22, 2016

BUG=chromium:602906

Review URL: https://codereview.chromium.org/1904663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300109 0039d316-1c4b-4281-b951-d872f2087c98

76a4900e

Fix git help on 32-bit Windows · ae430379

iannucci@chromium.org authored Apr 22, 2016

BUG=604018

Review URL: https://codereview.chromium.org/1894803002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300104 0039d316-1c4b-4281-b951-d872f2087c98

ae430379

21 Apr, 2016 3 commits

Convert cpplint.py to work with nested git repositories. · 3962862d

sdefresne@chromium.org authored Apr 21, 2016

Chrome on iOS downstream repository tracks Chromium via DEPS and wants
to use cpplint canned presubmit check but the cpplint.py errors due at
the include guard as it stops at the inner most git repository.

Change cpplint.py to look for the outermost git repository when looking
for the repository root.

BUG=598090

Review URL: https://codereview.chromium.org/1897153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300085 0039d316-1c4b-4281-b951-d872f2087c98

3962862d

Roll recipe dependencies (trivial). · f6b2eb69

recipe-roller@chromium.org authored Apr 21, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4194868d9f0bf2e8f8fc86198a01ebfbfe0f6164 Fix gerrit tryproperties to be more realistic. (tandrii@chromium.org)

R=phajdan@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=604735

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1910753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300078 0039d316-1c4b-4281-b951-d872f2087c98

f6b2eb69

Roll recipe dependencies (trivial). · a3409c0c

recipe-roller@chromium.org authored Apr 21, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ecf8b481c75c1b1d43a2d7c80ea57c38cca6e9a7 Fix Gerrit tryserver properties test_data. (tandrii@chromium.org)

R=phajdan@chromium.org,tandrii@chromium.org
BUG=604735

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1912663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300076 0039d316-1c4b-4281-b951-d872f2087c98

a3409c0c

20 Apr, 2016 4 commits

Force download and extract if extracted directory is missing · 6f830d75

pauljensen@chromium.org authored Apr 20, 2016

Without this change, the extracted directory could be missing but
the downloaded file could match the hash, and in turn
download_from_google_storage will not download the file and will
not extract it, and any tools depending on the extracted
directory will fail.

Review URL: https://codereview.chromium.org/1904483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300051 0039d316-1c4b-4281-b951-d872f2087c98

6f830d75

Ensure files passed to the editor by RunEditor end in a new line · a3fe2903

gab@chromium.org authored Apr 20, 2016

BUG=605201

Review URL: https://codereview.chromium.org/1905693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300049 0039d316-1c4b-4281-b951-d872f2087c98

a3fe2903

Roll recipe dependencies (trivial). · 82b04aab

recipe-roller@chromium.org authored Apr 20, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c55462b5c2458036648d53e6a4d923a63ed8b7cc Add tryserver_gerrit test properties. (tandrii@chromium.org)

R=phajdan.jr@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=604735

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1907473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300038 0039d316-1c4b-4281-b951-d872f2087c98

82b04aab

Clarify how `new-branch` is different for --help · b14fccd6

techtonik@gmail.com authored Apr 20, 2016

BUG=

Review URL: https://codereview.chromium.org/1875063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300032 0039d316-1c4b-4281-b951-d872f2087c98

b14fccd6

19 Apr, 2016 3 commits

depot_tools: expose path to gn.py · 3f0ac2bd

phajdan.jr@chromium.org authored Apr 19, 2016

BUG=chromium:602906

Review URL: https://codereview.chromium.org/1902043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300016 0039d316-1c4b-4281-b951-d872f2087c98

3f0ac2bd

depot_tools: expose path to gsutil.py · 900392f6

phajdan.jr@chromium.org authored Apr 19, 2016

This is needed for https://codereview.chromium.org/1896113002

BUG=chromium:585401, chromium:593999

Review URL: https://codereview.chromium.org/1897743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300011 0039d316-1c4b-4281-b951-d872f2087c98

900392f6

Fix ancestor check · c3fe99d8

clemensh@chromium.org authored Apr 19, 2016

Before, for the common case that the actual_merge_base was already set
as base, the check for is_ancestor(base, actual_merge_base) would have
caused the base to be re-set.
This is a writing operation, which causes trouble e.g. for the parallel
operation of 'git cl status'.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1888213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300003 0039d316-1c4b-4281-b951-d872f2087c98

c3fe99d8

18 Apr, 2016 3 commits

Gerrit git cl: temporary disable cc option on upload. · 0b2d7072

tandrii@chromium.org authored Apr 18, 2016

Gerrit doesn't allow arbitrary non-member emails for now,
thus removign this feature until either Gerrit allows it,
or we have a per-repo opt-in way.

TBR=andybons@chromium.org
BUG=604377

Review URL: https://codereview.chromium.org/1895863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299988 0039d316-1c4b-4281-b951-d872f2087c98

0b2d7072

Roll recipe dependencies (trivial). · cb66fce9

recipe-roller@chromium.org authored Apr 18, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8fc2d5cb0acb4680fe7175d88af87ef4f6659139 recipe engine: add generic cache directory path (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:585401

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1901743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299983 0039d316-1c4b-4281-b951-d872f2087c98

cb66fce9

Roll recipe dependencies (trivial). · 6acaf399

recipe-roller@chromium.org authored Apr 18, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0fae6ef419bab953b5520eaeab0858d1e8ccf39c recipe engine: use local recipes.py when doing rolls (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:583303

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1901663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299980 0039d316-1c4b-4281-b951-d872f2087c98

6acaf399

15 Apr, 2016 1 commit

Use hyphen for gerrit.skip-ensure-authenticated · 00dbccdc

shinyak@chromium.org authored Apr 15, 2016

git config key should consist of alphanumeric characters and '-'.
The underscore '_' is not allowed. So we're getting 'invalid key' error
when GERRIT_SKIP_ENSURE_AUTHENTICATED is set.

Let's use '-' instead of '_'.

BUG=603378

Review URL: https://codereview.chromium.org/1882833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299952 0039d316-1c4b-4281-b951-d872f2087c98

00dbccdc

14 Apr, 2016 3 commits

Allow to skip EnsureAuthenticated for Gerrit. · 2825353c

tandrii@chromium.org authored Apr 14, 2016

Adding this line to codereview.settings should do the trick:
  GERRIT_SKIP_ENSURE_AUTHENTICATED: true

And I also cleaned up tests so they don't spill too much to stdout.

BUG=603378
R=machenbach@chromium.org,andybons@chromium.org
CC=shinyak@chromium.org

Review URL: https://codereview.chromium.org/1884173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299926 0039d316-1c4b-4281-b951-d872f2087c98

2825353c

Add tandrii@ to watcher of git_cl.py changes. · 9757954b

tandrii@chromium.org authored Apr 14, 2016

Reason: so I can not lgtm/revert anything which doesn't come with
more tests.

R=iannucci@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1873403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299921 0039d316-1c4b-4281-b951-d872f2087c98

9757954b

Roll recipe dependencies (trivial). · 96cb326f

recipe-roller@chromium.org authored Apr 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/86dfd541045ff43443161327b88e8074fc9a55c0 Fix deps_path not being absolute. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1877223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299918 0039d316-1c4b-4281-b951-d872f2087c98

96cb326f

13 Apr, 2016 8 commits

Followup for git cl set-commit tests. · 1a8ef44c

tandrii@chromium.org authored Apr 13, 2016

Based on review of https://codereview.chromium.org/1889483002.

R=sergiyb@chromium.org
BUG=599931

Review URL: https://codereview.chromium.org/1885963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299905 0039d316-1c4b-4281-b951-d872f2087c98

1a8ef44c

git cl: add --gerrit and --rietveld options to force codereview. · dde64625

tandrii@chromium.org authored Apr 13, 2016

This makes it possible to override the codereview set in:
 * repository codereview.settings
 * cached/set in local .git/config, either repo-wide or
   current branch only.

Examples:

    cd $SOME_RIETVELD_USING_REPO
    # Enable Gerrit codereview on it. Contact Infra-Git admin:
    # https://bugs.chromium.org/p/chromium/issues/entry?template=Infra-Git

    # Uploading
    git cl upload --gerrit --squash
    # Hack, hack, re-upload uses Gerrit automatically.
    git cl upload --squash

    # Patching
    git new-branch patched-in-issue
    git cl patch --gerrit XXXXXX

    # (Re-)setting issue
    git cl issue --gerrit 0
    git cl issue --gerrit XXXXXX

R=andybons@chromium.org,sergiyb@chromium.org
BUG=598681

Review URL: https://codereview.chromium.org/1880243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299901 0039d316-1c4b-4281-b951-d872f2087c98

dde64625

git cl set-commit: for Gerrit + dry-run support. · fa330e80

tandrii@chromium.org authored Apr 13, 2016

This provides workaround for not functioning git cl try.

R=sergiyb@chromium.org,andybons@chromium.org,phajdan.jr@chromium.org
BUG=599931

Review URL: https://codereview.chromium.org/1889483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299900 0039d316-1c4b-4281-b951-d872f2087c98

fa330e80

git cl: update Gerrit todos and small nits. · 8930b3d6

tandrii@chromium.org authored Apr 13, 2016

R=andybons@chromium.org
BUG=579160

Review URL: https://codereview.chromium.org/1879393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299894 0039d316-1c4b-4281-b951-d872f2087c98

8930b3d6

Gerrit git cl upload: implement setting cc and reviewers. · 8acd833e

tandrii@chromium.org authored Apr 13, 2016

R=machenbach@chromium.org,andybons@chromium.org
BUG=323819

Review URL: https://codereview.chromium.org/1885883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299887 0039d316-1c4b-4281-b951-d872f2087c98

8acd833e

Gerrit git cl upload: implement patchset title (message). · bf766ba3

tandrii@chromium.org authored Apr 13, 2016

R=machenbach@chromium.org,andybons@chromium.org
BUG=579178

Review URL: https://codereview.chromium.org/1886433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299886 0039d316-1c4b-4281-b951-d872f2087c98

bf766ba3

Fix regression in git cl for Gerrit. · 11a899e0

tandrii@chromium.org authored Apr 13, 2016

TBR=andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1884673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299885 0039d316-1c4b-4281-b951-d872f2087c98

11a899e0

Gerrit git cl upload: add check for missing credentials. · fe30f18f

tandrii@chromium.org authored Apr 13, 2016

Checks creds before uploading and running presubmit, generalizing
the case of Rietveld. If they are missing, suggests a URL to
generate them.

R=andybons@chromium.org,phajdan.jr@chromium.org
BUG=583153

Review URL: https://codereview.chromium.org/1882583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299883 0039d316-1c4b-4281-b951-d872f2087c98

fe30f18f

12 Apr, 2016 3 commits

Check for clang-format only if its files are present · 5573df14

techtonik@gmail.com authored Apr 12, 2016

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1880013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299867 0039d316-1c4b-4281-b951-d872f2087c98

5573df14

Small refactor git cl py. · d03bc634

tandrii@chromium.org authored Apr 12, 2016

R=sergiyb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1876923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299857 0039d316-1c4b-4281-b951-d872f2087c98

d03bc634

Refactor CMDUpload further to avoid checks IsGerrit(). · 9e6c3a55

tandrii@chromium.org authored Apr 12, 2016

R=sergiyb@chromium.org,andybons@chromium.org,machenbach@chromium.org
BUG=579160,597638

Review URL: https://codereview.chromium.org/1875163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299855 0039d316-1c4b-4281-b951-d872f2087c98

9e6c3a55

11 Apr, 2016 6 commits

Refactor git cl RietveldUpload and GerritUpload. · aa6235b1

tandrii@chromium.org authored Apr 11, 2016

No functionality changes.

R=machenbach@chromium.org,andybons@chromium.org
BUG=579160,597638

Review URL: https://codereview.chromium.org/1877893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299844 0039d316-1c4b-4281-b951-d872f2087c98

aa6235b1

Fix git cl checkout when no branch has issues. · 26c8fd2b

tandrii@chromium.org authored Apr 11, 2016

TBR=machenbach@chromium.org
BUG=579182

Review URL: https://codereview.chromium.org/1878613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299843 0039d316-1c4b-4281-b951-d872f2087c98

26c8fd2b

rietveld: retry more transient errors. · 432fb944

tandrii@chromium.org authored Apr 11, 2016

Namely these errors when applying patch:

  <urlopen error [Errno 10060] A connection attempt failed
  because the connected party did not properly respond after
  a period of time, or established connection failed because
  connected host has failed to respond>

  <urlopen error [Errno 104] Connection reset by peer>

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=601260

Review URL: https://codereview.chromium.org/1876093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299837 0039d316-1c4b-4281-b951-d872f2087c98

432fb944

git cl checkout: implement for Gerrit + add test. · 5df290f6

tandrii@chromium.org authored Apr 11, 2016

R=sergiyb@chromium.org,andybons@chromium.org
BUG=579182

Review URL: https://codereview.chromium.org/1873233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299833 0039d316-1c4b-4281-b951-d872f2087c98

5df290f6

Roll recipe dependencies (trivial). · c9f2c3fa

recipe-roller@chromium.org authored Apr 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1880503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299830 0039d316-1c4b-4281-b951-d872f2087c98

c9f2c3fa

git cl checkout: reall fix it. · abd27e5b

tandrii@chromium.org authored Apr 11, 2016

TBR=machenbach@chromium.org,andybons@chromium.org
BUG=579182

Review URL: https://codereview.chromium.org/1874253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299829 0039d316-1c4b-4281-b951-d872f2087c98

abd27e5b