Commits · fdd89469d6813514814b420ba51168cbd243a9d4 · Linshizhi / Chromium_Depot_tools

13 Jan, 2021 2 commits

update stale codereview.chromium.org links · fdd89469

James Zern authored Jan 13, 2021

w/chromium-review.googlesource.com

Change-Id: I8f024d68a3b89ae530fc1ce2806b9b12b83ba7b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2585050Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: James Zern <jzern@google.com>

fdd89469

Change to slash separator to fix a bug on Windows in owners.py · c13ea848

Mandy Chen authored Jan 13, 2021

Some of the owners.py code does not change file path to use the slash
separator, causing owners check to crash on Windows. This CL fixes it.

Change-Id: I6e06a235dbb563ea45691f19b03d826b23184b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626090Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>

c13ea848

12 Jan, 2021 5 commits

Roll recipe dependencies (trivial). · 8149a961

recipe-roller authored Jan 12, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b9d95cda0b959f6935e8330db85ab3ee76c01684
  b9d95cd (chanli@chromium.org)
      [swarming] use get() when getting invocation

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I00d44a695cb5bc771ab5c42b57c4b64518268a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2625399Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8149a961

presubmit: Add owners_client to presubmit API. · 9ce03f80

Edward Lesmes authored Jan 12, 2021

So that presubmit API can use it to check owners
approval.

Change-Id: Ie26c8a83de02b750fd92b4f419fe4d55809e6dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2621745Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

9ce03f80

owners: Move constants inside OwnersClient. · c40b2406

Edward Lesmes authored Jan 12, 2021

When used as part of presubmit's input_api, we only
expose OwnersClient and not global constants, so
move constants inside OwnersClient.

Change-Id: I8983c5edadafeebff62838d9cd4a19fdce908159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2621744
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

c40b2406

Add client not configured message to gclient validate and flatten · f6b414c5

Gavin Mak authored Jan 12, 2021

Running gclient validate or gclient flatten outside of gclient root
results in an unhelpful AttributeError stacktrace. This change adds an
error message that lets the user know the client is not confugred.

Bug: 732733
Change-Id: I33b1a08aa394145e238a4939bfd995ec33a8df17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2624351Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

f6b414c5

Roll out new goma client binary VERSION=210 · 59b0ce20

Yoshisato Yanagisawa authored Jan 12, 2021

Bug: b/174281084
Change-Id: Id248e306cb8e11974fc0846b22b33831fc04a76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2622010
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>

59b0ce20

11 Jan, 2021 4 commits

owners: Initialize db lazily. · 82b992a1

Edward Lesmes authored Jan 11, 2021

This makes it easier to test, e.g. we can mock
DepotToolsClient.BatchListOwners without having to
mock DepotToolsClient first (to avoid initialization).

Change-Id: I9c24ef28ba7a82cd1498e863cc1b4bc825a579d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616900Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

82b992a1

[cipd] Roll Led to a newer version · 3d5ea92a

Yuanjun Huang authored Jan 11, 2021

To release the new Led which uses RBE-CAS.

infra/infra change log:
https://chromium.googlesource.com/infra/infra/+log/657015d..d86f553/
luci-go change log:
https://chromium.googlesource.com/infra/luci/luci-go/+log/71ccb73..5c64c54

Bug:1145959
Change-Id: Ic55890c21a527bb482c902a28fdbc0c2d6e08c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2623107Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>

3d5ea92a

[dirmd] Roll dirmd to e338559 · 0d9d05c4

Chan Li authored Jan 11, 2021

To Include changes:
- https://chromium-review.googlesource.com/c/infra/infra/+/2601378
- https://chromium-review.googlesource.com/c/infra/infra/+/2614222

Bug: 1103287
Change-Id: If6fa29bc7cce08f74baa00b2034371e20f46d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2617502Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

0d9d05c4

Roll recipe dependencies (trivial). · 722b81ef

recipe-roller authored Jan 11, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d0bbd7d86166132343652b1729a9c45f9631f9b4
  d0bbd7d (akashmukherjee@google.com)
      [Provenance] Add single file hash calculation to file module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7d458989a208b22cb01a85d6619e278aa7e0eea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2622857Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

722b81ef

09 Jan, 2021 1 commit

Reland "presubmit: Don't print comments for missing reviewers." · c1aa4ecf

Edward Lesmes authored Jan 09, 2021

This is a reland of 276bab4c

Fixed to include author on the list of reviewers.

Original change's description:
> presubmit: Don't print comments for missing reviewers.
>
> Don't print owners comments when suggesting missing reviewers,
> as this won't be supported when using Gerrit API.
>
> Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I6dfb2087022ad87595e6cabc50d42a8bdf6311b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2615918
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

c1aa4ecf

08 Jan, 2021 3 commits

Reland "[owners] Refactor OwnersClient." · 0e4e5ae5

Edward Lesmes authored Jan 08, 2021

Reland of [1].
Original CL contained some changes to --[tb]r-owners
which are not included in this CL because those changes
were reverted on [2].

- Remove GetChangeApprovalStatus and GetFilesApprovalStatus.
- Make host, project and branch part of GerritClient.
- Rename ListOwnersForFile to ListOwners.

[1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268
[2] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2611219

Change-Id: Ife2051b8be0460d1c6bc4fbe4e3b0a571d12dafb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616130
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

0e4e5ae5

Enable packfile offloading on all builders · 60b433cf

Josip Sokcevic authored Jan 08, 2021

R=ehmaldonado@chromium.org

Bug: 1136986
Change-Id: I012f0d29589460b8cc7809c9c011811dff476a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616898Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

60b433cf

Roll recipe dependencies (trivial). · 11a77f76

recipe-roller authored Jan 08, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/900b191fea68d1c0869204ec58ed0710fbacd283
900b191 (qyearsley@chromium.org)
tricium: Remove hard limit on num comments in recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I150fcf8f926c70af80ed35dd02885f9ff2938fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616899Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

11a77f76

07 Jan, 2021 5 commits

Roll recipe dependencies (trivial). · 4c392afd

recipe-roller authored Jan 07, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a0af0123ab934330280360700d919c074caffa95
a0af012 (sokcevic@google.com)
Use inclusive parameter names in PRESUBMIT

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6316b4cb33c794f7b63db9a3a089d23fd252def8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2615859Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4c392afd

Enable set_output_commit to be used with RevisionFallbackChain. · e856b6bb

Garrett Beaty authored Jan 07, 2021

When set_output_commit is True and the repo associated with the
got_revision property does not use commit positions, buiders whose
gclient config uses RevisionFallbackChain for that repo will raise an
exception when attempting set the output commit because a string is
expected for the revision value, not a RevisionFallbackChain object.
This changes the set_output_commit code to resolve the revision so that
the output commit can be set in those cases.

Bug: 1159749, 1141886
Change-Id: Iddf1d49871028d9500eefb0eed07e36ce7e6b0d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612223
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

e856b6bb

Revert "[git-cl] Use owners client when processing --[tb]r-owners." · 1c3c9391

Stephen Martinis authored Jan 07, 2021

This reverts commit 968b1fe7.

Reason for revert: Appears to be breaking git cl upload for the recipe autoroller with https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858802226988308224/+/steps/infra/0/steps/git_cl_upload/0/stdout. 

Original change's description:
> [git-cl] Use owners client when processing --[tb]r-owners.
>
> Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id561a059eaf1419cbda52b7c0c6a45b5c6f2bd1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2611219Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

1c3c9391

Revert "[owners] Refactor OwnersClient." · b34cd6d8

Edward Lesmes authored Jan 07, 2021

This reverts commit 9c7f6c25.

Reason for revert:
Not working
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858807889610091152/+/steps/franky/0/steps/git_cl_upload/0/stdout

Original change's description:
> [owners] Refactor OwnersClient.
>
> - Remove GetChangeApprovalStatus and GetFilesApprovalStatus.
> - Make host, project and branch part of GerritClient.
> - Rename ListOwnersForFile to ListOwners.
>
> Change-Id: I1f610a64f0217ce54e5ce4a210026535adc1c2e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Gavin Mak <gavinmak@google.com>

TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4928df90856526210a4fd4d104e6cc96aa005bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613925
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b34cd6d8

Revert "presubmit: Don't print comments for missing reviewers." · 3c57b27a

Edward Lesmes authored Jan 07, 2021

This reverts commit 276bab4c.

Reason for revert:
Possible cause of crbug.com/1163731

Original change's description:
> presubmit: Don't print comments for missing reviewers.
>
> Don't print owners comments when suggesting missing reviewers,
> as this won't be supported when using Gerrit API.
>
> Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Bug: 1163731
Change-Id: I0b3d0f352e5483e754f6b790f70a9278df4eb3e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613924Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3c57b27a

06 Jan, 2021 7 commits

Followup fix for https://crrev.com/c/2587268 · d48aa437

Stephen Martinis authored Jan 06, 2021

https://crrev.com/c/2587268 changed function signatures to remove a
project argument. One function call was missed in the CL. This CL fixes
the function call.

Change-Id: Ice45072aa467ed6c56efabf405a7aac03f4b047c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613785Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

d48aa437

[dirmd] Roll dirmd to 3d533070 · 6650f7c2

Nodir Turakulov authored Jan 06, 2021

Roll dirmd to git_revision:3d5330702211e01321af4fb53fec2f2f361137a7
to pick up https://chromium-review.googlesource.com/c/infra/infra/+/2597921

R=ehmaldonado@google.com

Bug: 1154541
Change-Id: I0fd0b56a42b63fd3518396aca0d99dde9fd95547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612385
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6650f7c2

Update error message if unable to determine branch · b038f724

Josip Sokcevic authored Jan 06, 2021

git cl format can't accept branch name as argument as those are reserved
for files that need to be formatted. This CL clarifies what user needs
to do in case git cl is not able to determine upstream branch.

R=apolito@google.com, ehmaldonaldo@chromium.org

Bug: 832295
Change-Id: If6ff517d633b7e70a33dff48f3779f82df30f214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2571838Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

b038f724

presubmit: Don't print comments for missing reviewers. · 276bab4c

Edward Lesmes authored Jan 06, 2021

Don't print owners comments when suggesting missing reviewers,
as this won't be supported when using Gerrit API.

Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

276bab4c

Run git fetch with --prune on failed git cl upload · b631a88c

Josip Sokcevic authored Jan 06, 2021

git fetch --prune removes all references that no longer exist on remote
server. This allows git cl to upload changes to correct destination
branch.

R=ehmaldonado@chromium.org

Bug: 1149640
Change-Id: I66bf8d2209242b08991c2dae0d3a7fbc892cef87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2606613Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

b631a88c

Roll recipe dependencies (trivial). · 3a03505a

recipe-roller authored Jan 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d31ba13ede8c21e60116ae61e4490d53ba77fcbd
  d31ba13 (chanli@chromium.org)
      [resultdb] Add query() to resultdb recipe_module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I63e587a289cee99e0eace03dfb9a7b359469c4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2610997Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3a03505a

Roll recipe dependencies (trivial). · 6128ceac

recipe-roller authored Jan 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/905f47eac24f0263ace20232e86fe3af6ed34ecb
  905f47e (chanli@chromium.org)
      [swarming] Expose swarming task invocation names

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic1037dbea9b08c52a2fbdb184775ca1f9e8ef9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612444Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6128ceac

05 Jan, 2021 3 commits

[cipd] Update CIPD client to 2.5.1. · ac96016a

Vadim Shtayura authored Jan 05, 2021

To pick up https://chromium-review.googlesource.com/c/2594178.

The new version uses another zip compression library.

R=iannucci@chromium.org
BUG=1163308

Change-Id: Ib9df5e033c7c43fad4d19e8cfad47a8de664d0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612114Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

ac96016a

Revert "Use HEAD instead of hardcoded branch" · 7e735122

Josip Sokcevic authored Jan 05, 2021

This reverts commit 6651fd88.

Reason for revert: broke some cros builds (check original CL for
discussion)

Original change's description:
> Use HEAD instead of hardcoded branch
>
> Repositories may have different default branches. This ensures to fetch
> remote HEAD branch which is default branch. Only downside to this
> approach is that actual branch (e.g. origin/main) reference won't be
> updated. Since we don't need it for this particular case, it should be
> fine to use HEAD.
>
> R=apolito@google.com, ehmaldonaldo@chromium.org
>
> Bug: 1155492
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Change-Id: Ib2e6e50901a0a10ed647acea3aeb517b83567702
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2580190
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1155492
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Change-Id: Ibd9f67bea71ee4a644b1077a365dbcd2a2c469f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597065Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>

7e735122

Roll recipe dependencies (trivial). · 81098e59

recipe-roller authored Jan 05, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/21d171263a56afe8a10bb31c4f36ae556a1bc5f6
21d1712 (bryner@google.com)
Fix swapped error messages for missing/unexpected exceptions.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic6e9cea41e0ddd4877027581cf457371d8306e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2609869Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

81098e59

30 Dec, 2020 1 commit

[depot_tools] Migrate metadata to DIR_METADATA. · 364205c7

Edward Lesmes authored Dec 30, 2020

Change-Id: I7e07de8746a269a31744f44296921cc9c6566a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597738Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

364205c7

28 Dec, 2020 1 commit

Roll recipe dependencies (trivial). · 3b39cefc

recipe-roller authored Dec 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b6f83ba9c0a56a988dde16e04a6c0462e3210650
b6f83ba (qyearsley@chromium.org)
recipes docs: Rename old_user_guide to walkthrough and add links

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I629b77027bfefb63ae83bc4ac4bb3642cf9f5d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2605329Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3b39cefc

24 Dec, 2020 1 commit

Roll recipe dependencies (trivial). · 46ef281c

recipe-roller authored Dec 24, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/32f0255a6910af47c6cb35546032ae4d60fe9a92
32f0255 (qyearsley@chromium.org)
recipes docs: remove backticks from section titles in user guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I51435508fa50e5a39298af73279650215951a3e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2603024Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

46ef281c

16 Dec, 2020 2 commits

Add validation after downloading cache from GS · 67e12286

Josip Sokcevic authored Dec 16, 2020

R=ehmaldonado@chromium.org, gavinmak@google.com

Bug: 1159123
Change-Id: I21aedd9e0c557f75d8c11e055013cc4a540ea20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2595787Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

67e12286

Roll recipe dependencies (trivial). · d5b38571

recipe-roller authored Dec 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c4e6ba917aeaebb96b0b94a28881bfe7d6f2943d
  c4e6ba9 (iannucci@chromium.org)
      [engine] Detect incomplete deps and circular dependencies.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib35e608fb688a3a39ceb8bbcb7d58185a5133cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2594487Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d5b38571

15 Dec, 2020 5 commits

Check PACKFILE_OFFLOADING env variable · d8fe5213

Josip Sokcevic authored Dec 15, 2020

If set, set git config fetch.uriprotocols to https. This will be
initially set by codesearch builders. Once tested, this env variable can
be removed.

R=ehmaldonaldo@chromium.org

Bug: 1136986
Change-Id: I1c3da87bdbc74d18585ed00ffdc2cf21b84b16fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2591808Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d8fe5213

gerrit_util: move changes: enable keep_all_votes · f1c7d0dd

Mike Frysinger authored Dec 15, 2020

The default move behavior resets all non-blocking labels (including
Code-Review) which is not generally what we want.  Preserve them.

Change-Id: I9c49582b4147e27d3ed6a439a610c9c667d7aa7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2586110
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

f1c7d0dd

Roll recipe dependencies (trivial). · b1d06a4d

recipe-roller authored Dec 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/63a8f6a6dde18c243490d88a41628a8ad2cb79ce
  63a8f6a (yuanjunh@google.com)
      [led] Remove ensure_led function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I49578155d7f59270b7c49c8dfc683382f4f0823c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2593674Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b1d06a4d

[resultdb] move cipd pin of infra/tools/rdb · 97752ea0

Scott Lee authored Dec 15, 2020

This is to deploy the change of https://crrev.com/c/2549432 to depot_tools.

R=chanli@google.com,nodir@google.com
CC=maruel@google.com,yuanzhi@google.com

Bug: 1150844
Change-Id: I9aeb679009b0340536db0ad2063e3e8819271a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2550945Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

97752ea0

Roll recipe dependencies (trivial). · 867d99d3

recipe-roller authored Dec 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3cd5b2e3168ba22d28187ba95dc631dd63b4f6b8
  3cd5b2e (yuanjunh@google.com)
      [led] Support rbe-cas input

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb5f5e1499cca266135e20772670fe7d05b85b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2591807Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

867d99d3