1. 16 Aug, 2018 1 commit
  2. 26 Jul, 2018 1 commit
    • Vadim Shtayura's avatar
      [cipd] Try to bootstrap CIPD from scratch if selfupdate fails. · 7e50ee37
      Vadim Shtayura authored
      When updating the CIPD client to be identified by SHA256 hash, old clients (that
      have no idea about SHA256) fail during 'selfupdate'.
      
      We'll roll our SHA256 support in two stages:
        1. Deploy new client that understand SHA256 using its SHA1 name, so
           self-update from old clients works.
        2. Deploy same (or newer) client using its SHA256 name. This would work since
           the client doing the self-update already understands SHA256 at this point.
      
      But we can't guarantee that ALL depot_tools deployments will update through
      stages (1) and (2) sequentially. Some of them may skip (1) and end-up directly
      in (2), failing on 'selfupdate'.
      
      This CL makes sure they can recover from this state by rebootstraping the client
      from scratch (this works with SHA256 hashes).
      
      R=nodir@chromium.org, iannucci@chromium.org
      BUG=821194
      
      Change-Id: I27dece19e0305b5b2d6f8b0130631c1bf5f6499c
      Reviewed-on: https://chromium-review.googlesource.com/1149454
      Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      7e50ee37
  3. 30 Mar, 2018 1 commit
  4. 27 Jul, 2017 2 commits
    • Daniel Jacques's avatar
      Revert "[cipd] Bump version, log at warning." · 9f9d82ac
      Daniel Jacques authored
      This reverts commit 18aa2d93.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [cipd] Bump version, log at warning.
      > 
      > Bump the CIPD client version to
      > e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      > for the "-log-level" flag.
      > 
      > Update CIPD bootstrap scripts and tool installation scripts to log at
      > warning level, so that standard operation doesn't produce any logs.
      > 
      > BUG=chromium:748651
      > TEST=canary
      >   - Tested this CIPD version on canary waterfall successfully.
      >   - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
      >     no output and works.
      >   - Tested "vpython" / "led" on OSX system, no output and works.
      > 
      > Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      > Reviewed-on: https://chromium-review.googlesource.com/588889
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      > Commit-Queue: Daniel Jacques <dnj@chromium.org>
      
      TBR=iannucci@chromium.org,dnj@chromium.org
      
      Change-Id: Ia611c1aeb204c609ff3469076b8256c54e702230
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:748651
      Reviewed-on: https://chromium-review.googlesource.com/589527Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      9f9d82ac
    • Dan Jacques's avatar
      [cipd] Bump version, log at warning. · 18aa2d93
      Dan Jacques authored
      Bump the CIPD client version to
      e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      for the "-log-level" flag.
      
      Update CIPD bootstrap scripts and tool installation scripts to log at
      warning level, so that standard operation doesn't produce any logs.
      
      BUG=chromium:748651
      TEST=canary
        - Tested this CIPD version on canary waterfall successfully.
        - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
          no output and works.
        - Tested "vpython" / "led" on OSX system, no output and works.
      
      Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      Reviewed-on: https://chromium-review.googlesource.com/588889Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      18aa2d93
  5. 20 Jul, 2017 1 commit
    • Dan Jacques's avatar
      [win/bootstrap] Use "for" instead of "set". · 642dd84c
      Dan Jacques authored
      Using "set /p" to read a file fails when STDOUT is not connected.
      Replace it with a method of reading using "for".
      
      In the Python batch file, we eat up some of our sled buffer in order to
      accommodate currently-running Python scripts. They should now resume
      past the end of the file without issue. The sled was oversized, so this
      shouldn't affect upgrade paths.
      
      BUG=chromium:746602
      TEST=local
        - On Windows machine, tested upgrade from pre-rework and current
          bootstraps. This code works on both, and no running Python
          processes were disrupted on exit, suggesting the sled change is
          sound.
      R=iannucci@chromium.org, smut@chromium.org
      
      Change-Id: Ica51999d672dd4e448fdad797bffc06ec9e9febf
      Reviewed-on: https://chromium-review.googlesource.com/578725
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Reviewed-by: 's avatarsmut <smut@google.com>
      642dd84c
  6. 07 Jul, 2017 1 commit
    • Dan Jacques's avatar
      [cipd] Run client in .bat to preserve STDIN. · 7466d1a9
      Dan Jacques authored
      Currently, the PowerShell execution does not allow STDIN to be
      read by the CIPD client. Fix this by using PowerShell to acquire
      the client, but batch to actually invoke the client. This removes
      some indirection and allows STDIN to function as expected.
      
      BUG=None
      TEST=local
        - Ran w/ and w/out ".cipd_client.exe" locally, observed
          install and fallthrough.
        - Ran w/ an error code, observed exit code being preserved.
        - Ran "auth-login", was able to paste token.
      
      Change-Id: I4efafa7dc80aa093de0fbf5dfd188c299fa104db
      Reviewed-on: https://chromium-review.googlesource.com/563602
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      7466d1a9
  7. 28 Jun, 2017 1 commit
  8. 03 May, 2017 1 commit
  9. 12 Jan, 2017 1 commit
  10. 03 Jan, 2017 2 commits
  11. 13 Dec, 2016 1 commit