- 16 Aug, 2018 1 commit
-
-
Vadim Shtayura authored
This is Windows counterpart to https://chromium-review.googlesource.com/1171957 Also cleanup code style in cipd.ps1 script. It appears the common convention for global variables in PowerShell is $GlobalVar and for locals is $localVar. R=nodir@chromium.org, iannucci@chromium.org BUG=870166 Change-Id: Ib8ffbad85497db31f7f5d44fdca6ed843e56f220 Reviewed-on: https://chromium-review.googlesource.com/1175248 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
- 26 Jul, 2018 1 commit
-
-
Vadim Shtayura authored
When updating the CIPD client to be identified by SHA256 hash, old clients (that have no idea about SHA256) fail during 'selfupdate'. We'll roll our SHA256 support in two stages: 1. Deploy new client that understand SHA256 using its SHA1 name, so self-update from old clients works. 2. Deploy same (or newer) client using its SHA256 name. This would work since the client doing the self-update already understands SHA256 at this point. But we can't guarantee that ALL depot_tools deployments will update through stages (1) and (2) sequentially. Some of them may skip (1) and end-up directly in (2), failing on 'selfupdate'. This CL makes sure they can recover from this state by rebootstraping the client from scratch (this works with SHA256 hashes). R=nodir@chromium.org, iannucci@chromium.org BUG=821194 Change-Id: I27dece19e0305b5b2d6f8b0130631c1bf5f6499c Reviewed-on: https://chromium-review.googlesource.com/1149454 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 30 Mar, 2018 1 commit
-
-
Anatoly Matyukhin authored
cipd.bat is called from bootstrap/win/win_tools.bat. ERRORLEVEL in win_tools.bat script should not mean return code of cipd.bat. Bug: none Change-Id: Ia425d5054fa9c1e1f84b4a10decc265669911646 Reviewed-on: https://chromium-review.googlesource.com/987954Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 27 Jul, 2017 2 commits
-
-
Daniel Jacques authored
This reverts commit 18aa2d93. Reason for revert: <INSERT REASONING HERE> Original change's description: > [cipd] Bump version, log at warning. > > Bump the CIPD client version to > e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support > for the "-log-level" flag. > > Update CIPD bootstrap scripts and tool installation scripts to log at > warning level, so that standard operation doesn't produce any logs. > > BUG=chromium:748651 > TEST=canary > - Tested this CIPD version on canary waterfall successfully. > - Tested "gclient" bootstrap and "vpython" / "led" on Windows system, > no output and works. > - Tested "vpython" / "led" on OSX system, no output and works. > > Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d > Reviewed-on: https://chromium-review.googlesource.com/588889 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> TBR=iannucci@chromium.org,dnj@chromium.org Change-Id: Ia611c1aeb204c609ff3469076b8256c54e702230 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:748651 Reviewed-on: https://chromium-review.googlesource.com/589527Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Dan Jacques authored
Bump the CIPD client version to e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support for the "-log-level" flag. Update CIPD bootstrap scripts and tool installation scripts to log at warning level, so that standard operation doesn't produce any logs. BUG=chromium:748651 TEST=canary - Tested this CIPD version on canary waterfall successfully. - Tested "gclient" bootstrap and "vpython" / "led" on Windows system, no output and works. - Tested "vpython" / "led" on OSX system, no output and works. Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d Reviewed-on: https://chromium-review.googlesource.com/588889Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
- 20 Jul, 2017 1 commit
-
-
Dan Jacques authored
Using "set /p" to read a file fails when STDOUT is not connected. Replace it with a method of reading using "for". In the Python batch file, we eat up some of our sled buffer in order to accommodate currently-running Python scripts. They should now resume past the end of the file without issue. The sled was oversized, so this shouldn't affect upgrade paths. BUG=chromium:746602 TEST=local - On Windows machine, tested upgrade from pre-rework and current bootstraps. This code works on both, and no running Python processes were disrupted on exit, suggesting the sled change is sound. R=iannucci@chromium.org, smut@chromium.org Change-Id: Ica51999d672dd4e448fdad797bffc06ec9e9febf Reviewed-on: https://chromium-review.googlesource.com/578725 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
smut <smut@google.com>
-
- 07 Jul, 2017 1 commit
-
-
Dan Jacques authored
Currently, the PowerShell execution does not allow STDIN to be read by the CIPD client. Fix this by using PowerShell to acquire the client, but batch to actually invoke the client. This removes some indirection and allows STDIN to function as expected. BUG=None TEST=local - Ran w/ and w/out ".cipd_client.exe" locally, observed install and fallthrough. - Ran w/ an error code, observed exit code being preserved. - Ran "auth-login", was able to paste token. Change-Id: I4efafa7dc80aa093de0fbf5dfd188c299fa104db Reviewed-on: https://chromium-review.googlesource.com/563602 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 28 Jun, 2017 1 commit
-
-
Tobias Hilbrich authored
Powershell can try to read additional commands from stdin. The `< nul` makes sure it reads an EOF and properly returns. The motivation for this change was a hanging WebRTC build job on an automated build machine. R=iannucci@chromium.org, vadimsh@chromium.org Details: https://stackoverflow.com/questions/2041799/powershell-script-gets-stuck-doesnt-exit-when-called-from-batch-file Bug: Change-Id: I51df3927644ca3a7e212089e0c414e2e8eb0c02a Reviewed-on: https://chromium-review.googlesource.com/549317Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 03 May, 2017 1 commit
-
-
Robert Iannucci authored
-File something.ps1 args is SUPPOSED to pass args (i.e. the rest of the command line) through to the script. It seems, however, that it's actually parsing the rest of the command line and throws up its hands at a parameter like '-'. -Command, however, seems to work. R=vadimsh@chromium.org Bug: Change-Id: I617bf43f5b27bd2d0246106ab10b28e0a2fdd901 Reviewed-on: https://chromium-review.googlesource.com/495566Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 12 Jan, 2017 1 commit
-
-
Robert Iannucci authored
BUG=680274 Change-Id: I47fd8d7a5380aca49c873006c4f66732b21bee37 Reviewed-on: https://chromium-review.googlesource.com/427323Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 03 Jan, 2017 2 commits
-
-
Vadim Shtayura authored
This reverts commit 15f122ee. Reason for revert: lots of bots are running Powershell 2. the new step fails on them (non-fatally though, just generating errors in the log, e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/357219/steps/ensure%20git%20tooling%20on%20windows/logs/stdio) Original change's description: > Allow cipd.ps1 execution even if it was fetched from depot_tools.zip. > > Windows keeps track of files downloaded from the Internet and powershell by > default refuses to execute them (even with RemoteSigned policy). We need to > explicitly unblock the file first. > > Note: it requires Powershell >= 3.0. > > R=dpranke@chromium.org, iannucci@chromium.org > BUG=663843 > > Change-Id: Id681f4058f906fa4782a360be184d132d837ae78 > Reviewed-on: https://chromium-review.googlesource.com/424327 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,chromium-reviews@chromium.org BUG=663843 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ibdc58e60d3f35a760de45bc1f71c88c1c4d2f2df Reviewed-on: https://chromium-review.googlesource.com/424872 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
Vadim Shtayura authored
Windows keeps track of files downloaded from the Internet and powershell by default refuses to execute them (even with RemoteSigned policy). We need to explicitly unblock the file first. Note: it requires Powershell >= 3.0. R=dpranke@chromium.org, iannucci@chromium.org BUG=663843 Change-Id: Id681f4058f906fa4782a360be184d132d837ae78 Reviewed-on: https://chromium-review.googlesource.com/424327Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 13 Dec, 2016 1 commit
-
-
Robert Iannucci authored
This takes advantage of powershell on windows for a cleanish duplicate of the posix version. R=dnj@chromium.org, vadimsh@chromium.org BUG=663843 Change-Id: Ib23a044ff912e3239b58848a26143eb6575826d5 Reviewed-on: https://chromium-review.googlesource.com/414228 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-