- 10 Jan, 2020 1 commit
-
-
Jamie Madill authored
The --full option would skip setting the return value of the format command when used with --dry-run. This in turn would cause the presubmit check to always pass when --full was enabled in a repo by default. Was discovered in the ANGLE repository. Bug: angleproject:4241 Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
-
- 08 Jan, 2020 2 commits
-
-
Edward Lemur authored
Remove default value from optional arguments, since they are always passed. In particular, the default value for `out` was a text stream (sys.stdout), but the value passed to `out` is always a binary stream, which is confusing. Get rid of the `err` argument, since it is always sys.stderr, and only used for testing. Change-Id: Ia289e9a97b968a0c802fc2f419397c1e494f713c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986064Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I544aa85b040544508df8ed16310def982356fbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1949417 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 06 Jan, 2020 3 commits
-
-
Edward Lemur authored
Change-Id: I3a188b34ae5f62649108afe08fe0e389a408c2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1947933 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
Change-Id: I7a434d4420573c6e5fc014455b011984f4d681b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1952159Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Dan Beam authored
Bug: 1028829 Change-Id: Iafc40952e402884639543436281e93942c0257a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959813 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 19 Dec, 2019 1 commit
-
-
Edward Lesmes authored
Bug: 1024683 Change-Id: I1c30473699c1bd6b198188b53b632e3617fed335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1929653Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 10 Dec, 2019 1 commit
-
-
Aaron Gable authored
Now that the CQ has been enabled for both the Beta and Stable branches, git-drover should use the commit queue instead of directly submitting the CL. To that end, this CL replaces the usage of `git cl land` with `git cl set-commit`. Change-Id: I0d0c10115acc98eafe0c069825de5499b8ade3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1960697 Auto-Submit: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org>
-
- 06 Dec, 2019 1 commit
-
-
Jeffrey Yasskin authored
BUG=1023031 Change-Id: I4bf3e33932af40600646f070f057a7c8c0661f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1954624 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Jeffrey Yasskin <jyasskin@chromium.org>
-
- 04 Dec, 2019 2 commits
-
-
Kevin Marshall authored
Adds error handling logic for pre-existing tags (which can occur if "archive" is CTRL-C aborted midway through) and for undeletable branches (which can happen if they are currently checked out in a working dir). Change-Id: I27b6da9f5860c307f49cbeabb1b0ccf9cfb28eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1930023 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
-
Edward Lemur authored
Change-Id: Ife5826fc824f1304bc1a8ae09c0a659583f0ffb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1949408 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 Dec, 2019 2 commits
-
-
Anthony Polito authored
Bug: 896110 Change-Id: Ibaf36df48d9ea25e8ee633ca505fa7f7c2063df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1944639Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com>
-
Brian Sheedy authored
Switches the yapfignore implementation in git_cl to use fnmatch instead of glob. This ends up bringing the .yapfignore file parsing in line with yapf's actual implementation, namely allowing uses such as '*pb2.py' instead of having to list out each directory manually. Bug: 1027953 Change-Id: Ibb1cb4252c546de6f1b1af720c4c29ffd0f7be0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938026 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org>
-
- 26 Nov, 2019 1 commit
-
-
Edward Lemur authored
git hyper_blame might use a subprocess' stdin for its stdout, which is opened to accept byte input. The text must be encoded before printing to stdout to avoid unicode errors. Bug: 1028709 Change-Id: If2a270a7f3f69a818d367616f6732245de364db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1937500Reviewed-by:
Andy Perelson <ajp@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Nov, 2019 2 commits
-
-
Edward Lemur authored
Bug: 1026371 Change-Id: Iddef64ac2d3a9f97fdb0540a048dfb9dc5679b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925407 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009816 Change-Id: I2fac9f03b6dd275563375d8ac4d1e71b5188e468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925325Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 21 Nov, 2019 3 commits
-
-
Edward Lemur authored
Bug: 1024683 Change-Id: I01245d34ad1fa1142ce726c80bf5b61567bafe35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925038Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1002209 Change-Id: I64aecc5e06be13237b73ae568a1beae046ba4962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925324Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009809 Change-Id: Ia02460a24f4ac048bd7f0072e70856f9ee22a997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925314 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 19 Nov, 2019 1 commit
-
-
Edward Lemur authored
Running gclient_smoketests times out on windows when using git daemon, so use a local directory as remote instead. Bug: 1024683 Change-Id: I6ca506d74de463d914317f176eefbe74996298c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879723 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 15 Nov, 2019 3 commits
-
-
Edward Lemur authored
Useful when runnig the same test both on Python 2 and Python 3. Change-Id: I6074e4cbd64318985cf438a2d491182b7b9ccc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913259Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Anthony Polito authored
Also add a better warning if 'gclient sync -D' fails due to a modified file. I've tested this code via deleting a DEP and running gclient sync -D. Bug: 981149 Change-Id: I97035ac238d163ccb1684c3ee423c223ed0f6299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891830Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com>
-
Anthony Polito authored
Bug: 1025293 Change-Id: I41ca2fba3855ecad3036e94a3bdc39b399c1a276 Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1918609 Commit-Queue: Anthony Polito <apolito@google.com> Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 14 Nov, 2019 1 commit
-
-
Bruce Dawson authored
git cl owners orders owners by score with alphabetization being the tie breaker. This leads to some owners being suggested far more often than others. Adding a tiny amount of randomization to the scoring leads to an even distribution of equally qualified reviewers. Less qualified reviewers will still be sorted into distinct buckets - the randomness is too small to do anything except break ties. The tests were updated so that they can tolerate the randomness, but only for breaking ties. Bug: 1024083 Change-Id: If7d39d1b3bbd980b80b46ab3f62c65215309bdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913642 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 12 Nov, 2019 1 commit
-
-
Edward Lemur authored
Bug: 1002209 Change-Id: I90de660afd901e544e5557f3af3a56cef4d6adaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891667 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 11 Nov, 2019 1 commit
-
-
Edward Lemur authored
This is a reland of c87ed606 Fix on the reland: Encode change description before writing to temporary file. Original change's description: > git-cl: Fix some python3 compatibility errors. > > Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though > it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. > > [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info > > Bug: 1002209 > Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> Bug: 1002209 Change-Id: I2f0fc779ea3e361e6d32ee7ce1e53cbddb5cfdea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898702 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 05 Nov, 2019 1 commit
-
-
danakj authored
There are 3 layers modified, starting from the bottom up: 1. git_cache.py populate Now takes a --no-fetch-tags option. If specified, the cache will not fetch updated tags from the server by passing --no-tags to git fetch. This prevents the server from sending all the tag refs. In chromium this prevents significant time bottlenecks dealing with 10k+ tags. 2. bot_update.py bot_update has to deal with multiple git repos, it has the root repo that is checked out through git-cache, as well as repos synched via DEPS and gclient. The script now takes a --no_fetch_tags option. If specified, the git-cache populate call will include --no-fetch-tags. Otherwise, it won't. So this controls (for chromium) if fetches to the src.git server are passed --no-tags. 3. bot_update/api.py This is the entry point for recipes and also has to deal with multiple git repos. The behaviour at this point is not changed from the default. A |no_fetch_tags| parameter is added to ensure_checkout() that defaults to False. This CL is a refactor with no intended behavior change. The next step will be to change the chromium build repo to pass True for ensure_checkout(no_fetch_tags) on chromium trybots. This represents solution #2 in https://docs.google.com/document/d/1hDIunJjjfpmr50y3YnZ4o3aq1NZF4gJa1TS0p7AIL64/edit# Bug: 1019824 Change-Id: I935430603299daa9e301a95a5184c0ce486fd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894352Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org>
-
- 04 Nov, 2019 3 commits
-
-
Edward Lesmes authored
This reverts commit c87ed606. Reason for revert: Causes a regressions for CL descriptions on Windows Original change's description: > git-cl: Fix some python3 compatibility errors. > > Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though > it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. > > [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info > > Bug: 1002209 > Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> TBR=ehmaldonado@chromium.org,apolito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002209 Change-Id: I004f202b12c6b99cb6b24cb12a14fba7898569e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898547Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Sorting owners by score is non-deterministic, so sort by name too. Bug: 1009814 Change-Id: I93a9370a5852634b4bbb2768b9ebbb5b866348e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891665 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lesmes authored
Bug: 1007872, 1009819 Change-Id: Icb24badc0429012dc66912d7d35e03a456512787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894354Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 01 Nov, 2019 2 commits
-
-
Robert Iannucci authored
This makes no-rebase-patch-ref correctly populate `file_list` and work with `git diff --cached` (i.e. they will show only the files affected by the patchset). Previously gclient would `reset --soft` to master. Because we didn't rebase on top of master with `no-rebase-patch-ref`, it has roughly nothing to do with the patchref we just checked out. R=gbeaty@chromium.org, ltina@google.com, tandrii@chromium.org Context: Tricium recipes sometimes need to use no-rebase-patch-ref in order to get accurate linenumbers in the diff (i.e. so that the tricium comments will actually line up correctly with the patchset the user uploaded); Tricium recipes also need to accurately get the diff file list in this mode. Change-Id: I5f3c95cd4958cf407a83b96c238b8c55c452ac81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895041 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
danakj authored
The finder.owners_queue contains a set of owners but they appear in an arbitrary order on each invocation of the test. The current method of assertEqual() with a list fails randomly because of the ordering being different. Example: https://ci.chromium.org/p/infra/builders/try/Depot%20Tools%20Presubmit%20(win)/b8897976148721436512 This changes comparisons of owners_queue to use an assertEqualSets() which does a comparison that is order-independent. Change-Id: Ia827795af283dadeb56f76ae0cf14fa4ad7e9eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895699Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: danakj <danakj@chromium.org>
-
- 30 Oct, 2019 5 commits
-
-
Edward Lemur authored
Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info Bug: 1002209 Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
The problems on crbug.com/1017367 should have been fixed by crrev.com/c/1880013 Bug: 1009814 Change-Id: Ia98304ca983b4e7e293fedb9df1fee589de58ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1887714Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009814 Change-Id: Ifb073dc0b54a3291f1f874866da3c0fbbeab2db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888443Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009809 Change-Id: I47c9a468b2922248b823ebae5e71863a698c30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1889166Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Checking for LUCI_CONTEXT is not enough. To use local auth, the stored config must be valid and have a default account id. Bug: 1018069 Change-Id: I5bbe880cc217a06ae0e1ae8d7e00ef09502af6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888211Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 28 Oct, 2019 2 commits
-
-
Edward Lemur authored
This is a reland of 5bfa3ae8 Replace cStringIO with StringIO and add tests. Original change's description: > gerrit_util: Refactor ReadHttpResponse and add more tests. > > Bug: 1016601 > Change-Id: Ie6afc5b1ea29888b0bf40bdb39b2b492d2d0494c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880014 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1016601 Change-Id: I0c83a83202169b6a1acc60bdf6f4cd00eac6e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884461Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
This reverts commit 5bfa3ae8. Reason for revert: Fails when fetching status for cl 1708084 Original change's description: > gerrit_util: Refactor ReadHttpResponse and add more tests. > > Bug: 1016601 > Change-Id: Ie6afc5b1ea29888b0bf40bdb39b2b492d2d0494c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880014 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016601 Change-Id: I84bc378ed5f58e911e0900b1a5dbea70dc06ade1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1883677Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Oct, 2019 1 commit
-
-
Edward Lesmes authored
Change-Id: I649bee199e52ecbd66467cfaf850a7a57e2eedf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1874506Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-