Commits · f9f7b0ec897882ed335b8540674a32f33a7f6a64 · Linshizhi / Chromium_Depot_tools

26 Oct, 2021 5 commits

Roll recipe dependencies (trivial). · f9f7b0ec

recipe-roller authored Oct 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832284200708902689

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/25819f3448011ee31e92c6e282de3b9c82596ec3
  25819f3 (olivernewman@google.com)
      [cipd] Relax list type check

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If990e0194241cd2e79c48f070265187334a217ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3244472
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f9f7b0ec

Don't escape "commit" value for Gerrit branch/tag creation. · 5c9e8b47

Michael Moss authored Oct 26, 2021

This value is passed in the JSON body, not in the URL, so does not need
to be escaped, otherwise trying to make a branch/tag from another
branch/tag leads to errors like:

  gerrit_util.GerritError: (400) Bad Request: invalid revision "refs%2Fheads%2Fchromium%2F4665"

BUG=1052179
R=linxinan@chromium.org, sokcevic@google.com

Change-Id: I80d709370165fcb84a3375e18b67d4a921be9a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3243724
Auto-Submit: Michael Moss <mmoss@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

5c9e8b47

Roll recipe dependencies (trivial). · 56313826

recipe-roller authored Oct 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832293806170208977

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0145b3950d269ad50a1f9dff2930e47d2f4bc5fd
  0145b39 (xinyuoffline@google.com)
      [swarming] Deprecate old containment fields.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8f56269f9bb658e015e0af638d5f87068a410d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3244273
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

56313826

Disable whitespace lints handled by clang-format · dfff8abb

Collin Baker authored Oct 26, 2021

These lints are redundant and in rare cases may conflict with
clang-format output. We treat clang-format's output as the correct
formatting, so disable the lints.

The following whitespace lints are retained, all others are disabled:
whitespace/blank_line
whitespace/comments
whitespace/empty_conditional_body
whitespace/empty_if_body
whitespace/empty_loop_body
whitespace/ending_newline
whitespace/todo

Bug: chromium:1240500
Change-Id: I22e2d8ea4de021ea389e155d8c9e096c3ae6f8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3231485Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>

dfff8abb

Roll recipe dependencies (trivial). · 378395bf

recipe-roller authored Oct 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832347904217217633

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/151ff69edf4a797a4d123e481f7ae722bd21c987~..9041c56a7c586eefee7cccb761fe305ed1681d87
  151ff69 (jwata@google.com)
      [swarming] update luci-go swarming version
  9041c56 (mohrr@google.com)
      Handle string exit_code in swarming task result

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaeafd072892426abcd44b77e7e7c4667a6d6b72f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3244108
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

378395bf

25 Oct, 2021 7 commits

[lucicfg] Update to 1.29.1. · 7bd4c881

Vadim Shtayura authored Oct 25, 2021

This version will start generating `lucicfg {...}` section in
project.cfg, but only when some other config file changes (so
that lucicfg version change itself doesn't require all configs
to be regenerated).

This information will be used by LUCI tooling to figure out how
to regenerate LUCI project configs en masse.

Use `lucicfg generate -force main.star` to forcefully generate
`lucicfg {...}` section in the existing configs.

R=iannucci@chromium.org

Change-Id: I001ceb0dae1df797c2f76c3f6a28b8420d18f4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232093
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

7bd4c881

Roll recipe dependencies (trivial). · 2db5da23

recipe-roller authored Oct 25, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832361754753135697

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3cfb91b76dd0b575fc958c0266e21b57881ea42f
  3cfb91b (gbeaty@chromium.org)
      Provide a consistent assertions interface.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d835a52b9202e89ddb4ee13bbdae89eb63583fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3243723
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2db5da23

presubmits: Modify bug parsing to support FIX.* fields from gitwatch · 1e509c54

Sean McAllister authored Oct 25, 2021

Gitwatch supports closing bugs with a FIX(ES|ED|ING)? tag in the
commit message, but we only check BUG to ensure a bug is
specified, add the fix fields to BugsFromDescription so that presubmits
will still pass if only eg: FIXES=b:1234 is given.

Gitwatch reference:
  http://shortn/_LGPgBjgi3A

FIXED=b:203812728
TEST=presubmit_unittest.py doesn't fail more than it already does

Change-Id: I6afc38c786e281dcefb4d359bb9212ebe5980ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3237598
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

1e509c54

Update vpython spec for yapf · 2b8a99b1

Chris McDonald authored Oct 25, 2021

Update yapf to latest version.

Bug: None
Change-Id: I77a994105e8ef16dcaf61402523d4cf9a1e39722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3237590
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Auto-Submit: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

2b8a99b1

Add ability to generically call most Gerrit APIs. · 9c28af45

Michael Moss authored Oct 25, 2021

This will make it easier to call new or uncommon Gerrit APIs, without
needing to add dedicated methods for each one. This also makes it easier
to debug API calls by exposing the raw response data, which is often
processed or filtered in the existing wrapper methods.

BUG=1052179
R=linxinan@chromium.org

Change-Id: I0b594a9fdaabae4b0ebb379dc5473f4d6de67a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235714
Auto-Submit: Michael Moss <mmoss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

9c28af45

Roll recipe dependencies (trivial). · 8093a3e1

recipe-roller authored Oct 25, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832411456557294769

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/8daad3893894af737b0b5185fe3378c25998c1ce
  8daad38 (jwata@google.com)
      Revert "Handle string exit_code in swarming task result"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieac8ce9d58df34cc94635f22abbf4dbbf042480f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3240685
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8093a3e1

Roll recipe dependencies (trivial). · 372190eb

recipe-roller authored Oct 25, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832437251560564241

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/da91611b651e03289f6a8d1f342c819ca35bca09
  da91611 (jwata@google.com)
      Handle string exit_code in swarming task result

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd56f71ac733739305a5fc311be75f2beedd3e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3239888
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

372190eb

21 Oct, 2021 4 commits

Roll recipe dependencies (trivial). · 7a6ff982

recipe-roller authored Oct 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832726658328645537

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9d468ffabcdc634f0f0e89600ef97351e8d70165
  9d468ff (mohrr@google.com)
      [swarming] Accept str exit_code values

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6de99b93dc5054cf61c5cb21976294cccece7385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3237599
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7a6ff982

Roll recipe dependencies (trivial). · e023d448

recipe-roller authored Oct 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832776990556875249

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/76f0ade3876685c21539d9e430ea551c9ab0a90b
  76f0ade (vadimsh@chromium.org)
      [cipd] Remove set_service_account.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38be3a92853359a0653db2327e0344228f65bf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235942
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e023d448

Roll recipe dependencies (trivial). · a64ac730

recipe-roller authored Oct 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832780135860801809

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f63c949dff872fd1ad3fbd81b186d00514cf8cd6
  f63c949 (vadimsh@chromium.org)
      [cipd] Pass -verification-timeout to pkg-register.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I52f25fd412d8ea86417f929b10a282e27011dfc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235941
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a64ac730

Roll recipe dependencies (trivial). · ed33756c

recipe-roller authored Oct 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832798381948059697

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/50d670cae747fe2ab4c0eb117605d32be73f5452
  50d670c (jwata@google.com)
      Update gevent to version:1.4.0.chromium.1

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ife879e9fbd182c374353d36669a052ef799af2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235810
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ed33756c

20 Oct, 2021 4 commits

Don't check refspecs when running git cat-file · 5cffc195

Gavin Mak authored Oct 20, 2021

bot_update fetches +refs/branch-heads/* but also checks git cat-file -e
+refs/branch-heads/* which fails.

Bug: 1261879
Change-Id: Ic902eebcb7301aeae32e1a8775e3babf9fdedea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3234885Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

5cffc195

Add option to always "set bot-commit+1" in update_files() method · 57f85818

Xinan Lin authored Oct 20, 2021

If one uses update_files() method to file a chain of CLs and wants
to submit them together, they have to set submit=False to wait for the
last CL. As a result, users have to run `set Bot-Commit+1` for each CL
at their side, which is annoying.

This change makes the gerrit module to handle that, and callers only
need to submit the chain.

BUG=1261724
TEST=train

Change-Id: If7d420d8d3c40b1d462284395cdc87ac680d0918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235388
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Moss <mmoss@chromium.org>

57f85818

Add 'create tag' support to gerrit_client and gerrit recipe_module. · b6ce2445

Michael Moss authored Oct 20, 2021

BUG=1052179
R=dpranke@google.com, linxinan@chromium.org

Change-Id: I6e220b70e63d990e9257d9fe4d107de7dbd2eb81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232849
Auto-Submit: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

b6ce2445

New vpython to depot_tools. · bec0d0fd

Brian Ryner authored Oct 20, 2021

Notable changes:
- Fix for missing runtime DLLs on Windows
- Enables native Mac ARM64 wheel support
- Startup performance improvements
- Fixes to spec validation for python 3

Bug: 1237202, 1103275, 1219868
Change-Id: I9beeb9dc5e82630d3cc6369a501fa63b11d1321d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3158553
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

bec0d0fd

19 Oct, 2021 3 commits

Use sigkill instead of sigterm on a stale process · 1efe7c7e

Josip Sokcevic authored Oct 19, 2021

Only hanging process recorded so far is gsutil. Sending sigterm doesn't
result in successfully terminating the process. Instead, use sigkill.

R=gavinmak@google.com

Bug: 1255228
Change-Id: Iad354284422676df804c68cb6f18c7db723bf862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232250
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

1efe7c7e

Roll recipe dependencies (trivial). · f153151a

recipe-roller authored Oct 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8832922323383333569

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9789009ad06db056dddafc187c3b10ba3c127fce
  9789009 (olivernewman@google.com)
      [step] Accept timedelta objects for timeout arg

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0a8c47b8f3f7be362a1ab1a4b3eea6d5914493da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232088
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f153151a

Fix git-crrev-parse to work with both master & main branches · eee67fe5

Andrew Grieve authored Oct 19, 2021

Was finding only "master" commits.

Change-Id: I434a0cb8d2112d6173e638814ad10f401c2fb9b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3226313Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>

eee67fe5

15 Oct, 2021 4 commits

Disable print for git for-each-ref in git_cache · 650f853c

Josip Sokcevic authored Oct 15, 2021

The command is used for verification purposes when git index is fetched
from GS. The output is verbose for chromium/src and not useful at all.

R=gavinmak@google.com

Bug: 1255228
Change-Id: Ie95963a23ef397e9fd6ce7bcf959ec9964d21ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3227145
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

650f853c

[lucicfg] Update v1.28.1 -> v1.28.4 · 3e50cf45

Weiwei Lin authored Oct 15, 2021

Notable changes:
1. Do not produce semantically unimportant diffs by default.
2. Support configuring bug_url_template in milo.cfg

R=iannucci, vadimsh

Change-Id: I2c7df4d16129dc55148e6c4ccfbf73aa50242be7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224847
Auto-Submit: Weiwei Lin <weiweilin@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

3e50cf45

Reland "Limit number of concurrent gsutil cp calls" · 604f1602

Josip Sokcevic authored Oct 15, 2021

This is a reland of d3cfea0c

Original change's description:
> Limit number of concurrent gsutil cp calls
>
> gsutil utilizes as many cores as possible, and will create many threads
> too. In combination with gclient doing the same thing (utilize as many
> cores as possible), this results in creating way too many processes and
> some builders are running out of resources (e.g. can't create threads).
>
> This limits number of gsutil cp commands in git_cache to two.
>
> R=apolito@google.com, dpranke@google.com
>
> Bug: 1255228, 1249003
> Change-Id: Ifcccaacde6c9e1c60c1da0a0bc5a3e512e158dcc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3219900
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1255228, 1249003
Change-Id: I712bf5f625fd42992e7b5310ae005fad2633e1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3223155Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

604f1602

Update astroid to 2.5.3 in pylint-2.7 spec · 9a36d697

Chenlin Fan authored Oct 15, 2021

These package versions have conflicting dependencies.
 The conflict is caused by:
     The user requested astroid==2.4.2
     pylint 2.7.4 depends on astroid<2.7 and >=2.5.2

Change-Id: Id2724413f18d1cb62a6cc9cb936edf26f245f621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224599
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

9a36d697

14 Oct, 2021 9 commits

Add gerrit repo to gclient config · 80fc559f

Gavin Mak authored Oct 14, 2021

This change removes the need for the Gerrit plugin recipe to clone the
Gerrit repo itself.

Recipe-Nontrivial-Roll: infra
Bug: 1196790
Change-Id: I3d6bb71a2e95c50c4dc29345ad24e482177233d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224087
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

80fc559f

Roll recipe dependencies (trivial). · b859a0c0

recipe-roller authored Oct 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8833357062525804017

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/022d75261ffc4d0a88448bc0adf4201bd7549bc0
  022d752 (mohrr@google.com)
      [path] Don't require dirname arg be a Path

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaf405049330c20d7473f3434a661c9d016765a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224090
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b859a0c0

Roll recipe dependencies (trivial). · c82d2886

recipe-roller authored Oct 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8833358321295258049

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f1fc64b87ff019871cb3cbea5d85bfc34fa929ab
  f1fc64b (mohrr@google.com)
      [path] Don't require split arg be a Path

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5930264e2a01326d1909e1bc77b46ac79c506ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224086
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c82d2886

Force set HEAD to refs/heads/main for git_cache · 13225b70

Josip Sokcevic authored Oct 14, 2021

We only build git_cache if main branch exists, and newly boostrap caches
have main as default. This sets HEAD for already boostrapped caches, in
case they were boostrapped before the default branch change.

R=gavinmak@google.com

Bug: 1251783
Change-Id: I715329ee06cf523f9fe2e6a324381dc5703bac34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3218281
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

13225b70

Roll recipe dependencies (trivial). · 0bce062f

recipe-roller authored Oct 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8833360207979618065

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fdeb0a5461ca75d779dfc2f3143e685be9b892a4
  fdeb0a5 (mohrr@google.com)
      [path] Don't require splitext arg be a Path

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9940acf4ffa26df96cdbcf4c9ad76a2ec9976e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224254
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0bce062f

Remove verbose debug information from bot_update · 830c8fad

Josip Sokcevic authored Oct 14, 2021

It's generaly not useful and makes it harder to understand bot_update
logs. If we need to debug specific builders, we can set environment
variables in the recipe itself.

R=apolito@google.com

Bug: 1255228
Change-Id: I18fc6ee8cb15b30bc3a4422ddd04979189bacf64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3221250
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

830c8fad

Roll recipe dependencies (trivial). · 9a7b6cb4

recipe-roller authored Oct 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8833367129404064273

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0e5fc4424f5779df034e6d65512dc8ac5f1c8ef6
  0e5fc44 (mohrr@google.com)
      [path] Return Path objects in more cases

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib44451885b972a06e0df17f9b4d6018c26e6758a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3223334
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9a7b6cb4

Decode the output for the get_timestamp operation. · 4f272fd0

Garrett Beaty authored Oct 14, 2021

Change-Id: I31007dbbbe9c76f5e4aaf8aef0001979d05c1066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224017
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

4f272fd0

Roll recipe dependencies (trivial). · 592f005e

recipe-roller authored Oct 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8833378452837988609

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/78a39ee13ae5947ca94dd7a2a136874de50709a3
  78a39ee (mohrr@google.com)
      [path] Protect Path data members

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie3dfd8e6936384b2621c6df27533545e49bac362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3224003
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

592f005e

13 Oct, 2021 3 commits

Revert "Limit number of concurrent gsutil cp calls" · 9fe4fb87

Josip Sokcevic authored Oct 13, 2021

This reverts commit d3cfea0c.

Reason for revert: using self.GSUTIL_CP_SEMAPHORE instead of
global GSUTIL_CP_SEMAPHORE

Original change's description:
> Limit number of concurrent gsutil cp calls
>
> gsutil utilizes as many cores as possible, and will create many threads
> too. In combination with gclient doing the same thing (utilize as many
> cores as possible), this results in creating way too many processes and
> some builders are running out of resources (e.g. can't create threads).
>
> This limits number of gsutil cp commands in git_cache to two.
>
> R=apolito@google.com, dpranke@google.com
>
> Bug: 1255228, 1249003
> Change-Id: Ifcccaacde6c9e1c60c1da0a0bc5a3e512e158dcc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3219900
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1255228, 1249003
Change-Id: I0fde2477ea620c683b49efaa2a70262bd8e615e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3221900
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

9fe4fb87

Limit number of concurrent gsutil cp calls · d3cfea0c

Josip Sokcevic authored Oct 13, 2021

gsutil utilizes as many cores as possible, and will create many threads
too. In combination with gclient doing the same thing (utilize as many
cores as possible), this results in creating way too many processes and
some builders are running out of resources (e.g. can't create threads).

This limits number of gsutil cp commands in git_cache to two.

R=apolito@google.com, dpranke@google.com

Bug: 1255228, 1249003
Change-Id: Ifcccaacde6c9e1c60c1da0a0bc5a3e512e158dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3219900Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d3cfea0c

Mark patch failures as regular failures, not infra · 756e98f5

Josip Sokcevic authored Oct 13, 2021

Patch failures shouldn't be treated as infra_failures (as long as patch
was successfully downloaded).

Prior to https://crbug.com/1207685, bot_update patch failurs were set as
successful step to work around buildbucket plugin requirements.

One alternative approach is to add necessary information into patch
failure step, by editing its presentation.

R=gavinmak@google.com

Bug: 1207685, 1255228
Change-Id: I696356d40a80536c3efbca99091536b8b25deb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3219890Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

756e98f5

12 Oct, 2021 1 commit

Roll out new goma client binary VERSION=234 · 384bae2e

Fumitoshi Ukai authored Oct 12, 2021

Bug: b/202083435
Change-Id: Id962a71756a830e7c966b92a7289c0cdaefd728b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3216111Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

384bae2e