Commits · f9eef45dbe2e8cdd40da9c89577cb2fa66602ce3 · Linshizhi / Chromium_Depot_tools

07 May, 2020 2 commits

Roll recipe dependencies (trivial). · f9eef45d

recipe-roller authored May 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/6472553ec788b41aed0d048f6be8ce3290fcbe60 (yekuang@google.com)
Roll isolated client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I60183e88744fa0802ad3209e5fce764f464684be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186856Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f9eef45d

Roll recipe dependencies (trivial). · f7df9c45

recipe-roller authored May 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/9e3caa0d134d1111bb7119648147e3451fe525d8 (yuanjunh@google.com)
Add the hide_build_in_gerrit function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1e5119aeb68625d7934d10ecf584dbabbe96146f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186851Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f7df9c45

06 May, 2020 6 commits

Roll recipe dependencies (trivial). · bd73ca8f

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/305370ff915e7a4ee316fc3366f36833796310b5 (iannucci@chromium.org)
    [post_process_inputs] Improve Command matcher to allow multiple subsequences.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9ddd3223312c497eeffc7a5eaf3d6ec70e338802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2185786Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bd73ca8f

Roll recipe dependencies (trivial). · 3997b112

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/bebfc7949f03ac665c5df77fc1c0c69786630744 (garymm@google.com)
Expose raw swarming task result

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4ea7798a4eecf66a361765640000806330f660d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2185952Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3997b112

Roll recipe dependencies (trivial). · a93878c5

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/a980197a59085b739dae00a4abdb9af0fa6dc71f (yuanjunh@google.com)
Allow to add tags into its build during runtime

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I354099a99f931d40ee216689caacd48aff5d6b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2184823Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a93878c5

[led] Roll to ledv2 in depot_tools. · ebbc0692

Robert Iannucci authored May 06, 2020

This has stabilized on the bots and early field testers, so I think
this should be pretty safe for the remaining users.

R=ehmaldonado@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug: 1017818
Change-Id: Iae0a036646e1ef87087625dd4b1bd1fbbe9286c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2184744
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>

ebbc0692

Print clarifying message when no new owners needed · 9b4a0570

Bruce Dawson authored May 06, 2020

If a CL already has owners on the reviewer list that cover all of the
files - regardless of whether they have approved the change - git cl
owners just prints ** You selected these owners **, which can be
confusing. This change adds an explanation in the no-unowned-files case
and suggests using --ignore-current if more reviewers are wanted.

Bug: 1071967
Change-Id: If60455c5ec15006e09feed39633fa62e3ddf0a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183222Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

9b4a0570

Warn when --show-all is used with no files listed · 97ed44ad

Bruce Dawson authored May 06, 2020

At least one contributor thought that --show-all would show all owners
for the current CL, so they used it with no files specified and got
confused by the lack of output. I was fooled to. The message printed
by "git cl help owners" makes it clear but it seems worth detecting the
no-files case and printing a helpful message, especially since most
(all?) of the other git cl owners commands apply to the current CL.

Bug: 1071967
Change-Id: I77bd2e30a3b3a6eb67cd40b93f5544b20facacb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183219Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

97ed44ad

05 May, 2020 8 commits

Revert "git-cl: turn GERRIT_SQUASH_UPLOADS into a warning" · 4de54135

Edward Lesmes authored May 05, 2020

This reverts commit 31a538a3.

Reason for revert:
Breaks ANGLE's workflow.

Original change's description:
> git-cl: turn GERRIT_SQUASH_UPLOADS into a warning
> 
> Now that repos have dropped this from their codereview.settings file,
> change this logic to issue a warning if it's ever seen again.
> 
> Drop checking local gerrit.override-squash-uploads config too since
> it's no longer relevant.
> 
> Bug: 993518
> Change-Id: Id91bbc94b0890ca21c51a274f6acc41f2ae19b78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756159
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=vapier@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iaa8b3341b189f356082ae25a1557898e25820566
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182019Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4de54135

Roll recipe dependencies (trivial). · 1cbfe0f1

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a24b238dfe4332ff9e6a55285a1068625418d059 (nodir@chromium.org)
    [resultdb] Fix invocation inclusion

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I062180a9464f5a7243d542311edc72f5f1e9a0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182880Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1cbfe0f1

git-cl: turn GERRIT_SQUASH_UPLOADS into a warning · 31a538a3

Mike Frysinger authored May 05, 2020

Now that repos have dropped this from their codereview.settings file,
change this logic to issue a warning if it's ever seen again.

Drop checking local gerrit.override-squash-uploads config too since
it's no longer relevant.

Bug: 993518
Change-Id: Id91bbc94b0890ca21c51a274f6acc41f2ae19b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756159
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

31a538a3

Roll recipe dependencies (trivial). · fbe690fd

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/f41f5b523c58c70c19678c2c8c5868159089bdfc (tandrii@chromium.org)
buildbucket: support 'self' tag key in api.build.bucket.tags().

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24392147e134e1fd006ffd5b632d6b40f9724f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182929Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fbe690fd

Roll recipe dependencies (trivial). · db639b70

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/82f957d2db220f7a3f1e9de1184df6806470a32a (tandrii@chromium.org)
buildbucket: remove old master tag hack.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8a13dfe7ddec046e4b88cb1ae39f763a17d0125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181536Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

db639b70

Roll rdb · ae7f4c51

Nodir Turakulov authored May 05, 2020

Roll to the latest version.

R=ddoman@chromium.org

Change-Id: I4aced3043371d20e8e05cba78b17c785c313dfe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182264
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>

ae7f4c51

Roll recipe dependencies (trivial). · ced1cc9e

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/fcd5731c9b916b7c37865b154ca089b636fb697a (nodir@chromium.org)
    [resultdb] Simplify tests

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1267384dc7fac9fcef7ae4637519bc503b963312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181513Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ced1cc9e

Roll recipe dependencies (trivial). · f828cf36

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/5334991eef8485e2a14914bc48e7fb7f726a8bd5 (nodir@chromium.org)
    [resultdb] Add resultdb.wrap function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb64c21de58007abf723a04c13eb2e5b8bbcdfe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181728Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f828cf36

04 May, 2020 2 commits

Roll recipe dependencies (trivial). · 9e99f7c8

recipe-roller authored May 04, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/ebf006f6230e66be4733d74b31303e6102409944 (nodir@chromium.org)
    [resultdb] Use rdb-rpc to update inclusions

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic0856263d388c2c00ec6f0b410cd3801cc16802e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181643Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9e99f7c8

[resultdb] Add rdb and rdb.bat · 0f47d332

Nodir Turakulov authored May 04, 2020

This should have been a part of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176997

R=estaab@chromium.org

Change-Id: Ia362b562c9818ab759a793aeafd8fda221c86ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2177172Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

0f47d332

03 May, 2020 1 commit

Roll recipe dependencies (trivial). · 082a11aa

recipe-roller authored May 03, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/7f9177b9d1ab75e6a51176e7b227b7f85bcb9433 (nodir@chromium.org)
    [resultdb] Call `rdb-rpc`

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I138fdcd710ee431d9d9d8fe6f19c851cc6ce3cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2177283Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

082a11aa

02 May, 2020 2 commits

[resultdb] Add rdb to depot_tools · 70631f9a

Nodir Turakulov authored May 02, 2020

Deploy rdb in depot_tools. It can be used to stream local test results
and query results from the server.

Change-Id: Ic2fe65952d24b79edd98bedb678ee220b165fef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176997Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

70631f9a

Roll recipe dependencies (trivial). · 4eadc541

recipe-roller authored May 02, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/7fb8c48fa4af6fe1ceb0c885c8489967072b674a (iannucci@chromium.org)
    [autoroller] Update doc on tbr_emails field.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2a7fb3b4cc2c8ab3273f15797ab4e24b8919e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176682Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4eadc541

01 May, 2020 3 commits

Roll recipe dependencies (trivial). · ebb382b4

recipe-roller authored May 01, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/da3e215ac8da2fa8aec935f69415d88c669ab117 (chanli@chromium.org)
    [ResultDB] Add is_enabled function to resultdb recipe_module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I702106fb7d12bc05d56c45b45e78df4b8e997180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176310Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ebb382b4

update yapf to 0.27.0 · 177e70c0

Anthony Polito authored May 01, 2020

Bug: 1074167
Change-Id: I9f0c1c8a1fa76d6bf2899000fd0b3665f7bf0994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174818Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

177e70c0

Roll recipe dependencies (trivial). · 634b6b8a

recipe-roller authored May 01, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/db2f179387abaf196eb8221f376a2174663a4d28 (olivernewman@google.com)
    [buildbucket] Add fields arg to get()

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibeb5ed96b7db5b8be4e988519f6cc67b5db5ee48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176038Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

634b6b8a

30 Apr, 2020 4 commits

Roll recipe dependencies (trivial). · 37518fb2

recipe-roller authored Apr 30, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/53ed08a539ff9e24188417136109b8cac0f8b47e (chanli@chromium.org)
    [ResultDB] Add link to ResultDB concepts doc

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I10ef0ade65b087e10e51d4a46d54ec65a571de9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174863Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

37518fb2

Roll recipe dependencies (trivial). · fdd2e3d3

recipe-roller authored Apr 30, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/1b1574d044a7f44430825aa929cdc5b4fe17ab7b (erikchen@chromium.org)
Update user guide.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8aa0e687647a484b4bf08eb4928b10fb94de666a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173836Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fdd2e3d3

Allow a space after __except · 3e87ceaf

Bruce Dawson authored Apr 30, 2020

__except () is the canonical layout for code that uses __try/__except,
Microsoft's structured exception handling. The majority of __except
uses in our code use a space after the keyword. However cpplint.py
thinks that __except is a function name. Apparently we have been forcing
this through by ignoring the presubmits. This just adds __except to the
list of exceptions to the whitespace/parens rule.

Change-Id: I2384cd32f26e3aa6a4b0150451a9a61147483e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173644
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

3e87ceaf

Roll out new goma client binary VERSION=198 · 2072ffc0

Yoshisato Yanagisawa authored Apr 30, 2020

https://chromium.googlesource.com/infra/goma/client/+/b398f18fab944184f795cdcf0062994597578912

Bug: b/153832839
Change-Id: I24a4e8b5df26b2aa0d3bbec79987385993ca2c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174069
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>

2072ffc0

29 Apr, 2020 4 commits

Roll recipe dependencies (trivial). · a1509311

recipe-roller authored Apr 29, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/d937e9525fff04f0a92f9ef1e41ceb0e985ecf7b (chanli@chromium.org)
Mock resultdb info in buildbucket test_api

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib72d02dc1dfab2535b076fa672fa7f983f887fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171992Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a1509311

Roll recipe dependencies (trivial). · 1c6ae9e0

recipe-roller authored Apr 29, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/e9ccc9dd63ce31ec535c7b4b69d1f15618bf4d78 (olivernewman@google.com)
    [swarming] Fix typos and pylint errors

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54fe12f43ec6ff07dd26b36d1582766337e6687a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172340Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c6ae9e0

Roll recipe dependencies (trivial). · f2b5e1d5

recipe-roller authored Apr 29, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/1ec8faaaa559d4876f9c9c009a1be564286a8bba (olivernewman@google.com)
    [swarming] Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6801c67e3c1ff66128144eb064012d407143c09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172337Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f2b5e1d5

Remove curl verbose printing · d24ae265

Josip Sokcevic authored Apr 29, 2020

R=apolito@google.com, ehmaldonado@chromium.org

Change-Id: Ie453bb95208561a09a5f1f62cb9543e31cbe031f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171923
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d24ae265

28 Apr, 2020 5 commits

Terminate stale bot_update process · 350a913f

Josip Sokcevic authored Apr 28, 2020

Introduce a process observer that terminates child process if there is
not stdout activity. It can be overridden by an environment variable.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: I11de9d29e716587614cf336725c8d4a368a9d61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167220Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

350a913f

git-drover: Don't attempt to decode output of check_call. · b806e17e

Edward Lesmes authored Apr 28, 2020

When interactive is true, check_call is used instead of check_output,
and check_call doesn't return the command output.

Bug: 1074357
Change-Id: Ib9e761d41d754df58c9ee1f897dde173ce4d9eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2170805Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b806e17e

Reland "Print ps in intervals while the process is running" · d70aa16f

Josip Sokcevic authored Apr 28, 2020

This is a reland of 50c6d8d3

Original change's description:
> Print ps in intervals while the process is running
>
> R=apolito@google.com, ehmaldonado@chromium.org
>
> Bug: 1074355
> Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: I488b521e4a3b859c37f0bb1e21cad7d037f8f97e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169392Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d70aa16f

Revert "Print ps in intervals while the process is running" · 7d66c798

Josip Sokcevic authored Apr 28, 2020

This reverts commit 50c6d8d3.

Reason for revert: self argument missing

Original change's description:
> Print ps in intervals while the process is running
> 
> R=apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1074355
> Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I3c90576d0c6403f0d2f9119876a400c1380a8e14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1074355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169391Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

7d66c798

Roll recipe dependencies (trivial). · 3d10b764

recipe-roller authored Apr 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/3809ffa82d6bc08da66eae89bc87cdbe5c5b5905 (olivernewman@google.com)
    [swarming] Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9dd8ee949024310a048cddad2abec07f1c43288e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168955Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3d10b764

27 Apr, 2020 3 commits

Revert "git_cl: add --parallel for yapf" · 26b02c10

Takuto Ikuta authored Apr 27, 2020

This reverts commit 8533236d.

Reason for revert:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086/4#message-dcd4603d5914c681d0e1ad498e7bb9b59576a24d

Original change's description:
> git_cl: add --parallel for yapf
> 
> see
> https://github.com/google/yapf#usage
> 
> Bug: 1073708
> Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1073708
Change-Id: Ib8245dca57a11a386e78089630df61ff773b1789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168971Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

26b02c10

git-cl: Remove formatting support for dart. · 259d6bb1

Edward Lesmes authored Apr 27, 2020

The support for Dart in canned_checks.CheckPatchFormatted can be removed.
It was used in Chromium, when Chromium included a Dart SDK in its
checkout.
Dart was removed from Chromium years ago, and none of the current Dart
repositories use this in their presubmit.

Current repositories using Dart and depot_tools are
dart.googlesource.com/sdk and Flutter engine.
The SDK source tree has extensive custom code written for format checking
in the presubmit, and Flutter engine has none.
So adapting the exiting code to work with a new SDK location, or
searching the path for any Dart SDK (which would be too fragile) would
not be useful for these projects.

The support code was introduced in:
https://codereview.chromium.org/933383002

Bug: 1075502
Change-Id: I1ceed1ed6c1b4ff05071b0db1c52016f03c47c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168851Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

259d6bb1

Print ps in intervals while the process is running · 50c6d8d3

Josip Sokcevic authored Apr 27, 2020

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074355
Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

50c6d8d3