- 16 Dec, 2016 2 commits
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
Quinten Yearsley authored
Specifically, this CL was made by running codespell (https://github.com/lucasdemarchi/codespell), manually filtering for changes in non-third-party files that appear correct. Change-Id: Ia16c1b29483d777744450d7bea45a178cf877a25 Reviewed-on: https://chromium-review.googlesource.com/420871 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 08 May, 2013 1 commit
-
-
maruel@chromium.org authored
[1] *scm_test.py are deeply broken, svnadmin is missing for svn_bin\. And the git test are failing at shutdown. Also Fix SvnCheckout.testMove flakiness. TBR=ilevy@chromium.org,szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14729012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198900 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 May, 2013 1 commit
-
-
szager@chromium.org authored
Add default 30 second nag timer to gclient subprocesses. BUG=227537 Review URL: https://chromiumcodereview.appspot.com/14826003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198207 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 May, 2013 1 commit
-
-
szager@chromium.org authored
BUG=227537 R=maruel@chromium.org,cmp@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14798003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197790 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2013 1 commit
-
-
szager@chromium.org authored
R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/14643009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197419 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jan, 2012 1 commit
-
-
maruel@chromium.org authored
I'm not sure why it hasn't triggered before. TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9172002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117054 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2011 2 commits
-
-
maruel@chromium.org authored
Clean up stdin management. Remove stale comments. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8808002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113065 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
No significant code change. R=dpranke@chromium.org TEST= BUG= Review URL: http://codereview.chromium.org/8801019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113062 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Dec, 2011 2 commits
-
-
maruel@chromium.org authored
Enables threaded callback handler for subprocess.communicate(). R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8749015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112465 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8750003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112351 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Nov, 2011 3 commits
-
-
maruel@chromium.org authored
Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is broken _and_ slow. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8749005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This makes sure no regression relative to subprocess is introduced in subprocess2. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8722001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112217 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8694006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112102 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Use it in subprocess2 and trial_dir to remove manually bookeeping. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8688011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111941 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Nov, 2011 2 commits
-
-
maruel@chromium.org authored
No code change beside tests. This is mainly a regression test to make sure I don't regress that code path. TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8695003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111535 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@google.com authored
This will be necessary to override member functions eventually. It also better replicates what subprocess.Popen is. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8570005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111530 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Change return value from list to tuple for communicate(timeout != None). R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8539015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@110094 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2011 2 commits
-
-
maruel@chromium.org authored
Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
"Add callback support for stdout and stderr." "Add tests for both universal_newlines=True and False." "Implement accelerated tee support for POSIX." The reason is that the semantic of subprocess2.check_call(cmd, timeout=60, stderr=subprocess2.STDOUT) changed, stderr wasn't redirected to VOID anymore and for an unknown reason, it was hanging until the timeout happened. Will reapply r109239 with a new regression test to detect that bug. TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8505046 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109369 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2011 3 commits
-
-
maruel@chromium.org authored
This removes all the need of threading, which removes the contention on the GIL lock. Taking S2Test.test_check_output_tee_large as baseline, numbers are real/user/sys in seconds: Ubuntu workstation: ~25x 2.4/1.9/1.5 -> 0.10/0.70/0.02 OSX 10.6 laptop: ~40x 6.4/5.3/3.9 -> 0.15/0.80/0.07 Cygwin on win7: ~4x 2.8/2.2/1.3 -> 0.60/0.16/0.30 R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8462008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109283 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Fix stdout+stderr on Windows to binary mode in the child test process to make sure testing is done correctly. R=dpranke@chromium.org BUG= TEST=manually tested on OSX, Windows, cygwin and ubuntu Review URL: http://codereview.chromium.org/8472002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109282 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It's currently an inefficient thread implementation. Interestingly enough, callback support is significantly faster on cygwin than on native python. Writing an efficient implementation is punted for a later change, one per implementation. Stops using a temporary file since it's not necessary anymore. The goal is to reduce the number of places where a similar paradigm is used by having a canonical generic implementation. R=dpranke@chromium.org BUG= TEST=Tested manually on Windows, cygwin, linux, OSX 10.6 Review URL: http://codereview.chromium.org/8374026 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109239 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8366042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106866 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
stderr is not redirected by default. stdout is not allowed. Both were oversight. Do not override stdin=None in case the user would response to stderr output for example. Increase test coverage. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7860041 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Rename check_call to check_call_out. It's a quite specific need when stderr is needed or when the user doesn't want the default arguments of check_output. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6882127 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83023 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Renamed the previous subprocess2.call() to subprocess2.communicate(). R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6877005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81976 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Since no output is user visible anyway, causing a hang with no clue about what to type in. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6823091 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81302 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80775 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Also fix a few issues found along the way. Tests had regressed a lot. Add a lot of tweaks to make most test pass. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792060 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Improved tests and added regression test. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6793044 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80614 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6693078 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80454 0039d316-1c4b-4281-b951-d872f2087c98
-