- 27 Jan, 2020 2 commits
-
-
John Budorick authored
Bug: 1041701 Change-Id: I7c25d6b25eefc29f7a5e815d8664d5dfd2226cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2019018Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Peter Kasting authored
This fixes autoninja on my Windows machine at home. Bug: none Change-Id: I3c245715c409bb2b30fcc3733bb097fc2a88f464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2021755Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org>
-
- 25 Jan, 2020 1 commit
-
-
John Budorick authored
This logic's predecessor, run_presubmit, used an 8-minute timeout in all cases other than luci-py. Using that as a default (rather than 0s) seems reasonable. Recipe-Nontrivial-Roll: build Change-Id: I4b8668531db1a243709979b580c5170c22a0729f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2020987 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
- 24 Jan, 2020 2 commits
-
-
Anthony Polito authored
Bug: 1043877 Change-Id: I5363dc1ad7f6b7e0ce9ce9885c86e357c3c65339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2016162Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Anthony Polito <apolito@google.com>
-
Aaron Gable authored
Changes: * Add cq group name to lucicfg graph (https://crrev.com/c/1986093) Bug: 1035470 Change-Id: Iea5a57fdceadba45cb07bee8c13ba2cac1b62287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2020583 Auto-Submit: Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
- 23 Jan, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/6163c134a0320158e9c0778f9ee532a81d03e0ed (agable@chromium.org) Remove recipe engine autoroller config More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9c45918675b2ae5647eed5531c4e53ea1bb4334b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2018226Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Yannic Bonenberger authored
This CL changes the behavior of `git cl split` to split the change by the size of the resulting CLs. For now, this is based on the number of bytes changed, and not by the number of changed lines. Depending on the shape of change, this may still produce more CLs than expected (and possibly more than before). A future change will switch the split to be based on the number of affected lines, and also introduce a mode to base the split on the number of affected files. Bug: 998922 Change-Id: I49f868972a61b89b426ef9e2ceedc733eacb4350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778744 Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 22 Jan, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d5f7fbd67a6fb31d0491b5ba3e7f4a46c6668a37 Add autosubmit to recipes.cfg nontrival roll options (agable@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0e8c91742a5c5a34af015e993076eff7db272e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013588Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Gregory Nisbet authored
BUG=chromium:1040314 TEST=shellcheck Change-Id: I237df73daad84aeebfc934c9ddcc3eb632598827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995993Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>
-
- 21 Jan, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4ca9794b2e5b9fc85fd080bf5c19fa2d0f22cc3d [resultdb] Wait for tasks to complete (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic165d5ee3d4ad2563df02473ccf457547dfc266c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013219Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Andrii Shyshkalov authored
Undos a hack added while CQ for branches was experimental. R=ehmaldonado Bug: 1043225, 753213 Change-Id: Ie88b61e61f59e828f0ac4a36cf4e356700305482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2011308 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 17 Jan, 2020 3 commits
-
-
Edward Lemur authored
Only gerrit_url is needed to initialize gerrit_obj. This will be needed for git cl to call presubmit support as a script. Bug: 1042324 Change-Id: I79d78fb67465f989755bf8c8ceb48d665464fa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005050Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Will be used by presubmit_support to run checks over all files on a repo. Bug: 1042324 Change-Id: I872b4eb7f287f3a4b14d753cad73d0c5d7beb00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2002961Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I54f0fe3a2257166cba2a69659e5128e4ac9310bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001707Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 16 Jan, 2020 1 commit
-
-
Andrii Shyshkalov authored
Old revision: b7405423 Change logs: infra/infra: https://chromium.googlesource.com/infra/infra/+log/b7405423..9b687fbe luci-go https://chromium.googlesource.com/infra/luci/luci-go/+log/93937dc8..fa8b9bf0 Bug: 1041950 Change-Id: I79998caa77685240a61273d7f9a99b7fff2d0cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005468 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
LaMont Jones <lamontjones@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
- 15 Jan, 2020 1 commit
-
-
Raul Tambre authored
Example error during "git cl upload": Traceback (most recent call last): File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs) File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout p = subprocess.Popen(cmd, **kwargs) File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__ super(Popen, self).__init__(args, **kwargs) File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__ errread, errwrite) File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child startupinfo) TypeError: environment can only contain strings Bug: 984182 Change-Id: Id996d73a80845aaeaa061107ed123627091cb600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee>
-
- 14 Jan, 2020 4 commits
-
-
Edward Lemur authored
Bug: 1009820 Change-Id: I2aa619eb1cc70f7cacd27cbc2afc5c04c3a77d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001224Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I730f364f30b0d211c2db6da0d6bb4f5ff3c948da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1999280Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Vadim Shtayura authored
Changes: * luci.notifier_template(...) validates its name. * time.epoch(...) functions to parse timestamp strings into Unix times. * Internal digests.star module to calculate SHA256s. R=iannucci@chromium.org Change-Id: I58a3d9e11a2b278a0fd1e74169d6c57e048488f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2000986 Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Edward Lemur authored
Bug: 1002153 Change-Id: I769a5370d726f4ce478035f59bfd1df50fef452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992315Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 13 Jan, 2020 4 commits
-
-
Edward Lesmes authored
The link that points to all known strings is outdated. Change-Id: I40f7fd2b80fc0129eff5947ed6881d11934cb275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1998084 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Anthony Polito <apolito@google.com>
-
Edward Lemur authored
This is a reland of d3bfd23c Don't modify cwd for paths other than depot_tools. Original change's description: > presubmit_canned_checks: Run pylint on parent directory for depot_tools. > > On Windows, scripts on the current directory take precedence over PATH. > When pylint.bat calls vpython, it executes the vpython of the depot_tools > under test instead of the one in the bot. > As a workaround, run the tests from the parent directory instead. > > Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> No-Presubmit: True Change-Id: I4236ec17b2642ed7f53844af532ec1f5234b80d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995783 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Dean Berris authored
This reverts commit d3bfd23c. Reason for revert: Breaks non-depot_tools based presubmits that use canned checks that expect the presubmit to be run in the sub-repository (for example, in Catapult where it's hosted in third_party/catapult instead of being directly in chromium). Original change's description: > presubmit_canned_checks: Run pylint on parent directory for depot_tools. > > On Windows, scripts on the current directory take precedence over PATH. > When pylint.bat calls vpython, it executes the vpython of the depot_tools > under test instead of the one in the bot. > As a workaround, run the tests from the parent directory instead. > > Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If989527a53be90e1ae32cb3fa30f5e4777824480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994753Reviewed-by:
Dean Berris <dberris@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dean Berris <dberris@chromium.org>
-
Jamie Madill authored
Re-land fixes format always saying the folder was dirty. The --full option would skip setting the return value of the format command when used with --dry-run. This in turn would cause the presubmit check to always pass when --full was enabled in a repo by default. Was discovered in the ANGLE repository. Bug: angleproject:4241 Change-Id: I986646336d1857af2826863ef4becbf2b9ee3049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993910 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 11 Jan, 2020 1 commit
-
-
Edward Lesmes authored
Bug: 1036606 Change-Id: I035250757e346f89390b36d44701f0b6b8d8d024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995888 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
- 10 Jan, 2020 6 commits
-
-
Edward Lesmes authored
This is a reland of 797d74a2 Original change's description: > vpython: Specify interpreter to run. > > Specify the interpreter to run to avoid issues with several > python installations on Windows. > > Bug: 1036606 > > Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1036606 Change-Id: Ibf6727249b40c5a9f5f877353c8d42fe66404cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994215Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
On Windows, scripts on the current directory take precedence over PATH. When pylint.bat calls vpython, it executes the vpython of the depot_tools under test instead of the one in the bot. As a workaround, run the tests from the parent directory instead. Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I8fd0034f6a6d7623792620f92208b25961fa174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1990142Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Bug: 1041020 Change-Id: I725a599dcd5dc8b2a18d49bad33b2dbdcfe7ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994428 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Jamie Madill authored
This reverts commit fc132e61. Reason for revert: Causes all presubmit checks to return dirty format because of a non-zero diff output. Original change's description: > git-cl: Fix format --dry-run not working with --full. > > The --full option would skip setting the return value of the format > command when used with --dry-run. This in turn would cause the > presubmit check to always pass when --full was enabled in a repo by > default. > > Was discovered in the ANGLE repository. > > Bug: angleproject:4241 > Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> TBR=ehmaldonado@chromium.org,jmadill@chromium.org Change-Id: I0a4c51117ab20606f6dbb1f7a3ba40f87da1e939 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993907Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
The --full option would skip setting the return value of the format command when used with --dry-run. This in turn would cause the presubmit check to always pass when --full was enabled in a repo by default. Was discovered in the ANGLE repository. Bug: angleproject:4241 Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
-
- 09 Jan, 2020 4 commits
-
-
Edward Lesmes authored
This reverts commit 797d74a2. Reason for revert: Causes pylint to fail executing on "Depot Tools Presubmit (win)". Original change's description: > vpython: Specify interpreter to run. > > Specify the interpreter to run to avoid issues with several > python installations on Windows. > > Bug: 1036606 > > Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com Change-Id: I5902ceb9db85fdad81e781b51281fba8534a99d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994114Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ec5140c30b91e961996b5bd690b8c27f01dd9c56 path: add relpath to the list of filtered methods. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I637192b1f4ad38d75300267a88031a3ac593130c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993512Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Specify the interpreter to run to avoid issues with several python installations on Windows. Bug: 1036606 Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
As a workaround, add the Python3 bin dir to PATH so that the necessary DLLs are available. Bug: 1003139 Change-Id: I7b3e05922be3fcb7b0ec2b06783a86f25484310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992270Reviewed-by:
smut <smut@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 08 Jan, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2438e081638a16b8de53752c5a78c807195ed186 Return a disabled ModuleTestData from DisabledTestData. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ide989abae53f5c3f7079f0da4f7305fe41b158a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1991991Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lemur authored
Remove default value from optional arguments, since they are always passed. In particular, the default value for `out` was a text stream (sys.stdout), but the value passed to `out` is always a binary stream, which is confusing. Get rid of the `err` argument, since it is always sys.stderr, and only used for testing. Change-Id: Ia289e9a97b968a0c802fc2f419397c1e494f713c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986064Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I544aa85b040544508df8ed16310def982356fbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1949417 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a100ae5fb1cd5a66508d69f9bee7fb69b70b0135 [vpython] Bump asn1crypto to 1.0.1 to fix crash on macOS Catalina (athom@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9247a743105b8d1a5a0e4796cdec8fc4710863e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992106Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 07 Jan, 2020 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1cbfca1cec9aedcd01cfe190a1569d2f42c8912b Update the attrs dependency to the current version. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic4173c4b07358fdbbeb53ee9d204d44311cda951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987844Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-