This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0e4cf8f18b3062e8bd3eac0c09c2bfcb094f2e24 Improve verbose logging (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2213833003

Parse URL in the form of:
https://domain/<number>/#ps<patchset>

Review-Url: https://codereview.chromium.org/2215433004

It might be the case for some repositories that there is no merge base
between the current git HEAD and origin/master, which causes git
merge-base to exit with a non-zero code and cause calls to gclient
status/diff/pack to fail, as well as gclient sync if the repository in
question has been removed from DEPS.

This is true for the external/webrtc/trunk/talk repository, for example.
Its recent release branches (branch-heads/45 all the way to /53 at
least) have no ancestry shared with its master branch, so gclient
sync'ing from a Chromium M51 checkout to an M52 one (where it's no
longer in DEPS) fails because of the failed git merge-base calls.

We now ignore failures and just don't specify a merge base when calling
"git diff".

BUG=633962
R=iannucci@chromium.org,agable@chromium.org,maruel@chromium.org

Review-Url: https://codereview.chromium.org/2215673002

R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2204423002

BUG=
TBR=hinoka

Review-Url: https://codereview.chromium.org/2181413004

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002

the luci entry point is swarmbucket now

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2196843002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a32538a0b1f13b77635f059d8438c8b10c3ac57a Refactor rolling, allow project filtering. (martiniss@chromium.org)
  https://crrev.com/36d9d216129000237e6c2d30e4d15db161a5b30f cq.cfg: switch to luci builders (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191753002

R=estaab@chromium.org
BUG=629676

Review-Url: https://codereview.chromium.org/2184253003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/61ead7b5857f1ccb18d35403d66a43fe0d9422da expect_tests: cherry pick fca8c5f (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2190713003

If dry-run was active, git cl set-commit didn't actually trigger a
full CQ run, but was just a no-op.

TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2184643004

BUG=631575

Review-Url: https://codereview.chromium.org/2183393002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7f3ae3a4fae4e71019d3434f8c1aa786bccb0e06 cq.cfg: add swarming builders (nodir@chromium.org)

R=estaab@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2181413003

R=mmoss@chromium.org
BUG=609893

Review-Url: https://codereview.chromium.org/2188493004

This is a workaround for the fact that 'gclient revert' calls
'gclient update' with the same `options` object, despite not
actually having the same set of command line options.

R=iannucci@chromium.org, kevcheng@chromium.org
BUG=631220

Review-Url: https://codereview.chromium.org/2184493002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c5e569d259d3d408b4189baa912d0aebb6805302 raw_io: do not call os.path.exists on testdata (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184523002

BUG=628801

Review-Url: https://codereview.chromium.org/2157503003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dc09456c693ea913133396141d8d2ad384254ae9 Validate previous step result before attempting to access (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2175393002

Instead of long stacktrace, explain what went wrong.

R=sergiyb@chromium.org,andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175343002

If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Review-Url: https://codereview.chromium.org/2175103002

R=estaab@chromium.org, vadimsh@chromium.org
TBR=tandrii@chromium.org
BUG=629676

Review URL: https://codereview.chromium.org/2177713002 .

add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.

This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.

TBR=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176913002

Revert of bot_update: fix git dir check (patchset #1 id:1 of https://codereview.chromium.org/2174923002/ )

Reason for revert:
this is wrong. if directory is not empty, git clone fails

Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/cdac80c9fb4768bdc5bc42734e852e1f216224c9

TBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2173683003

Since different projects can have different configurations for what
the maximum value of the "Code-Review" label is in Gerrit, this teaches
presubmit_support to inspect the maximum configured value and see who
has granted it (the same behavior as the Submit button in Gerrit itself).

R=andybons@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=630738

Review-Url: https://codereview.chromium.org/2178673002

existance of a dir does not mean it is a git repo. Check .git dir
presence instead.

This is the reason why swarmbucket build.git builds fail.

TBR=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2174923002

BUG=

Review-Url: https://codereview.chromium.org/2165643002

R=iannucci@chromium.org
BUG=630312

Review-Url: https://codereview.chromium.org/2170623003

BUG=630601
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2173823002

R=iannucci@chromium.org
BUG=630312

Review-Url: https://codereview.chromium.org/2165633007

BUG=

Review-Url: https://codereview.chromium.org/2019223002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ece774fd870a6b883cdd0f541a686ec3ca581613 Vendor requests. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2170733002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8ca03782b1fabf6c838d5d58f2f527b52ecb95e5 Require recipe tryjob for CQ. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=628801

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2170683002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4278a31afc8618c43ee029b85eba8f5aa3491dc7 Revert of Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (patchset #1 id:1 of https://codereview.chromium.org/2142833002/ ) (martiniss@chromium.org)

R=iannucci@chromium.org,estaab@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2170553003

BUG=

Review-Url: https://codereview.chromium.org/2017373002

That recipe no longer exists, as of
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e0cc9e494929d2fd821a3542096f533001e7d67d

Referring to it in the tutorial is misleading. It seems that the docs scripts
haven't been run in awhile, so there are some unrelated changes as well.

Review-Url: https://codereview.chromium.org/2162223003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e1a78d4ffd60b5bb4ae5a15a32f587a1a1f20e95 Better handle utf-8 log lines (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=625221

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2159273005

BUG=

Review-Url: https://codereview.chromium.org/2166443002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/01dfcf4635e3182d31e5de98f18c079bdc90de1d fetch: fix fetching using gitiles (do not recreate existing dirs) (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2171433002

This covers 99% of successful runs on all builders based on event_mon
data.

BUG=629025

Review-Url: https://codereview.chromium.org/2162143004

Traceback (most recent call last):
  ...
  File "...\\git_map_branches.py", line 303, in main
    mapper.start()
  File "...\\git_map_branches.py", line 169, in start
    self.__append_branch(root)
  File "...\\git_map_branches.py", line 272, in __append_branch
    self.__append_branch(child, depth=depth + 1)
  File "...\\git_map_branches.py", line 267, in __append_branch
    line.append(run('log', '-n1', '--format=%s', branch))
  File "...\git_common.py", line 599, in run
    return run_with_stderr(*cmd, **kwargs)[0]
  File "...\git_common.py", line 668, in run_with_stderr
    raise subprocess2.CalledProcessError(retcode, cmd, os.getcwd(), ret, err)
subprocess2.CalledProcessError: Command '...\\git.bat -c color.ui=never log -n1 --format=%s readme' returned non-zero exit status 128 in ...
fatal: ambiguous argument 'readme': both revision and filename
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

BUG=

Review-Url: https://codereview.chromium.org/2153803002