- 07 Sep, 2019 1 commit
-
-
Edward Lemur authored
Header was printed using sys.stdout, but the rest of the output was printed using sys.stdout.buffer, causing the output to be written before the header. Bug: 984182 Change-Id: If6aaa05a579c3b0c73ce8ffe48f3a4e777fa16fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790254 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
- 06 Sep, 2019 4 commits
-
-
Edward Lemur authored
Dependencies are processed in order, so they don't have to be sorted. target_os for each dependency is a set [1], so it should be sorted to avoid flaky failures. [1] https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?l=368 Bug: 984182 Change-Id: I3e84f3cb85f9cb1920b7abf7a45766f3a518f4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1789278 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
Peter K. Lee authored
While fetching monorail issues, @chromium.org is appended to the --user option even if the original --user option is already a email address (e.g. user@google.com). Change-Id: I2442f4ea977b2681a72271f7c20fabb1ceaa351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790222Reviewed-by:
-
Bruce Dawson authored
The NINJA_SUMMARIZE_BUILD already triggers two types of build performance data - setting NINJA_STATUS to give more details during the build and running post_build_ninja_summary.py after the build. One of the most common causes of slow builds is when CreateProcess becomes slow, usually due to anti-virus overhead. Neither of these reports make this problem easily visible, but ninja -d stats does. In particular the StartEdge data is an excellent summary of CreateProcess timing. If the StartEdge average (avg) is more than about 6,000 us (6.0 ms) it might be worth investigating why. Therefore this change makes it so that autoninja.py adds -d stats to the command line when NINJA_SUMMARIZE_BUILD is set to 1. Change-Id: I1b6b990708c784a2cd71d153713b422f090775e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788399Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8fd8dc56140820b86ce0bda8c61a66021413c9d6 [led] Expose led run ID (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I86281bf1d492ed0b2e9f7115c9d98847f5254da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788726Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 05 Sep, 2019 5 commits
-
-
Robert Iannucci authored
423aa5860 [led] Set logdog prefix as led_run_id property 40c1ac5b5 [led] Set recipe input property for recipes source d9cf01212 [led] When consolidating isolateds, skip empty isolate hashes. 838b3cb14 [led] Pull isolate consolidation out of GetSwarmingTask. 7a6c68c7a [led] Make edit-isolated orthogonal to edit-recipe-bundle. 8e8edcb4f Have led launch set OutputResultJSONPath kitchen argument 93e7d934e [led] Add the ability for led edit-isolated to take a transform program. f5808de3a Fix many shadowed symbols 371e55885 Fix many misspellings 1cc5f65cf [led edit-isolated] Fix bug when inputsref is missing. R=tandrii@chromium.org Change-Id: I8bef431fe57f7331a8f5fc85e898916ee93fa9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788412 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/852662ebd96dfb039d8f8300991000da4ba69b93 [step] Improve docs on step.__call__ (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ide5b720ab158155c99aedbbd73032cb113ba8178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788413Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a45835b14a68ad2f3562ed0f74ae9c6e2ff293b0 Remove tricium module properties (garymm@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ide73bc8fd61920838bebaf5b4cae5ec9c441a9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788409Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/191385725c1237d40cde9054c2c92b7e3f0042e9 Add qyearsley to tricium recipe module OWNERS (qyearsley@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6526ee6b0676f8c5a3b38e4513630dea1f505a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788407Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/67d2df8c6bceac3c0efebcf023013945686ae4ff [tempfile] More helpful docs in terms of what to use instead. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7b23f155684bf8810fda57c750dcdd9dd84765c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788403Reviewed-by:
-
- 04 Sep, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6fca1db109d6dcc1083a751c7fafa8095db0a009 Enable specifying test data in RecipeTestApi.test. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib78bc7f9fb91ff5c688925c082a6256678c4655d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785619Reviewed-by:
-
Andrii Shyshkalov authored
Use "git cl try -B <bucket>" instead. R=smut Bug: 570733 Change-Id: Id5fedadede9fd8305e4567028ce4a4326d775cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779545 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
smut <smut@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/54739722d50ec6e17c06238b5cafc7b8df828dfd [tricium] Type check comments early (garymm@google.com) https://crrev.com/a3870eec10769a883eebbc3a0a08592742e56f5b cq: update its proto's revision. (tandrii@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I673ed9615d225e3cebb3463142630c8e770bb1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1783870Reviewed-by:
-
- 03 Sep, 2019 4 commits
-
-
Edward Lemur authored
Change-Id: I93809da721d410090e7ceb140cf5d9c4bded3744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765838 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: I0b7f1e3e056548a27a416c9b4078e54c9e5d60d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769400 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
Jamie Madill authored
Useful tool for perf for the ANGLE team. Bug: None Change-Id: I78c3b7d8a4e2a6d19f6b2ea2c8e6d67b2a4dc0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778979Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Quinten Yearsley authored
In this CL: - Clarify some comments. - Remove some unused imports. - Make some style more consistent (e.g. quotes, whitespace) Tools used: pyflakes, flake8 (most warnings ignored) Change-Id: Ibfb6733c8d844b3c75a7f50b4f3c1d43afabb0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773856Reviewed-by:
-
- 31 Aug, 2019 1 commit
-
-
Andrii Shyshkalov authored
I'm now using tandrii@google.com by default. Also remove hinoka@. R=vadimsh, maruel Change-Id: I9c74c36c44ac4b5c025354a463c41840d35cf9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779550 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
- 30 Aug, 2019 3 commits
-
-
Vadim Shtayura authored
This version can load external proto descriptors. No other significant changes. TBR=tandrii@chromium.org, iannucci@chromium.org BUG=986972 Change-Id: I26317512ffcee0a50e051032d30ec79bbd805644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778707 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Builders-map is finally no longer necessary. R=smut TBR=ehmaldonado Bug: 570733 Change-Id: I05c3087c877fdccfd878bb9befff4fb77b92b26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779543 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
Marc-Antoine Ruel authored
R=tandrii@chromium.org Bug: 770408 Change-Id: Iac1d63afb2f3a59a8299c8316bf7de576b6f6589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773971Reviewed-by:
-
- 28 Aug, 2019 2 commits
-
-
Elly Fong-Jones authored
This method allows retrieving the owners listed in a file, as well as those transitively listed in files included by it. This change also adds a new test to cover this method, which is just a wrapper for the existing _read_just_the_owners() internal method. Bug: None Change-Id: Iee956f115d3846acf0ee0806451807b0aa96d2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773904Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9ca245a1dc39e1fe957a4c8fb1774b731bef5415 [json] Handle nonexistent JSON placeholder file (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iaa31495e9daa4cb26ab1efcaa02d5691251aa227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1774745Reviewed-by:
-
- 27 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/19c4fbe5a863665b045e2d510b7a368c18c46edb [swarming] Allow customizing test task ids. (mohrr@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idd5cf39f26fd19a383253b157d0e59e7dff0781a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773696Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c76e28ff61f722e8f67f06531e0fc31daa768837 [swarming] Roll client (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idef7bea5758c9ef3c4b592acaedefb9527610178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1772662Reviewed-by:
-
- 26 Aug, 2019 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8f799e486a93f7f8bcc13531403dc4435b5e7259 Roll swarming client (atyfto@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6c15d7a7a361271912a80ed36e17a68a39a61f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769195Reviewed-by:
-
- 25 Aug, 2019 2 commits
-
-
Mike Frysinger authored
Change-Id: Iac5da55340acbec5d55d5fe4c416a7f1a8e962e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1770421Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
Mike Frysinger authored
Pylint-1.7+ include a score report by default at the end of every module lint. We disable reports in general, so silence this too. Bug: 866772 Change-Id: Ie3df44c80b90daa59e46c8fd37a949176c9b09a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1770420Reviewed-by:
-
- 23 Aug, 2019 5 commits
-
-
Vadim Shtayura authored
Has different protobuf guts. The only observable side effect is different formatting of generated files. But 'lucicfg validate' now compares files semantically, so different formatting shouldn't matter. There's a bunch of other internal changes, but clients that rely on them are already aware and updated. R=iannucci@chromium.org BUG=986972 Change-Id: Ifd13c453736e438f28c2cf938003dce00f2cb199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769607Reviewed-by:
-
John Budorick authored
The parsing logic for OWNERS files included via "file:" lines currently rejects inline comments (e.g. "foo@example.com # for foo.cc"), while the normal OWNERS parsing logic correctly ignores such inline comments. This CL makes the inline case ignore inline comments too. Bug: 995474 Change-Id: I6f30554daf0a5f63b81719dced44f59187707eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769603Reviewed-by:
-
Edward Lemur authored
Don't overwrite passed kwargs. Make a copy instead. Otherwise, subsequent calls with the same kwargs will have stdin set to subprocess.PIPE. Bug: 984182 Change-Id: I358ffa1951e8b42486e0ac3a0d3d587a93c6dc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769405 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Tamer Tas authored
devtools-frontend is missing from {gclient_config.repo_path_map}, causing the breakage: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8904354993541218352 This CL adds devtools-frontend to {gclient_config.repo_path_map} R=tandrii@chromium.org TBR=machenbach@chromium.org CC=yangguo@chromium.org Change-Id: I14cd8e9a9f05bdf16fa1b3c83f95de314418877e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1767977Reviewed-by:Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org>
-
Edward Lemur authored
Add run_on_python2 and run_on_python3 to allow to be tests on either only python2, only python3 or both. Bug: 984182 Change-Id: I87d3b67412129cf3a8e627cd6bc97daa81147657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1758849 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 22 Aug, 2019 5 commits
-
-
Sam Clegg authored
On the wasm team we build several CMake-based projects with ninja (LLVM, binaryen, etc), and its useful for us (me at least) to be able to use autoninja with these project too. Change-Id: I7e213448dbbe95ffe3d249c9c6a3d4baa41f50d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1682742Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org>
-
Edward Lemur authored
Bug: 996359 Change-Id: I7c87fd824103c91c1dd5b9b8975354732e5eb0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765839 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Change-Id: I422c836258738ff11eb975361f56aa4ea7b4e2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764448Reviewed-by:
-
Edward Lemur authored
Changes like crrev.com/c/1752507, where a file that was previously in .gitignore becomes part of the repo, makes update_depot_tools fail to rebase. Use git checkout origin/master instead. Bug: 996359 Change-Id: Ib1a43b8842cebce96ab1fabaedc8e5653b9a708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764708 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Tamer Tas authored
devtools-frontend is missing from gclient configs, causing the breakage: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8904421330390983280 This CL creates the devtools-frontend configuration R=tandrii@chromium.org TBR=machenbach@chromium.org CC=yangguo@chromium.org Bug: chromium:995657 Change-Id: I8e5ffce16f2b8f69931a71cd67a709427d1f42ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765591Reviewed-by:
-
- 21 Aug, 2019 2 commits
-
-
Edward Lemur authored
A new-line token is being added on Python 3, so add it explicitly so that it also appears on Python 2. Bug: 984182 Change-Id: I3bfb6ca83d94b6a3452b938f35f5a3174fe85903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764465Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e15c164ce655619b0f7ca5cabb1da02134b43a92 [Path] Make all Path classes hashable. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic12fe56989f60a5b2d409ab33dff54e37b690a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764462Reviewed-by:
-
