Commits · ef0705a98d48edb5ee8351e133e73cbf4c651a12 · Linshizhi / Chromium_Depot_tools

26 Apr, 2017 3 commits

Roll recipe dependencies (trivial). · ef0705a9

recipe-roller authored Apr 26, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f162918ed7c917f187c8098b88e4fd02b82e06aa [recipes.py] refactor common argument parsing, directly validate --package (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Id86cbd9f83a5b76101a3f07b3138840ce61d8519
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/488202
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

ef0705a9

Roll recipe dependencies (trivial). · 7cc2b0a3

recipe-roller authored Apr 26, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/77da3ca06f0c46b613b51eea0cf2186c7e8b58c9 [recipes.py] remove get_package_config. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Idca49a4c80ee792ef56252cc9910d4ac85ed26a0
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/487522
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

7cc2b0a3

Roll recipe dependencies (trivial). · 9c215a38

recipe-roller authored Apr 26, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c0617faf2648170732bec7f4f5139ac706fe1ebd [recipes.py] make `--properties-file -` work correctly again. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Id4faf0b6e062d83de2d84bd647714087a3282d47
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/487581
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

9c215a38

25 Apr, 2017 8 commits

gerrit_util: Fix name of conn object data member · 20d2cbb8

Aaron Gable authored Apr 25, 2017

R=tandrii@chromium.org

Bug: 715072
Change-Id: Ia34d406e0c0065b9e12cb6595534173d75241e9a
Reviewed-on: https://chromium-review.googlesource.com/487046Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

20d2cbb8

Fix addition of CQ_INCLUDE_TRYBOTS on Gerrit. · df6e7348

Kenneth Russell authored Apr 25, 2017

BUG=710547

Change-Id: I6558ba08683b8e010ac5051dabfd82d9a5b9c551
Reviewed-on: https://chromium-review.googlesource.com/486083Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

df6e7348

[cipd.ps1] catch CommandNotFoundException if git is not available yet · 78628da9

Robert Iannucci authored Apr 25, 2017

R=brucedawson@chromium.org

Bug: 714920
Change-Id: I6a0ea81e1d87fa2604e9f614a89ff48619cbffd0
Reviewed-on: https://chromium-review.googlesource.com/486085
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

78628da9

Stop passing deprecated manifest flag to bot_update · 644a1d87

Michael Achenbach authored Apr 25, 2017

The flag has been deprecated in:
https://chromium-review.googlesource.com/c/486640

This is a separate CL for the expectation changes.

Bug: 398105
Change-Id: I129186323e5ecffe441febe7fa3c6c72bfc9c4cd
Reviewed-on: https://chromium-review.googlesource.com/486782Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

644a1d87

Reland "Remove obsolete bot_update flag" · 86989d7b

Michael Achenbach authored Apr 25, 2017

This reverts commit c91686c0.

Reason for revert: Reland a light version of the original CL that keeps a dummy flag around.

Original change's description:
> Revert "Remove obsolete bot_update flag"
> 
> This reverts commit 72048266.
> 
> Reason for revert: Skia depends on it. Need to clean that up first. Currently blocks roll:
> https://skia-review.googlesource.com/c/14145/
> 
> Original change's description:
> > Remove obsolete bot_update flag
> > 
> > Using the manifest is the default since a long time. The flag was only introduced to smoothly switch it on. Now the flag is not needed anymore.
> > 
> > Bug: 398105
> > Change-Id: I4eb1c98e26e025a69f8b0a7c48877d78c031702e
> > Reviewed-on: https://chromium-review.googlesource.com/485659
> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> > Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> > 
> 
> TBR=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Change-Id: Iffc4d8076abd3c92feebfd7f3ef88be7ce34b692
> Reviewed-on: https://chromium-review.googlesource.com/486639
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> 

R=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org
Bug: 398105

Change-Id: I817d446f8a8eff84c5d7143ac2b9c527a40991f1
Reviewed-on: https://chromium-review.googlesource.com/486640
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

86989d7b

Roll recipe dependencies (nontrivial). · e4a7a042

recipe-roller authored Apr 25, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/944125e6d1e8c831d09517bde658a38d8f81db37 Sort step presentation properties (machenbach@chromium.org)


R=martiniss@chromium.org, phajdan.jr@chromium.org

Change-Id: Iec279f8331bd0e7673ce785c3095714bc5cfe401
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/486600
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

e4a7a042

Revert "Remove obsolete bot_update flag" · c91686c0

Michael Achenbach authored Apr 25, 2017

This reverts commit 72048266.

Reason for revert: Skia depends on it. Need to clean that up first. Currently blocks roll:
https://skia-review.googlesource.com/c/14145/

Original change's description:
> Remove obsolete bot_update flag
> 
> Using the manifest is the default since a long time. The flag was only introduced to smoothly switch it on. Now the flag is not needed anymore.
> 
> Bug: 398105
> Change-Id: I4eb1c98e26e025a69f8b0a7c48877d78c031702e
> Reviewed-on: https://chromium-review.googlesource.com/485659
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> 

TBR=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Iffc4d8076abd3c92feebfd7f3ef88be7ce34b692
Reviewed-on: https://chromium-review.googlesource.com/486639Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

c91686c0

Roll recipe dependencies (trivial). · e35ed050

recipe-roller authored Apr 25, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9715f08144e7d8a8d7d543fa2cb5d266ae289849 Whitelist "hashlib" for import. (dnj@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Ie0f5e9a690d226a446035ec6b35938751b1a4642
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/486399
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

e35ed050

24 Apr, 2017 2 commits

Remove obsolete bot_update flag · 72048266

Michael Achenbach authored Apr 24, 2017

Using the manifest is the default since a long time. The flag was only introduced to smoothly switch it on. Now the flag is not needed anymore.

Bug: 398105
Change-Id: I4eb1c98e26e025a69f8b0a7c48877d78c031702e
Reviewed-on: https://chromium-review.googlesource.com/485659Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

72048266

Remove directly accessing got_revision_mapping · c180dc40

Michael Achenbach authored Apr 21, 2017

Bug: 713356
Change-Id: I2c5d92152b293ca553efc875f49c28fb0fc888ed
Reviewed-on: https://chromium-review.googlesource.com/484460Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

c180dc40

22 Apr, 2017 1 commit

Roll recipe dependencies (trivial). · 1e71b8bd

recipe-roller authored Apr 22, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/554e8878ac6395262dc3c90bbb8a100ee844f766 Ensure raw_io creates all parent directories of the backing_dir. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Ied57f76a3ab376f17d5ee63138ae6b342b3b1ee9
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/485040
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

1e71b8bd

21 Apr, 2017 10 commits

Roll recipe dependencies (trivial). · 5e170f6b

recipe-roller authored Apr 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6eba2e3ccb23e7a3b622d82f23aad776c09a270c [autoroller] All commits in updates(), only roll interesting ones. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Ib3d9b5ffefa8af5422bf140f444cb9e9a4e20aff
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/484859
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

5e170f6b

cipd recipe module: allow rel path to be the root · cc6bb192

Nodir Turakulov authored Apr 21, 2017

Fix the bug in cipd recipe module preventing to add the package root as a dir.

R=vadimsh@chromium.org

Bug:

Change-Id: Ia9b7adbf7f9b0e0e6dd4158934197e4f69ba993e
Reviewed-on: https://chromium-review.googlesource.com/483850Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

cc6bb192

Roll recipe dependencies (trivial). · 10662b8a

recipe-roller authored Apr 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/64bc332f68c2b0d3daa5bfeb3f2dd5078e189c8c Fix Path.__ne__ (nodir@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Ice2a0cd142b89a7acaf696a8aa32512e847b2e9d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/484081
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

10662b8a

Support overriding gclient config in a bot_update method · 521c9ed1

Michael Achenbach authored Apr 21, 2017

Bug: 713356
TBR=tandrii@chromium.org

Change-Id: I15d73492712b66c7670793f3c47e4cbd89d4e1cd
Reviewed-on: https://chromium-review.googlesource.com/484440Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

521c9ed1

Support merging got_revision mappings during transition phase. · 93f69da3

Michael Achenbach authored Apr 21, 2017

A few rare recipes use two or more solutions side-by-side.

This allows switching one solution in isolation to use the new mapping.

Bug: 713356
Change-Id: Id51f2f777681401843004577a4de65a6c5d1e4a6
Reviewed-on: https://chromium-review.googlesource.com/484341
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

93f69da3

Fix bogus master-manager got_revision_mapping · 12e7751d

Michael Achenbach authored Apr 21, 2017

Bug: 713356
TBR=tandrii@chromium.org

Change-Id: I4af86f67216e1fc07da099e42608ad4a93c6b354
Reviewed-on: https://chromium-review.googlesource.com/484401Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

12e7751d

Reverse got_revision_mapping in bot_update · 81b4d420

Michael Achenbach authored Apr 21, 2017

This is the first step in reversing got_revision_mapping.

This CL:
- Adds a new configuration got_revision_reverse_mapping.
- Ensures only the old or the new configuration is used.
- Transforms the old to the new configuration within bot_update.

In follow up CLs we will migrate all clients to the new mapping, then delete the old and rename the new again.

Bug: 713356
Change-Id: Icdbd6a3748c6e5399b9c4867a3d8292973325160
Reviewed-on: https://chromium-review.googlesource.com/483479
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

81b4d420

Roll recipe dependencies (trivial). · 839d8591

recipe-roller authored Apr 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/83831a2405589f70218ae8592d5fcd1bf40c8097 [fetch] Make GitBackend._execute log at info level (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: I3a453dc21f0f1a8d46f82301a524f21b3ab65ca5
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/484080
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

839d8591

Roll recipe dependencies (trivial). · d73ef8e9

recipe-roller authored Apr 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/51e6ae23f698f81136bc508f633588354b5969ca Revert of [autoroller] All commits in updates(), only roll interesting ones. (patchset #2 id:20001 of https://codereview.chromium.org/2829203002/ ) (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: I0a9170310569057b5bd261089ecd8ee301c19965
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/484079
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

d73ef8e9

Roll recipe dependencies (trivial). · 43d990bf

recipe-roller authored Apr 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/763b5442fe13969bc3ffc0fa37bcc527fa9814bf [autoroller] All commits in updates(), only roll interesting ones. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: I8fd197aac90e603758dfaf0e8c7d6aa8f7498a3e
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/484000
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

43d990bf

20 Apr, 2017 7 commits

Roll recipe dependencies (trivial). · 3e6c0e0f

recipe-roller authored Apr 20, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/84d216aab872ff9d2ea18a39620fec428ea38e57 Revert of [autoroller] All commits in updates(), only roll interesting ones. (patchset #3 id:40001 of https://codereview.chromium.org/2833723003/ ) (iannucci@google.com)


TBR=iannucci@chromium.org

Change-Id: Ia684930202e414b46c1a5ab45f5d1e1ee8374ba9
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/483742
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

3e6c0e0f

Roll recipe dependencies (trivial). · d970f90c

recipe-roller authored Apr 20, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/30925bd08c1f78e835f04a2a3d409cf027cde55e [autoroller] All commits in updates(), only roll interesting ones. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: I3b651c2f567216444adacd0991aed01ae30d1198
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/483601
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

d970f90c

Move tools/build "url" and "gitiles" modules. · 9d2b4b23

Dan Jacques authored Apr 20, 2017

Add "tools/build"'s "url" and "gitiles" recipe modules into
"depot_tools". "gitiles" had an explicit dependency on "depot_tools", so
this formalizes this dependency.

To support "url", we vendor "requests" from "tools/build" into
"depot_tools" for it.

BUG=None
TEST=expectations

Change-Id: I1ba634ae264b5c9d3adee20db3397c83a6c52c45
Reviewed-on: https://chromium-review.googlesource.com/483316Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

9d2b4b23

Rietveld: fix search query. · e6e23755

Andrii Shyshkalov authored Apr 19, 2017

R=maruel@chromium.org,jrobbins@chromium.org
BUG=712060

Change-Id: I16651d9926fe0f3a74549a4c03896220f9a58f94
Reviewed-on: https://chromium-review.googlesource.com/482659Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e6e23755

Only attribute comments to owners that are close to the comment · b624bfe0

Jochen Eisinger authored Apr 19, 2017

A comment that is preceded with an empty line (or starts at the
beginning of the file) will be attributed to owners listed directly
below the comment. Otherwise, if the comment is in the middle of
a list of owners, it will only be attributed to the next owner.

BUG=712589
R=dpranke@chromium.org

Change-Id: I19bd7809836b6ee65ef56e2ec399e5cd09eaa132
Reviewed-on: https://chromium-review.googlesource.com/481303
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

b624bfe0

Show colored explanation in git map-branches -h · 222840fb

anatoly techtonik authored Apr 15, 2017

Bug:

Change-Id: Ie624d20ecff2afd274043620fbb2edcbcee857c6
Reviewed-on: https://chromium-review.googlesource.com/476670
Commit-Queue: anatoly techtonik <techtonik@gmail.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

222840fb

Add OWNERS for recipes/ · dd2298ab

Robert Iannucci authored Apr 20, 2017

$ git log --oneline --format='%aE' --since '12 months ago' recipes/ | sort | uniq

Bug:

R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org

Change-Id: I1c9213b9bc2cf20d117c4691190f18ea75bcaaef
Reviewed-on: https://chromium-review.googlesource.com/482541
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

dd2298ab

19 Apr, 2017 8 commits

Fix the accept_status code for create_gerrit_branch · 7d1af2b9

dimu authored Apr 19, 2017

- gerrit create branch endpoint returns code 201 instead of 200

Bug:
R=agable

Change-Id: I07697e87e506d5545e9abd501775e0fc30a48f80
Reviewed-on: https://chromium-review.googlesource.com/482522Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Di Mu <dimu@chromium.org>

7d1af2b9

Roll recipe dependencies (trivial). · c9432d71

recipe-roller authored Apr 19, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/de548b9dbccba9e27b9bdb1d5bb619fb786e87a9 [package_io] add trailing newline when dumping recipe.cfg files (iannucci@chromium.org)


TBR=iannucci@chromium.org

Change-Id: Ibc81870fbe90f0d77b0eff7a509178905d74324e
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/482679
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

c9432d71

[git-cl] refactor Change-Id manipulation in squash upload mode. · 8c90d03f

Andrii Shyshkalov authored Apr 19, 2017

R=iannucci@chromium.org

Bug:

Change-Id: Ia1729175c9f10d7c89388bf1e227904e76cbb16c
Reviewed-on: https://chromium-review.googlesource.com/482319Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

8c90d03f

[git-cl] modify change description before committing. · db02dd05

Robert Iannucci authored Apr 19, 2017

Otherwise if update_reviewers needs to modify the commit message it won't
show in gerrit.

Bug:

Change-Id: Id81db48b7d15bd17cb924d1d046b31f2c48defa7
Reviewed-on: https://chromium-review.googlesource.com/482062
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

db02dd05

Roll recipe dependencies (trivial). · 30bbd184

recipe-roller authored Apr 19, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5fe44dd7f41d954ae5b1db7e458775796151c13e Prepare for removal of expect_tests (phajdan.jr@chromium.org)
  https://crrev.com/95d0ea9d52f42965db876058ead6a8c619d1f853 Remove old simulation_test command (phajdan.jr@chromium.org)
  https://crrev.com/650286105fc31ca1d053b1dd20cb67642b80ac75 Detect duplicate recipe tests (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Id78683d3676331780a36cf01d359039de30d1f45
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/482199
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: <recipe-roller@chromium.org>

30bbd184

Revert "bot_update: pin depot_tools" · a7ba43a3

Nodir Turakulov authored Apr 19, 2017

This reverts commit e8acd40a.

Reason for revert: broke windows builds :(

Original change's description:
> bot_update: pin depot_tools
> 
> gclient runhooks often calls scripts that depend on scripts in depot_tools.
> Currently bot_update only ensures that depot_tools is present in $PATH, but
> otherwise uses whatever depot_tools already specified in $PATH. We don't pin
> depot_tools before running a recipe, so using whatever depot_tools in $PATH
> is not hermetic.
> 
> Insert the path to the pinned depot_tools to the beginning of $PATH
> 
> R=iannucci@chromium.org
> 
> Bug:
> 
> Change-Id: I31d04ba2ec7c409f89d58a51502ce3565e3a02a1
> Reviewed-on: https://chromium-review.googlesource.com/481072
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> 

TBR=iannucci@chromium.org,nodir@chromium.org,phajdan.jr@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I1a70f0f54e9b9cea7fc2f9897e62f558204a4684
Reviewed-on: https://chromium-review.googlesource.com/481440Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

a7ba43a3

[git-cl] set math is done with | not + · 100aa213

Robert Iannucci authored Apr 19, 2017

TBR=tandrii@chromium.org

Bug:

Change-Id: I1f533344b915bc4581739f508978f837a8c90f8c
Reviewed-on: https://chromium-review.googlesource.com/481073Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

100aa213

bot_update: pin depot_tools · e8acd40a

Nodir Turakulov authored Apr 18, 2017

gclient runhooks often calls scripts that depend on scripts in depot_tools.
Currently bot_update only ensures that depot_tools is present in $PATH, but
otherwise uses whatever depot_tools already specified in $PATH. We don't pin
depot_tools before running a recipe, so using whatever depot_tools in $PATH
is not hermetic.

Insert the path to the pinned depot_tools to the beginning of $PATH

R=iannucci@chromium.org

Bug:

Change-Id: I31d04ba2ec7c409f89d58a51502ce3565e3a02a1
Reviewed-on: https://chromium-review.googlesource.com/481072Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

e8acd40a

18 Apr, 2017 1 commit

Flip gerrit_util to raise exceptions on 404 by default · 6f5a8d99

Aaron Gable authored Apr 18, 2017

This makes the library behave more like what we'd expect,
while still allowing certain function to specify that
returning 204 or 404 is expected/acceptable behavior.

Change-Id: If3ce5598d1603819ee97aaeab0072a9e786ed96d
Reviewed-on: https://chromium-review.googlesource.com/481043Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

6f5a8d99