- 27 Mar, 2017 2 commits
-
-
Nodir Turakulov authored
This reverts commit 8b5b5941. Reason for revert: nothing wrong with this CL, but implementing a manual roll to build.git takes more than 20 min. I will reland this CL once my roll to build.git CL is ready Original change's description: > add "generic" infra path config > > It proved to be dangerous to introduce conditional logic into recipes > and recipe modules to alternate between buildbot and luci modes, namely > it touches buildbot code paths, which can be very dangerous. > > Instead, introduce "generic" default path config that configures > existing base paths from the built-in ones. > > Also remove swarmbucket path config because it is not used. > > R=iannucci@chromium.org > BUG=660481 > > Change-Id: Ide0e1f64913fe35766b997ab5b55f01f4c63aa58 > Reviewed-on: https://chromium-review.googlesource.com/459234 > Commit-Queue: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > TBR=iannucci@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660481 Change-Id: If27a537689dfe3669015bcbc7a5f07ca1f5c10af Reviewed-on: https://chromium-review.googlesource.com/461223Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Nodir Turakulov authored
It proved to be dangerous to introduce conditional logic into recipes and recipe modules to alternate between buildbot and luci modes, namely it touches buildbot code paths, which can be very dangerous. Instead, introduce "generic" default path config that configures existing base paths from the built-in ones. Also remove swarmbucket path config because it is not used. R=iannucci@chromium.org BUG=660481 Change-Id: Ide0e1f64913fe35766b997ab5b55f01f4c63aa58 Reviewed-on: https://chromium-review.googlesource.com/459234 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 24 Mar, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This will help remove confusion when depot_tools' recipes.py ends up in PATH. BUG=699120 Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1 Reviewed-on: https://chromium-review.googlesource.com/458430 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 18 Nov, 2016 1 commit
-
-
Nodir Turakulov authored
Currently if path_config is not specified, infra_paths defaults to buildbot paths. We want to make this behavior explicit, so we don't have to introduce a new "luci" path configuration which tells infra_paths module to do nothing. Buildbot now specifies path_config=buildbot since https://chromium-review.googlesource.com/c/412029/ , so now we can remove this default. This also affects all expectation files because this CL switches the default path configuration from Buildbot to LUCI. In particular, it changes default git cache dir from [GIT_CACHE] to [CACHE]/git. Also code paths that work only in Buildbot environment has to have a test with path_config=buildbot. R=iannucci@chromium.org, martiniss@chromium.org BUG=662586 Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae Reviewed-on: https://chromium-review.googlesource.com/411989 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 17 Nov, 2016 1 commit
-
-
Nodir Turakulov authored
We cannot easily move git cache location on all buildbot bots, but we need to define a new value for LUCI. Introduce infra_paths.default_git_cache_dir which must be used instead of using path['git_cache'] directly. R=iannucci@chromium.org, martiniss@chromium.org BUG=662586 Change-Id: I5244d7a761da94858df798abbd423c85f55936af Reviewed-on: https://chromium-review.googlesource.com/411993 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 29 Apr, 2016 1 commit
-
-
phajdan.jr@chromium.org authored
This is different from previous attempt https://codereview.chromium.org/1915463002 . The change is completely backwards-compatible, and doesn't introduce recipe expectation changes. Modules can be switched to depend on infra_paths independently, without any expectation changes either. By moving path module's config.py to paths_config.py here, we also guarantee that the returned results are going to be exactly the same. Depends on https://codereview.chromium.org/1923363003 . BUG=chromium:605919 Review-Url: https://codereview.chromium.org/1926033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2016 6 commits
-
-
martiniss@chromium.org authored
Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ ) Hopefully everything will be back to normal now... Original issue's description: > depot_tools: add infra_paths recipe module for infra-specific paths > > Depends on https://codereview.chromium.org/1906323003 > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Review URL: https://codereview.chromium.org/1915033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ ) Reason for revert: re-landing because wrong order of reverts :( Original issue's description: > Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ ) > > Reason for revert: > breaks skia bots :( > > Original issue's description: > > depot_tools: add infra_paths recipe module for infra-specific paths > > > > Depends on https://codereview.chromium.org/1906323003 > > > > BUG=chromium:605919 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 > > TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199 TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Review URL: https://codereview.chromium.org/1921373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ ) Reason for revert: breaks skia bots :( Original issue's description: > depot_tools: add infra_paths recipe module for infra-specific paths > > Depends on https://codereview.chromium.org/1906323003 > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Review URL: https://codereview.chromium.org/1917263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=chromium:605919 Review URL: https://codereview.chromium.org/1917093004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300193 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=chromium:605919 Review URL: https://codereview.chromium.org/1915113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300191 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
Depends on https://codereview.chromium.org/1906323003 BUG=chromium:605919 Review URL: https://codereview.chromium.org/1915463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
-