Commits · eb5edbcfde4930a5c4e1802f2a9d88933fbb9ce5 · Linshizhi / Chromium_Depot_tools

16 Jan, 2012 4 commits

Add UpgradeToHttps() to reliably and forcibly upgrade all urls to https. · eb5edbcf

maruel@chromium.org authored Jan 16, 2012

Enable it for git-cl and gcl.

R=nsylvain@chromium.org
BUG=107838
TEST=New connections go through https://


Review URL: http://codereview.chromium.org/9214004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117857 0039d316-1c4b-4281-b951-d872f2087c98

eb5edbcf

Dedupe codereview.settings parsing code. Add more testing. · 99ac1c58

maruel@chromium.org authored Jan 16, 2012

So any modification to the defaults is coded at only one place.

TBR=nsylvain@chromium.org
BUG=107838
TEST=


Review URL: http://codereview.chromium.org/9214002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117853 0039d316-1c4b-4281-b951-d872f2087c98

99ac1c58

Send an IM when gcl commit <change> --no_presubmit is used · 080f37c1

maruel@chromium.org authored Jan 16, 2012

R=cmp@chromium.org
BUG=25940
TEST=


Review URL: http://codereview.chromium.org/9211013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117851 0039d316-1c4b-4281-b951-d872f2087c98

080f37c1

Send an IM when hooks are bypassed to git cl dcommit · ac637156

maruel@chromium.org authored Jan 16, 2012

R=cmp@chromium.org
BUG=25940
TEST=


Review URL: http://codereview.chromium.org/9112039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117850 0039d316-1c4b-4281-b951-d872f2087c98

ac637156

14 Jan, 2012 1 commit

ninja depot_tools script: Call ninja-mac on mac. · df0fcd60

thakis@chromium.org authored Jan 14, 2012

Review URL: http://codereview.chromium.org/9214014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117754 0039d316-1c4b-4281-b951-d872f2087c98

df0fcd60

13 Jan, 2012 1 commit

Check in a ninja binary for Linux x64 and Mac. · 5b83491e

evan@chromium.org authored Jan 13, 2012

The shell script currently just assumes Linux, but can be
fixed to run the Mac binary when appropriate.

Review URL: http://codereview.chromium.org/9212017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117723 0039d316-1c4b-4281-b951-d872f2087c98

5b83491e

11 Jan, 2012 2 commits

Fix for single line file modification · db1fd78f

maruel@chromium.org authored Jan 11, 2012

When a file contains a single line of text, svn diff will generate an odd hunk
header. Modify the hunk parsing code to accept this format.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9147056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117143 0039d316-1c4b-4281-b951-d872f2087c98

db1fd78f

Accept svn:mime-type as a valid svn property. · 9799a079

maruel@chromium.org authored Jan 11, 2012

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9172003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117133 0039d316-1c4b-4281-b951-d872f2087c98

9799a079

10 Jan, 2012 4 commits

Fix svn delete handling (again). · cf602553

maruel@chromium.org authored Jan 10, 2012

Fix RAW.NEW_NOT_NULL parsing to detect correctly it's a new file.

Add proper Hunk parsing to fix these 2 bugs.

R=dpranke@chromium.org
BUG=109715
TEST=CQ'ing a patch generated with svn that delete files is applied properly, e.g. the file is deleted and not simple 0-length.

Review URL: http://codereview.chromium.org/9167015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117084 0039d316-1c4b-4281-b951-d872f2087c98

cf602553

Fix variable aliasing. Fixes pylint W0623. · 0e023174

maruel@chromium.org authored Jan 10, 2012

I'm not sure why it hasn't triggered before.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9172002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117054 0039d316-1c4b-4281-b951-d872f2087c98

0e023174

Cache diff to speed up when the diff is processed multiple times · 3bbf2943

maruel@chromium.org authored Jan 10, 2012

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9127026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117040 0039d316-1c4b-4281-b951-d872f2087c98

3bbf2943

Make sure that direct call to SendStack() doesn't send a stack trace for non googler · 18878421

maruel@chromium.org authored Jan 10, 2012

I don't want to receive them even in the case of a direct call to SendStack().

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9145001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117039 0039d316-1c4b-4281-b951-d872f2087c98

18878421

06 Jan, 2012 1 commit

trychange.py: make --sub_rep work again · 95406ac9

dgrogan@chromium.org authored Jan 06, 2012

It appears to have been broken in http://crrev.com/104148

BUG=102205

Review URL: http://codereview.chromium.org/9108030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116723 0039d316-1c4b-4281-b951-d872f2087c98

95406ac9

05 Jan, 2012 1 commit

Fix compatibility with svn 1.7. · 7d654673

maruel@chromium.org authored Jan 05, 2012

svn info --xml will return
<entry (...) revision="Resource is not under version control."> for
new files, causing an exception in the parsing code.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9110010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116522 0039d316-1c4b-4281-b951-d872f2087c98

7d654673

04 Jan, 2012 1 commit

Provide a friendlier error message after Rietveld issue deletion. · 183df1a6

miket@chromium.org authored Jan 04, 2012

As a n0oB to Chrome, I sometimes deleted uploaded CLs on codereview.chromium.org
after looking at them and deciding they were unsuitable for review. I
would then later git cl upload and get a confusing stacktrace about a
404. This change lets the user know why the error happened, and how to
resolve it.

I decided not to auto-scrub the old issue on the client side, because
the 404 might be spurious (server misconfiguration, bug in my code, etc.).
Safer to make the user explicitly run the command.

Review URL: http://codereview.chromium.org/9091009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116360 0039d316-1c4b-4281-b951-d872f2087c98

183df1a6

22 Dec, 2011 2 commits

Revert repo back to an upstream we control · a3fcf209

ferringb@google.com authored Dec 22, 2011

The purpose of this is so that cros can roll out repo updates at our
own pace (including testing), rather than being at the mercy of android
project rolling something out that may break our setup.

BUG=chromium-os:24413

Review URL: http://codereview.chromium.org/9021045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115533 0039d316-1c4b-4281-b951-d872f2087c98

a3fcf209

[depot_tools] Disabling new git checkouts with safesync_urls until fixed. · 051c88b9

dbeam@chromium.org authored Dec 22, 2011

R=maruel@chromium.org
TEST=gclient sync a freshly configured client.
BUG=106015


Review URL: http://codereview.chromium.org/8994016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115452 0039d316-1c4b-4281-b951-d872f2087c98

051c88b9

19 Dec, 2011 2 commits

Fix gcl path handling to be more consistent. · d79d4195

maruel@chromium.org authored Dec 19, 2011

gcl change will look for unmodified files from the current directory and below
only.
Add shell out are cwd=checkout's root.
Fix try/finally handlers.
Remove extraneous os.chdir() calls since cwd is now correctly set.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8994004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115027 0039d316-1c4b-4281-b951-d872f2087c98

d79d4195

[depot_tools] Adding safesync_url for git and git-svn checkouts. · e5d1e61d

dbeam@chromium.org authored Dec 19, 2011

R=maruel@chromium.org
TEST=Configure a checkout using the NewGitWorkflow with a safesync_url and everything works (though possibly with a really long git svn fetch time).
BUG=106015

Review URL: http://codereview.chromium.org/8382030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115011 0039d316-1c4b-4281-b951-d872f2087c98

e5d1e61d

15 Dec, 2011 1 commit

Add setuptools egg to third_party. · 93ee568c

chrisha@chromium.org authored Dec 15, 2011

This CL adds the egg distribution of setuptools to third_party. A follow-up CL will use this to install various required third-party eggs in a depot_tools/site-packages directory.

TBR=maruel@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8953018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114635 0039d316-1c4b-4281-b951-d872f2087c98

93ee568c

13 Dec, 2011 3 commits

Fix a regression introduced in r114262, cwd must be a named argument to subprocess2.Popen(). · f94e3f1d

maruel@chromium.org authored Dec 13, 2011

Not sure why pylint didn't catch it. :/

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8937010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114270 0039d316-1c4b-4281-b951-d872f2087c98

f94e3f1d

Enforce cwd for GIT functions · 80a9ef1e

maruel@chromium.org authored Dec 13, 2011

GIT.CaptureStatus was assuming os.getcwd() was using all the time, which isn't
true when using trychange.py --sub_rep XXX.

R=dpranke@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/8930002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114264 0039d316-1c4b-4281-b951-d872f2087c98

80a9ef1e

Enforces using cwd in all svn calls. · d579fcf9

maruel@chromium.org authored Dec 13, 2011

That helps weed out some issues faces with svn plus helped me figure out some
misuses.

Most of the commands have been implicitly depending on os.getcwd(). This change
makes it always consistent and clear when dependence on the current directory is
needed.

Remove default arguments to scm.SVN.GenerateDiff and a few other calls to be
sure the refactoring was done right.

R=dpranke@chromium.org
BUG=
TEST=make sure most commands aren't broke


Review URL: http://codereview.chromium.org/8771042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114262 0039d316-1c4b-4281-b951-d872f2087c98

d579fcf9

10 Dec, 2011 1 commit

Still send try job status even if test filter is used · 4159b736

maruel@chromium.org authored Dec 10, 2011

This caused all CQ job to not show up on rietveld. Now that rietvelt supports
multiple try job per builder per patchset, this check is not useful anymore.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8895022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113952 0039d316-1c4b-4281-b951-d872f2087c98

4159b736

09 Dec, 2011 1 commit

drover: Use Python style for accessing last item in array. · 2887b7d6

jhawkins@chromium.org authored Dec 09, 2011

Review URL: http://codereview.chromium.org/8883034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113720 0039d316-1c4b-4281-b951-d872f2087c98

2887b7d6

08 Dec, 2011 1 commit

drover: Fix --milestone to take the highest-valued branch. · 758417e3

jhawkins@chromium.org authored Dec 08, 2011

The previous code erroneously took the lowest-valued branch.
Review URL: http://codereview.chromium.org/8888028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113681 0039d316-1c4b-4281-b951-d872f2087c98

758417e3

05 Dec, 2011 2 commits

Using lists is faster than cStringIO. · 740a6c0b

maruel@chromium.org authored Dec 05, 2011

Clean up stdin management.
Remove stale comments.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8808002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113065 0039d316-1c4b-4281-b951-d872f2087c98

740a6c0b

Improve subprocess2 stdin tests. · bc3a53cb

maruel@chromium.org authored Dec 05, 2011

No significant code change.

R=dpranke@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/8801019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113062 0039d316-1c4b-4281-b951-d872f2087c98

bc3a53cb

02 Dec, 2011 2 commits

Reverted accidental commit · 56f4c474

supersat@chromium.org authored Dec 02, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112766 0039d316-1c4b-4281-b951-d872f2087c98

56f4c474

Fix pulling in patches from git subrepos · e8043d11

supersat@chromium.org authored Dec 02, 2011



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112765 0039d316-1c4b-4281-b951-d872f2087c98

e8043d11

01 Dec, 2011 3 commits

Reimplement r109239 but using Popen.communicate() instead. · 94c712fa

maruel@chromium.org authored Dec 01, 2011

Enables threaded callback handler for subprocess.communicate().

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8749015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112465 0039d316-1c4b-4281-b951-d872f2087c98

94c712fa

Handle exceptions thrown when shelling out svn commit · 5d0fc9a7

maruel@chromium.org authored Dec 01, 2011

So temporary files aren't left around.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8758004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112358 0039d316-1c4b-4281-b951-d872f2087c98

5d0fc9a7

Add Popen.shell, add more subprocess2 tests and make it more compact. · a8e8163a

maruel@chromium.org authored Dec 01, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8750003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112351 0039d316-1c4b-4281-b951-d872f2087c98

a8e8163a

30 Nov, 2011 7 commits

Silence pylint on Mac OSX 10.6 · 14e37ad7

maruel@chromium.org authored Nov 30, 2011

Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is
broken _and_ slow.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98

14e37ad7

Fix git try. git_try.py imports git_cl.py without calling its main. · 379d07a4

maruel@chromium.org authored Nov 30, 2011

Make sure settings is correctly initialized.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8745014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112222 0039d316-1c4b-4281-b951-d872f2087c98

379d07a4

Make --send-mail more useful by not requiring -r · a335365d

maruel@chromium.org authored Nov 30, 2011

Previously, --send-mail required -r to pass. Now it uses the R=|TBR= lines from
the description, which is much more useful.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8735018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112221 0039d316-1c4b-4281-b951-d872f2087c98

a335365d

Fix case where TBR=foo would remove the -r flag in git-cl · ddd59417

maruel@chromium.org authored Nov 30, 2011

Add unit test!

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8715007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112220 0039d316-1c4b-4281-b951-d872f2087c98

ddd59417

Improve testing by comparing behavior of subprocess to subprocess2 · db59bfc1

maruel@chromium.org authored Nov 30, 2011

This makes sure no regression relative to subprocess is introduced in
subprocess2.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8722001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112217 0039d316-1c4b-4281-b951-d872f2087c98

db59bfc1

Add Popen.start property. · dd9837f9

maruel@chromium.org authored Nov 30, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8694006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112102 0039d316-1c4b-4281-b951-d872f2087c98

dd9837f9

Commit cpplint.py r77 to depot_tools. · 7956a87b

erg@chromium.org authored Nov 30, 2011

Committing on behalf of Reid Kleckner <rnk@google.com>.

BUG=102890

Review URL: http://codereview.chromium.org/8676053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112099 0039d316-1c4b-4281-b951-d872f2087c98

7956a87b