It makes sure the resulting options.reviewers and options.cc are internally
consistent by splitting comma separated items.

R=iannucci@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@193496 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13956002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@193257 0039d316-1c4b-4281-b951-d872f2087c98

Currently, if "git cl patch" succeeds it prints:
Committed patch.
This patch changes "git cl patch" to print:
Committed patch locally.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13801021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@193206 0039d316-1c4b-4281-b951-d872f2087c98

This is not always necessary, like for "git cl set_close".

R=dpranke@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13741014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192829 0039d316-1c4b-4281-b951-d872f2087c98

- Improve SVN heuristic by using cutoff of 180 days instead of 
  120. I've verified this won't cause problems with the repos
  we use.  (the closest is blink ToT and chrome, blink ToT
  refers to a revision in chrome from 9 months ago)
- Alert if using local drover.properties file. Webkit devs had
  a drover.properties file that hardcodes svn.webkit.org, which
  makes drover point to the wrong revision.

BUG=227168


Review URL: https://chromiumcodereview.appspot.com/13730015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192641 0039d316-1c4b-4281-b951-d872f2087c98

This was causing extremely slow gclient sync's, and was preventing gclient from
outputting anything if a slow submodule needed significant updating.

R=cmp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13702002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192475 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13612003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192439 0039d316-1c4b-4281-b951-d872f2087c98

Building on crrev.com/12670008, add support for blink svn. The svn
revision for blink is sufficiently different from chromium that we
can revert blink changes without further logic changes. The order of
alternative repos corresponds roughly to the expected rate of use.

TEST=Tried reverting some blink revs.

Review URL: https://chromiumcodereview.appspot.com/13448004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192396 0039d316-1c4b-4281-b951-d872f2087c98

Blink wants to override the maxlen which is currently configurable in CheckLongLines but not in PanProjectChecks. This exposes the parameter on PanProjectChecks.


Review URL: https://chromiumcodereview.appspot.com/13403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192394 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13532013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192358 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Make gclient fetch git repos recursively. This is needed when adding a git repo through DEPS. If that repo has submodules, we need to fetch them or else the repo won't be complete."

This reverts commit 6a2e4710.

cmp says:
This CL causes NewGit and Git submodules workflows to comingle in ways that result in bad and unexpected failures for new and existing users.  One failure is for the new Blink developers who need to use git-svn with their WebKit third_party checkout.  Another failure is in the Windows NewGit workflow where gclient sync takes longer than necessary to complete.

The right approach at this point given the costs of this change is to revert it and rethink the best way to get projects the functionality they need while restoring the functionality existing projects have required for over a year now.

Please discuss the recursive/recurseSubmodules code face-to-face with cmp@google.com before attempting to make this live again.  Thanks.

R=cmp@chromium.org
BUG=224074


Review URL: https://chromiumcodereview.appspot.com/13470027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192236 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/13622002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192234 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/13618002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192233 0039d316-1c4b-4281-b951-d872f2087c98

Currently the NewGit workflow sets up git submodules to point to a
.git dir through a textfile indirection. git-svn isn't smart enough to
deal with this, and so we need to change things to use symlinks instead.

In the meantime, 'fetch blink' will fail. For now, we'll turn off
the svn configuration.

TBR=iannucci@chromium.org

BUG=

Review URL: https://codereview.chromium.org/13560005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192230 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/13613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192226 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org,iannucci@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13540004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192205 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13489007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192200 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org, agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13589003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192170 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org, maruel@chromium.org, agable@chromium.org

Review URL: https://codereview.chromium.org/13582005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192164 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org, agable@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/13588004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192160 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org, agable@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/13586005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192157 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/13514004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192156 0039d316-1c4b-4281-b951-d872f2087c98

This is done as a hack since we don't really have real option parsing :(.

R=iannucci@chromium.org, agable@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/13586004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192154 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org, maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13586003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192135 0039d316-1c4b-4281-b951-d872f2087c98

This is the bare minimum to have fetch.py working for chromium.
The DEPS file pulls the new tools/recipes repo in, which will contain
the recipe for chromium and all other checkout recipes eventually (followup
CL coming shortly). fetch and fetch.bat simply invoke fetch.py. fetch.py
takes a recipe and some arguments on the command line, invokes the recipe
to get its instructions, and performs the actual checkout.

Currently only supports Gclient-Git-Svn checkout (the kind needed for
Chromium), but other checkout types will be pulled from annotated_checkout.py
soon.

Review URL: https://codereview.chromium.org/13463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192050 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12646011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@191895 0039d316-1c4b-4281-b951-d872f2087c98

PresubmitPromptOrNotify prints the message and prompts the user only
if the presubmit is on upload, not commit.

This is useful to provide upload-time sanity checks without blocking
the CL from being landed via the commit-queue.


Review URL: https://chromiumcodereview.appspot.com/12676031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@190711 0039d316-1c4b-4281-b951-d872f2087c98

to rietveld for the first time.  This came up in a discussion with Nico about
changing -m for -t in the git cl upload command.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/12965015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@190399 0039d316-1c4b-4281-b951-d872f2087c98

- Check for -h|--help before anything is modified.
- Discard stderr from 'git submodule update'.
- Be careful not to overwrite script while it's executing
  on win.
- Run hooks by invoking 'git runhooks'.
- Fix --dry-run option.

R=iannucci@chromium.org
CC=jar@chromium.org,scottmg@chromium.org

BUG=


Review URL: https://chromiumcodereview.appspot.com/12865010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189926 0039d316-1c4b-4281-b951-d872f2087c98

grdp is the file that included to grd files.

Review URL: https://chromiumcodereview.appspot.com/12609012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189571 0039d316-1c4b-4281-b951-d872f2087c98

Windows will sometimes freak out if a file is rewritten while
it's being executed.  That can happen when update_depot_tools.bat
runs.

R=iannucci@chromium.org,maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/12755033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189429 0039d316-1c4b-4281-b951-d872f2087c98

svn commit likes to hang indefinitely whenever the svnserve server forgets
about the client. This changes ensures the commit queue won't be blocked by
this problem.


R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/12440058

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189382 0039d316-1c4b-4281-b951-d872f2087c98

This causes the 'git config' to only add or update the branch-heads fetch
entry, and not replace any other existing entry (e.g. refs/heads/*).

Review URL: https://chromiumcodereview.appspot.com/12634013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158663


Review URL: https://chromiumcodereview.appspot.com/12941002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189084 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/12717016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189082 0039d316-1c4b-4281-b951-d872f2087c98

Make gclient fetch git repos recursively. This is needed when adding a git repo through DEPS. If that repo has submodules, we need to fetch them or else the repo won't be complete.

Review URL: https://chromiumcodereview.appspot.com/12620024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189026 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for https://chromiumcodereview.appspot.com/12042069/
Which uses gsutil to download objects from Google Storage based on SHA1 sums

Continuation of: https://chromiumcodereview.appspot.com/12317103/
Rietveld didn't like a giant CL with all of gsutil (kept crashing on upload),
The CL is being split into three parts

Related:
https://chromiumcodereview.appspot.com/12755026/ (gsutil/boto)
https://chromiumcodereview.appspot.com/12685010/ (gsutil/gslib)

BUG=

Review URL: https://codereview.chromium.org/12685009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188896 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for https://chromiumcodereview.appspot.com/12042069/
Which uses gsutil to download objects from Google Storage based on SHA1 sums

Continuation of: https://chromiumcodereview.appspot.com/12317103/
Rietveld didn't like a giant CL with all of gsutil (kept crashing on upload),
The CL is being split into three parts

Related:
https://chromiumcodereview.appspot.com/12755026 (gsutil/boto)
https://codereview.chromium.org/12685009/ (gsutil/)

BUG=

Review URL: https://codereview.chromium.org/12685010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188842 0039d316-1c4b-4281-b951-d872f2087c98

Which uses gsutil to download objects from Google Storage based on SHA1 sums 

Continuation of: https://chromiumcodereview.appspot.com/12317103/ 
Rietveld didn't like a giant CL with all of gsutil (kept crashing on upload), 
The CL is being split into three parts 

Related: 
https://chromiumcodereview.appspot.com/12685010/ (gsutil/gslib) 
https://codereview.chromium.org/12685009/ (gsutil/) 

Review URL: https://chromiumcodereview.appspot.com/12633019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188841 0039d316-1c4b-4281-b951-d872f2087c98