Review URL: https://chromiumcodereview.appspot.com/10543151

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@142479 0039d316-1c4b-4281-b951-d872f2087c98

This is backwards compatible, and should be done prior
to upgrading repo's internals to 1.9.4.

BUG=chromium-os:31841
TEST=manual validation

Review URL: https://chromiumcodereview.appspot.com/10541155

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@142238 0039d316-1c4b-4281-b951-d872f2087c98

on origin/master.

Review URL: https://chromiumcodereview.appspot.com/10537117

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@141958 0039d316-1c4b-4281-b951-d872f2087c98

Enable copy detection for git-cl upload.  This makes
it possible to copy a directory containing many files,
add+commit the new path, and then upload a patch to
Rietveld that shows the files were copied.

In my tests, -C -C was needed to pick up a basic
file copy.  -C was not enough.  I'm not sure why
exactly.  The output generated in the diff looks
like:

  sh$ git diff -C -C HEAD~1..HEAD
  diff --git a/slave/Makefile b/slave2/Makefile
  similarity index 100%
  copy from slave/Makefile
  copy to slave2/Makefile
  ...

(This change requires r141676 /
https://chromiumcodereview.appspot.com/10543116/ which
updates upload.py to use --find-copies-harder.)

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10545107

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@141689 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10543116

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@141676 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10540035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140865 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit db5a0def.

TBR=maruel@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10532034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140808 0039d316-1c4b-4281-b951-d872f2087c98

The effect of this is to preserve the behavior of `git status`,
i.e., only changes in the top-level repository will be reported.

Updated test expectations; I have no idea what I'm doing.

Review URL: https://chromiumcodereview.appspot.com/10454088

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140396 0039d316-1c4b-4281-b951-d872f2087c98

Enable copy detection for git-cl upload.  This makes
it possible to copy a directory containing many files,
add+commit the new path, and then upload a patch to
Rietveld that shows the files were copied.

In my tests, -C -C was needed to pick up a basic
file copy.  -C was not enough.  I'm not sure why
exactly.  The output generated in the diff looks
like:

  sh$ git diff -C -C HEAD~1..HEAD
  diff --git a/slave/Makefile b/slave2/Makefile
  similarity index 100%
  copy from slave/Makefile
  copy to slave2/Makefile
  ...

Review URL: https://chromiumcodereview.appspot.com/10412027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140314 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10479004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140114 0039d316-1c4b-4281-b951-d872f2087c98

This breaks _some_ msysgit uses cases. I'll investigate later.

TBR=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10445042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@139114 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=none
TEST=python.exe git_cl_test.py

Review URL: https://chromiumcodereview.appspot.com/10442028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138964 0039d316-1c4b-4281-b951-d872f2087c98

While this is not yet necessary, it could be soon and I prefer to do this before
too many people uses it since it breaks everyone.

R=cmp@chromium.org,groby@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10440030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138886 0039d316-1c4b-4281-b951-d872f2087c98

So that a command like
 "git config rietveld.viewvc-url http://src.chromium.org/viewvc/chrome?view=rev&revision="
works fine.

Fix the description automatically generated for the hooks to be using the same
code than for the one presented to the user.

R=cmp@chromium.org
BUG=
TEST=Tested manually on cygwin, win32, linux


Review URL: https://chromiumcodereview.appspot.com/10447021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138874 0039d316-1c4b-4281-b951-d872f2087c98

These files are created when using msysgit and git-cl on Windows.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10440016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138872 0039d316-1c4b-4281-b951-d872f2087c98

Full support to tools in git-utils will be added soon

TBR=groby@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10445021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138825 0039d316-1c4b-4281-b951-d872f2087c98

No space between -- and merge.

Review URL: https://chromiumcodereview.appspot.com/10428002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138562 0039d316-1c4b-4281-b951-d872f2087c98

on http://codereview.appspot.com/6221063/ which makes sure that rietveld will
upload non-image binary files.

BUG=23608
TEST=Use apply_issue.py with an issue that contains binary files, and make
sure the files download correctly.

Review URL: https://chromiumcodereview.appspot.com/10422006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gcl upload now uploads any type of binary file, not just images.

Review URL: https://chromiumcodereview.appspot.com/10332313

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138469 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/9693033/
Review URL: https://chromiumcodereview.appspot.com/10413056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138367 0039d316-1c4b-4281-b951-d872f2087c98

Merge upstream master.

- Includes -V option to see current ninja version (120514).
- Faster build_log loading.

TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386135

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137074 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Run tests/owners_unittest.py


Review URL: https://chromiumcodereview.appspot.com/10384099

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137041 0039d316-1c4b-4281-b951-d872f2087c98

correctly.  Also fix git_cl.py.

BUG=None
TEST=Make sure that the -m command line option to gcl upload/git cl upload
does not add a new message to the rietveld issue.  The string associated to the
--message argument should only be used as the patchset title.

Review URL: https://chromiumcodereview.appspot.com/10384150

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136922 0039d316-1c4b-4281-b951-d872f2087c98

converts -m and --message to -t.

BUG=None
TEST=When uploading a patch to rietveld, make sure no new message is added to
the CL.

Review URL: https://chromiumcodereview.appspot.com/10384131

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136861 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10391070

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136603 0039d316-1c4b-4281-b951-d872f2087c98

Make exception PatchApplicationFailed() self printable.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10391033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136091 0039d316-1c4b-4281-b951-d872f2087c98

Pass a valid stdin to child processes.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136053 0039d316-1c4b-4281-b951-d872f2087c98

Add support for this status.

R=nsylvain@chromium.org
BUG=
TEST=apply_issue.py -i 10382062 should work now


Review URL: https://chromiumcodereview.appspot.com/10375056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=it works

Review URL: https://chromiumcodereview.appspot.com/10310053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10383038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135806 0039d316-1c4b-4281-b951-d872f2087c98

- Nico's improvements to memchr; didn't help perf on Windows, but to avoid diverging.
- Fix bug in ninja-deplist-helper that could cause crash when growing database
  sometimes.
Review URL: https://chromiumcodereview.appspot.com/10377038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135743 0039d316-1c4b-4281-b951-d872f2087c98

R=nsylvain@chromium.org
BUG=
TEST=A basic unit test verifies history is kept

Review URL: http://codereview.chromium.org/10310034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135651 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Change files that need OWNERS review.  Upload the patch.  Check that the warning suggests a minimum set of reviewers.

Review URL: https://chromiumcodereview.appspot.com/10222020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135619 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org


Review URL: http://codereview.chromium.org/10383031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135563 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10206030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135377 0039d316-1c4b-4281-b951-d872f2087c98

Add corresponding support to scm.SVN.Revert() to clobber the svn:ignore'd files.

This makes the commit queue remove all the unversioned files, which could have
improved its stability. It failed in practice to improve it but it's still a
good thing to do overall.

R=petermayo@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10355014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135333 0039d316-1c4b-4281-b951-d872f2087c98

Rietveld doesn't post the message when it is too large.

R=petermayo@chromium.org
BUG=
TEST=Now the CQ should stop having weird case where it doesn't post a message on
CQ failure. It was because the message was simply too long!


Review URL: http://codereview.chromium.org/10383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135326 0039d316-1c4b-4281-b951-d872f2087c98

into stdout and creating the GitDiffFilterer for git repository

BUG=125894
TEST=

Review URL: http://codereview.chromium.org/10317002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135324 0039d316-1c4b-4281-b951-d872f2087c98

Fix writing ninja log header multiple times.
Fix normalization of paths on different drives.

TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10345005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134993 0039d316-1c4b-4281-b951-d872f2087c98

Rietveld self-corrupts its status all the time, there is not point in bailing
just because of that. So just assume it's an 'M' and it'll work fine. In any
case, the diff is properly parsed to detect what was the real operation.

Add unit test that correctly process a deleted file with status:null.

TBR=nsylvain@chromium.org
BUG=
TEST=A corrupted patchset can still be committed with the Commit Queue.


Review URL: http://codereview.chromium.org/10272024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134733 0039d316-1c4b-4281-b951-d872f2087c98