- 10 Feb, 2011 1 commit
-
-
maruel@chromium.org authored
So pass a single item array. The presubmit checks would fail otherwise. This code path was definitely not exercised by the unit tests. Unit tests are left as an exercise to the reader. TBR=vbendeb BUG=none TEST=none Review URL: http://codereview.chromium.org/6479006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74396 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Feb, 2011 2 commits
-
-
maruel@chromium.org authored
Unittest is being also updated. TEST=manual . run ./presubmit_unittest.py, observe success .create a CL with code style violations (long lines, traling spaces) and observe the violations reported by 'git cl presubmit' Patch contributed by Vadim Review URL: http://codereview.chromium.org/6461011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74378 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It would fail otherwise when called directly from a git checkout subdirectory. Updated unit test. BUG=none TEST=none Review URL: http://codereview.chromium.org/6459010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74281 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2011 1 commit
-
-
maruel@chromium.org authored
Add logging to presubmit_support.py. BUG= TEST= Review URL: http://codereview.chromium.org/6004006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70378 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 2 commits
-
-
maruel@chromium.org authored
This causes some code clutter. TEST=Increased pylint warning level BUG=none Review URL: http://codereview.chromium.org/4321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Most of them are style issues or variable aliasing. TEST=Can almost enable pylint warnings BUG=none Review URL: http://codereview.chromium.org/4360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Nov, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/4108011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64598 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Oct, 2010 1 commit
-
-
maruel@chromium.org authored
Otherwise the scripts make it looks like they are hung when the presubmit checks are slow. TEST=none BUG=none Review URL: http://codereview.chromium.org/3613007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61506 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
This breaks non-ascii output on Windows but if it's not there it breaks unicode output on all other platforms. Ah code pages... TEST=none BUG=none Review URL: http://codereview.chromium.org/3415010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59966 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
For now that involves disabling a lot of tests when they can't be run. I'm unsure about the ascii encoding, it fails here if I keep this call on a French UI. TEST=none BUG=none Review URL: http://codereview.chromium.org/3333028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59137 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This tool has been quite useful noticing errors in the past and I'd have avoided a breakage in r58936 if I had run it. Had to fix a few scripts first. BUG=none TEST=new test Review URL: http://codereview.chromium.org/3337018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59107 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Aug, 2010 1 commit
-
-
bradnelson@google.com authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/3184024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57447 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
Patch contributed by Darin Petkov Review URL: http://codereview.chromium.org/2845004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@49868 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Apr, 2010 1 commit
-
-
tony@chromium.org authored
On our hardy boxes, the python has the json module, but it doesn't have all the expected methods. Fallback to simplejson if it doesn't have json.loads(). Review URL: http://codereview.chromium.org/1520025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@43907 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Mar, 2010 2 commits
-
-
maruel@chromium.org authored
TEST=verified it works in python 2.4 BUG=none Review URL: http://codereview.chromium.org/1110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42177 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/1105007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42175 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Mar, 2010 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/1116001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41973 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jan, 2010 3 commits
-
-
maruel@chromium.org authored
For example, r".*\.c" was triggering for foo.checksum. TEST=none BUG=none Review URL: http://codereview.chromium.org/558026 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37461 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Remove *.txt and *.json, add *.pl and *.pm. TEST=none BUG=none Review URL: http://codereview.chromium.org/548172 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37406 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
This makes it easier to apply commands to a set of files. For example: Run the command: svn pset svn:eol-style LF \ chrome/browser/extensions/extension_accessibility_apitest.cc \ chrome/browser/extensions/extension_accessibility_api_constants.cc \ chrome/browser/extensions/extension_accessibility_api.h \ chrome/browser/extensions/extension_accessibility_api.cc \ chrome/browser/extensions/extension_accessibility_api_constants.h \ chrome/browser/gtk/accessible_widget_helper_gtk.h \ chrome/browser/gtk/accessible_widget_helper_gtk.cc \ chrome/browser/gtk/accessibility_event_router_gtk.h \ chrome/browser/gtk/accessibility_event_router_gtk.cc \ chrome/common/accessibility_events.cc \ chrome/common/accessibility_events.h requires just 1 copy-paste. Review URL: http://codereview.chromium.org/552202 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37350 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Nov, 2009 1 commit
-
-
maruel@chromium.org authored
Noteworthy change is scm.SVN.GetFileProperty calls Capture instead of Run. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/399009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32181 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Nov, 2009 2 commits
-
-
maruel@chromium.org authored
Revert "Group SCM-specific functions in classes to simplify generalization of the interface." Revert "Fix 2 recently introduced errors." Revert "Fix a variable aliasing error." Revert "Fix typo." TBR=dpranke TEST=none BUG=none Review URL: http://codereview.chromium.org/391075 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=none BUG=none Move scm functions into a class to make it simpler to manage. Review URL: http://codereview.chromium.org/391052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2009 1 commit
-
-
maruel@chromium.org authored
TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/385007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31590 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Oct, 2009 1 commit
-
-
gspencer@google.com authored
as an answer. Review URL: http://codereview.chromium.org/268023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28557 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Oct, 2009 2 commits
-
-
thestig@chromium.org authored
BUG=23071 TEST=none Review URL: http://codereview.chromium.org/248029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28155 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
Expand presubmit_support and gclient_scm to support getting basic status and changed files from a Git checkout. BUG=5339 TEST=presubmit_support.py works from a git checkout, gcl presubmit works from a svn checkout Review URL: http://codereview.chromium.org/242140 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28092 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Sep, 2009 1 commit
-
-
maruel@chromium.org authored
Part of a larger refactoring to abstract SCM-specific bits. presubmit_support, revert, gcl: modify to import gclient_scm and gclient_utils Part of a larger refactoring to abstract SCM-specific bits. revert, gcl: modify to import gclient_scm and gclient_utils Part of a larger refactoring to abstract SCM-specific bits. gclient: pull out SCM bits Pulled out SCMWrapper into gcliet_scm.py as part of a larger refactoring to abstract SCM-specific bits. Plan is to evenutally add git support. Pulling out SCMWrapper also required pulling out utility functions into a gclient_utility.py. Patch contributed by msb@ TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26423 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2009 1 commit
-
-
pam@chromium.org authored
isn't included in the calculation. BUG=none TEST=submit change with presubmit warning, note reported time git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25806 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Sep, 2009 1 commit
-
-
thestig@chromium.org authored
Review URL: http://codereview.chromium.org/191002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25270 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Aug, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/174210 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24100 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Aug, 2009 1 commit
-
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/174163 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@23870 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Aug, 2009 1 commit
-
-
thestig@chromium.org authored
Review URL: http://codereview.chromium.org/155489 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@23271 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
TEST=unit test BUG=none Review URL: http://codereview.chromium.org/147162 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19429 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
The unit tests could modify global state in hard-to-revert ways and would make the PRESUBMIT.py check flaky. Having the test running out of process alleviate any potential issue at the cost of speed (more noticeable on Windows). TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/147035 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
Also fix argument processing. It doesn't works at the moment but doesn't throw an exception either. :) TEST=none BUG=none Review URL: http://codereview.chromium.org/125095 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18611 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Jun, 2009 3 commits
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/126068 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18309 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Small refactor of ChangeInfo to not hardcode the use of GetRepositoryRoot(). TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/125051 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18272 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Stop presubmit_support.py from calling gcl.GetRepositoryRoot(). Instead, save the repository root in ChangeInfo and name it GetLocalRoot() to make it less confusing. Add GetFileList() and GetFileNames() to ChangeInfo to make it less confusing and more "interface-like". TEST=updated unit tests with a lot of pain BUG=none Review URL: http://codereview.chromium.org/119442 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18266 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
This is annoying when using gcl presubmit. TEST=unit test BUG=none Review URL: http://codereview.chromium.org/122010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18141 0039d316-1c4b-4281-b951-d872f2087c98
-