1. 16 Aug, 2018 1 commit
  2. 09 Aug, 2018 2 commits
  3. 08 Aug, 2018 1 commit
  4. 29 May, 2018 1 commit
  5. 07 May, 2018 1 commit
  6. 04 May, 2018 1 commit
  7. 27 Feb, 2018 2 commits
  8. 12 Dec, 2017 1 commit
  9. 06 Dec, 2017 1 commit
  10. 04 Dec, 2017 1 commit
  11. 08 Nov, 2017 1 commit
  12. 02 Nov, 2017 1 commit
  13. 11 Aug, 2017 2 commits
  14. 28 Jul, 2017 1 commit
    • Dan Jacques's avatar
      [cipd] Bump version, log at warning (#2). · eb1feb90
      Dan Jacques authored
      Bump the CIPD client version to
      b482bfa19d3fa79b4b40dd5ac7a34479052e3df1. This version inculdes support
      for the "-log-level" flag.
      
      Update CIPD bootstrap scripts and tool installation scripts to log at
      warning level, so that standard operation doesn't produce any logs.
      
      This version differs from the previous CL in that the "selfupdate"
      command no longer uses "-log-level". This fixes an issue where the
      current CIPD, which doesn't support "-log-level", is given the flag
      prior to actually updating to a version that does.
      
      BUG=chromium:748651
      TEST=canary
        - Tested this CIPD version on canary waterfall successfully.
      
      Change-Id: I69dfe522d890eb307214f18d0467ce921a766446
      Reviewed-on: https://chromium-review.googlesource.com/589568
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      eb1feb90
  15. 27 Jul, 2017 2 commits
    • Daniel Jacques's avatar
      Revert "[cipd] Bump version, log at warning." · 9f9d82ac
      Daniel Jacques authored
      This reverts commit 18aa2d93.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [cipd] Bump version, log at warning.
      > 
      > Bump the CIPD client version to
      > e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      > for the "-log-level" flag.
      > 
      > Update CIPD bootstrap scripts and tool installation scripts to log at
      > warning level, so that standard operation doesn't produce any logs.
      > 
      > BUG=chromium:748651
      > TEST=canary
      >   - Tested this CIPD version on canary waterfall successfully.
      >   - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
      >     no output and works.
      >   - Tested "vpython" / "led" on OSX system, no output and works.
      > 
      > Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      > Reviewed-on: https://chromium-review.googlesource.com/588889
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      > Commit-Queue: Daniel Jacques <dnj@chromium.org>
      
      TBR=iannucci@chromium.org,dnj@chromium.org
      
      Change-Id: Ia611c1aeb204c609ff3469076b8256c54e702230
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:748651
      Reviewed-on: https://chromium-review.googlesource.com/589527Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      9f9d82ac
    • Dan Jacques's avatar
      [cipd] Bump version, log at warning. · 18aa2d93
      Dan Jacques authored
      Bump the CIPD client version to
      e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      for the "-log-level" flag.
      
      Update CIPD bootstrap scripts and tool installation scripts to log at
      warning level, so that standard operation doesn't produce any logs.
      
      BUG=chromium:748651
      TEST=canary
        - Tested this CIPD version on canary waterfall successfully.
        - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
          no output and works.
        - Tested "vpython" / "led" on OSX system, no output and works.
      
      Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      Reviewed-on: https://chromium-review.googlesource.com/588889Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      18aa2d93
  16. 20 Jul, 2017 2 commits
  17. 14 Jul, 2017 1 commit
  18. 13 Jul, 2017 3 commits
  19. 12 Jul, 2017 3 commits
    • Dan Jacques's avatar
      [win_tools] Use bundled Python CIPD packages (#2). · 3d9b5881
      Dan Jacques authored
      Re-land of bf144679.
      
      Enable bundled Python CIPD packages in bleeding-edge mode. This
      replaces the ZIP unpacking approach used before, and introduces
      validation and management through the CIPD tool. The bleeding edge
      version will only install if a sentinel file is present in the
      "depot_tools" root; otherwise, default behavior will continue.
      
      This method adds a upgrade and downgrade path to/from ZIP and
      CIPD installations. This is done by rewriting the "win_tools.bat"
      process:
      
      1) Ensure that a bootstrap Python is present.
      2) Use it to run "win_tools.py", which has the functionality of
          "git_bootstrap.py" plus Python installation.
      3) Run "win_tools.py" with appropriate flags.
      
      Some tricks were employed to handle cases where there is an
      already-running Python instance that uses the current Python
      installation and executable. This happens on bots because the
      system uses the same "depot_tools" checkout at multiple launch
      layers. To this end, we use the "python.bat" as the "current Python"
      authority and refrain from cleaning up old Python directories if their
      "python.exe" binaries are currently in use.
      
      We change the Git bleeding edge file to share the same
      sentinel file as Python, ".bleeding_edge".
      
      The new Python should have the same facilities as the original Python
      bundle.
      
      BUG=chromium:740171
      TEST=local
      
      Change-Id: I51ba6415c60b95c2aaba94b6e21bd9b3fc82f35d
      Reviewed-on: https://chromium-review.googlesource.com/568524Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      3d9b5881
    • Dan Jacques's avatar
      Always copy "python.bat". · e8eed65f
      Dan Jacques authored
      This change should be safe, since batch files are not generally
      write-contended, and "gclient" is run atomically (other things depend on
      this).
      
      The mechanism to detect whether we're downgrading is broken by
      "bot_update". While future syncs should not encounter this issue,
      current syncs still have no way to resolve it, and are left with a
      broken "python.bat" setup.
      
      We remedy this by always installing "python.bat", even if it's already
      there. This is safe, since the intended state of HEAD is for this file
      to be present at all times.
      
      BUG=chromium:741650
      TEST=None
      
      Change-Id: Ief28217bf89d201d830c46b31e0b4040c51cb322
      Reviewed-on: https://chromium-review.googlesource.com/568588Reviewed-by: 's avatarSergey Berezin <sergeyberezin@chromium.org>
      e8eed65f
    • Andrii Shyshkalov's avatar
      Revert "[win_tools] Use bundled Python CIPD packages." · af5c20f5
      Andrii Shyshkalov authored
      This reverts commit bf144679.
      
      Reason for revert: broke win bots http://o/410053
      
      Original change's description:
      > [win_tools] Use bundled Python CIPD packages.
      > 
      > Enable bundled Python CIPD packages in bleeding-edge mode. This
      > replaces the ZIP unpacking approach used before, and introduces
      > validation and management through the CIPD tool. The bleeding edge
      > version will only install if a sentinel file is present in the
      > "depot_tools" root; otherwise, default behavior will continue.
      > 
      > This method adds a upgrade and downgrade path to/from ZIP and
      > CIPD installations. This is done by rewriting the "win_tools.bat"
      > process:
      > 
      > 1) Ensure that a bootstrap Python is present.
      > 2) Use it to run "win_tools.py", which has the functionality of
      >     "git_bootstrap.py" plus Python installation.
      > 3) Run "win_tools.py" with appropriate flags.
      > 
      > Some tricks were employed to handle cases where there is an
      > already-running Python instance that uses the current Python
      > installation and executable. This happens on bots because the
      > system uses the same "depot_tools" checkout at multiple launch
      > layers. To this end, we use the "python.bat" as the "current Python"
      > authority and refrain from cleaning up old Python directories if their
      > "python.exe" binaries are currently in use.
      > 
      > We change the Git bleeding edge file to share the same
      > sentinel file as Python, ".bleeding_edge".
      > 
      > The new Python should have the same facilities as the original Python
      > bundle.
      > 
      > BUG=chromium:740171
      > TEST=local
      > 
      > Change-Id: I1b3b7d31d47d1a37a9dba9114d31681bec558736
      > Reviewed-on: https://chromium-review.googlesource.com/563036
      > Commit-Queue: Daniel Jacques <dnj@chromium.org>
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      
      TBR=iannucci@chromium.org,dnj@chromium.org
      
      Change-Id: I84574a01bbad6596912e4aaa34f019d24720b638
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:740171
      Reviewed-on: https://chromium-review.googlesource.com/567009Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
      af5c20f5
  20. 11 Jul, 2017 3 commits
    • Dan Jacques's avatar
      [win_tools] Use bundled Python CIPD packages. · bf144679
      Dan Jacques authored
      Enable bundled Python CIPD packages in bleeding-edge mode. This
      replaces the ZIP unpacking approach used before, and introduces
      validation and management through the CIPD tool. The bleeding edge
      version will only install if a sentinel file is present in the
      "depot_tools" root; otherwise, default behavior will continue.
      
      This method adds a upgrade and downgrade path to/from ZIP and
      CIPD installations. This is done by rewriting the "win_tools.bat"
      process:
      
      1) Ensure that a bootstrap Python is present.
      2) Use it to run "win_tools.py", which has the functionality of
          "git_bootstrap.py" plus Python installation.
      3) Run "win_tools.py" with appropriate flags.
      
      Some tricks were employed to handle cases where there is an
      already-running Python instance that uses the current Python
      installation and executable. This happens on bots because the
      system uses the same "depot_tools" checkout at multiple launch
      layers. To this end, we use the "python.bat" as the "current Python"
      authority and refrain from cleaning up old Python directories if their
      "python.exe" binaries are currently in use.
      
      We change the Git bleeding edge file to share the same
      sentinel file as Python, ".bleeding_edge".
      
      The new Python should have the same facilities as the original Python
      bundle.
      
      BUG=chromium:740171
      TEST=local
      
      Change-Id: I1b3b7d31d47d1a37a9dba9114d31681bec558736
      Reviewed-on: https://chromium-review.googlesource.com/563036
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      bf144679
    • Dan Jacques's avatar
      [bootstrap/win] Replace "python.bat" only on downgrade. · 265255f5
      Dan Jacques authored
      We're implementing a bootstrap downgrade for potential revert of
      https://chromium-review.googlesource.com/c/563036
      
      Currently, the downgrade sees the presence of the landed patch
      as a sign to completely reinstall Python. However, this causes
      the "python276_bin" directory to be deleted, which both ruins
      any running process (notably "service manager" and BuildBot)
      and fails due to those running processes, leaving the system in
      a broken state.
      
      Instead, we'll view the revert path as a signal to swap in the
      old "python.bat" specifically, then fall through to standard
      installation detection. Since the upgrade will not actually
      delete "python276_bin", the expected revert case will leave it
      alone, preserving existing execution environments.
      
      BUG=chromium:740966, chromium:740171
      TEST=local
        - Ran simulation of revert path with this change, observed
          better outcome.
      
      Change-Id: I0dfa5924a27bcaba49134272a344f7b9f1d475c5
      Reviewed-on: https://chromium-review.googlesource.com/567167Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      265255f5
    • Dan Jacques's avatar
      [bootstrap/win] Enable revert from upcoming patch. · 4cb9d742
      Dan Jacques authored
      The upcoming CL, https://chromium-review.googlesource.com/c/563036,
      updates "bootstrap/win"'s mechanism. However, if that patch needs to be
      reverted, its "python.bat" stub may still exist in the reverted
      repository, and will continue to point to the reverted toolchain.
      
      We don't have a good way to detect whether we should revert "python.bat".
      Instead, we will look a file generated by the CL,
      "//python_bin_reldir.txt". If we find it, we will assume that the updated
      "python.bat" is in use, and reinstall.
      
      Note that if that CL lands and does not require a revert, this logic
      will be deleted. It's just there as a safety mechanism to allow a safe
      revert.
      
      BUG=chromium:740171
      TEST=local
      
      Change-Id: Ifc638cf0512d2a889c37fbf6b8e3f7a3269331b1
      Reviewed-on: https://chromium-review.googlesource.com/566073
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      4cb9d742
  21. 07 Jul, 2017 2 commits
  22. 04 May, 2017 1 commit
  23. 03 May, 2017 1 commit
  24. 04 Apr, 2017 1 commit
  25. 02 Apr, 2017 1 commit
  26. 16 Dec, 2016 1 commit
  27. 15 Dec, 2016 2 commits
    • Robbie Iannucci's avatar
      Revert "Revert "Stop adhoc cipd client bootstrap."" · 229ac2bb
      Robbie Iannucci authored
      This reverts commit 70f351e7.
      
      Reason for revert: CIPD bootstrap is now PS 2.0 compatible.
      
      BUG=674363,673940
      
      Original change's description:
      > Revert "Stop adhoc cipd client bootstrap."
      > 
      > This reverts commit c6569aab.
      > 
      > Reason for revert: This caused crbug.com/674363, needs further investigation.
      > 
      > Original change's description:
      > > Stop adhoc cipd client bootstrap.
      > > 
      > > This was used before to get the git installer, but now depot_tools manages its
      > > own copy of CIPD.
      > > 
      > > BUG=673940
      > > 
      > > Change-Id: I1077ff7eb27d9ca191dc0092b7cacaaa69c40449
      > > Reviewed-on: https://chromium-review.googlesource.com/420303
      > > Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      > > Reviewed-by: Aaron Gable <agable@chromium.org>
      > > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
      > > 
      > 
      > TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,sebmarchand@chromium.org,chromium-reviews@chromium.org
      > BUG=673940
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > 
      > Change-Id: I7aa5561ad0df67831987cd8d53a84105d42d9663
      > Reviewed-on: https://chromium-review.googlesource.com/420320
      > Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      > 
      
      TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org,sebmarchand@chromium.org
      BUG=673940
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Change-Id: I822312b1507003ee07930ef7527e12b997457673
      Reviewed-on: https://chromium-review.googlesource.com/420321
      Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      229ac2bb
    • Robbie Iannucci's avatar
      Revert "Stop adhoc cipd client bootstrap." · 70f351e7
      Robbie Iannucci authored
      This reverts commit c6569aab.
      
      Reason for revert: This caused crbug.com/674363, needs further investigation.
      
      Original change's description:
      > Stop adhoc cipd client bootstrap.
      > 
      > This was used before to get the git installer, but now depot_tools manages its
      > own copy of CIPD.
      > 
      > BUG=673940
      > 
      > Change-Id: I1077ff7eb27d9ca191dc0092b7cacaaa69c40449
      > Reviewed-on: https://chromium-review.googlesource.com/420303
      > Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      > Reviewed-by: Aaron Gable <agable@chromium.org>
      > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
      > 
      
      TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,sebmarchand@chromium.org,chromium-reviews@chromium.org
      BUG=673940
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Change-Id: I7aa5561ad0df67831987cd8d53a84105d42d9663
      Reviewed-on: https://chromium-review.googlesource.com/420320
      Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      70f351e7