- 12 Jul, 2017 2 commits
-
-
Dan Jacques authored
"git_setup.py" does not use "logging". Remove it. BUG=None TEST=None R=iannucci@chromium.org Change-Id: Ia31882966bac056899308a67284f8fde15c7b0e0 Reviewed-on: https://chromium-review.googlesource.com/569101Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Dan Jacques authored
Several tools, including the "git" recipe module, hard-code a checkout-relative "git.bat" path. Git is a feature that is provided by the system, both to tooling and recipes: 1) For users, "depot_tools" must be on PATH, and during setup it will have installed "git.bat", ensuring that Git tooling is available in PATH. 2) For bots, the system is responsible for providing "git.bat" on PATH. This is typically done at "/b/depot_tools/git.bat", which is sync'd through the "update_scripts" step. By formally treating Git as a system resource, we absolve Windows bots and users from manually installing a depot_tools-local Git, bringing them in line with other platforms. BUG=chromium:590806 TEST=local Change-Id: I93e89855cdd330a2ba7a8cfb8117a1789d1ab54e Reviewed-on: https://chromium-review.googlesource.com/568694 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 24 Mar, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This will help remove confusion when depot_tools' recipes.py ends up in PATH. BUG=699120 Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1 Reviewed-on: https://chromium-review.googlesource.com/458430 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-