- 06 Jun, 2012 1 commit
-
-
cmp@chromium.org authored
This reverts commit db5a0def. TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140808 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Jun, 2012 2 commits
-
-
szager@chromium.org authored
The effect of this is to preserve the behavior of `git status`, i.e., only changes in the top-level repository will be reported. Updated test expectations; I have no idea what I'm doing. Review URL: https://chromiumcodereview.appspot.com/10454088 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140396 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
Enable copy detection for git-cl upload. This makes it possible to copy a directory containing many files, add+commit the new path, and then upload a patch to Rietveld that shows the files were copied. In my tests, -C -C was needed to pick up a basic file copy. -C was not enough. I'm not sure why exactly. The output generated in the diff looks like: sh$ git diff -C -C HEAD~1..HEAD diff --git a/slave/Makefile b/slave2/Makefile similarity index 100% copy from slave/Makefile copy to slave2/Makefile ... Review URL: https://chromiumcodereview.appspot.com/10412027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140314 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jun, 2012 1 commit
-
-
szager@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10479004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140114 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 May, 2012 2 commits
-
-
maruel@chromium.org authored
This breaks _some_ msysgit uses cases. I'll investigate later. TBR=cmp@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10445042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@139114 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
R=maruel@chromium.org BUG=none TEST=python.exe git_cl_test.py Review URL: https://chromiumcodereview.appspot.com/10442028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138964 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 May, 2012 4 commits
-
-
maruel@chromium.org authored
While this is not yet necessary, it could be soon and I prefer to do this before too many people uses it since it breaks everyone. R=cmp@chromium.org,groby@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10440030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138886 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
So that a command like "git config rietveld.viewvc-url http://src.chromium.org/viewvc/chrome?view=rev&revision=" works fine. Fix the description automatically generated for the hooks to be using the same code than for the one presented to the user. R=cmp@chromium.org BUG= TEST=Tested manually on cygwin, win32, linux Review URL: https://chromiumcodereview.appspot.com/10447021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138874 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
These files are created when using msysgit and git-cl on Windows. R=cmp@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10440016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138872 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Full support to tools in git-utils will be added soon TBR=groby@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10445021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138825 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 May, 2012 3 commits
-
-
tony@chromium.org authored
No space between -- and merge. Review URL: https://chromiumcodereview.appspot.com/10428002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138562 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
on http://codereview.appspot.com/6221063/ which makes sure that rietveld will upload non-image binary files. BUG=23608 TEST=Use apply_issue.py with an issue that contains binary files, and make sure the files download correctly. Review URL: https://chromiumcodereview.appspot.com/10422006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138472 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
BUG=None TEST=gcl upload now uploads any type of binary file, not just images. Review URL: https://chromiumcodereview.appspot.com/10332313 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138469 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 May, 2012 1 commit
-
-
szager@google.com authored
https://chromiumcodereview.appspot.com/9693033/ Review URL: https://chromiumcodereview.appspot.com/10413056 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138367 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2012 2 commits
-
-
scottmg@chromium.org authored
Merge upstream master. - Includes -V option to see current ninja version (120514). - Faster build_log loading. TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386135 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137074 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
TEST=Run tests/owners_unittest.py Review URL: https://chromiumcodereview.appspot.com/10384099 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137041 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 May, 2012 2 commits
-
-
rogerta@chromium.org authored
correctly. Also fix git_cl.py. BUG=None TEST=Make sure that the -m command line option to gcl upload/git cl upload does not add a new message to the rietveld issue. The string associated to the --message argument should only be used as the patchset title. Review URL: https://chromiumcodereview.appspot.com/10384150 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136922 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
converts -m and --message to -t. BUG=None TEST=When uploading a patch to rietveld, make sure no new message is added to the CL. Review URL: https://chromiumcodereview.appspot.com/10384131 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136861 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2012 1 commit
-
-
erg@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10391070 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136603 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 May, 2012 2 commits
-
-
maruel@chromium.org authored
Make exception PatchApplicationFailed() self printable. R=cmp@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10391033 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136091 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Pass a valid stdin to child processes. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136053 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 May, 2012 3 commits
-
-
maruel@chromium.org authored
Add support for this status. R=nsylvain@chromium.org BUG= TEST=apply_issue.py -i 10382062 should work now Review URL: https://chromiumcodereview.appspot.com/10375056 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135912 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=none TEST=it works Review URL: https://chromiumcodereview.appspot.com/10310053 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135873 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135806 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 May, 2012 3 commits
-
-
scottmg@chromium.org authored
- Nico's improvements to memchr; didn't help perf on Windows, but to avoid diverging. - Fix bug in ninja-deplist-helper that could cause crash when growing database sometimes. Review URL: https://chromiumcodereview.appspot.com/10377038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135743 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=nsylvain@chromium.org BUG= TEST=A basic unit test verifies history is kept Review URL: http://codereview.chromium.org/10310034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135651 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
BUG=None TEST=Change files that need OWNERS review. Upload the patch. Check that the warning suggests a minimum set of reviewers. Review URL: https://chromiumcodereview.appspot.com/10222020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135619 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 May, 2012 1 commit
-
-
cmp@chromium.org authored
TBR=maruel@chromium.org Review URL: http://codereview.chromium.org/10383031 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135563 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 May, 2012 4 commits
-
-
johnw@google.com authored
Review URL: https://chromiumcodereview.appspot.com/10206030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135377 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add corresponding support to scm.SVN.Revert() to clobber the svn:ignore'd files. This makes the commit queue remove all the unversioned files, which could have improved its stability. It failed in practice to improve it but it's still a good thing to do overall. R=petermayo@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10355014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135333 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Rietveld doesn't post the message when it is too large. R=petermayo@chromium.org BUG= TEST=Now the CQ should stop having weird case where it doesn't post a message on CQ failure. It was because the message was simply too long! Review URL: http://codereview.chromium.org/10383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135326 0039d316-1c4b-4281-b951-d872f2087c98
-
haitao.feng@intel.com authored
into stdout and creating the GitDiffFilterer for git repository BUG=125894 TEST= Review URL: http://codereview.chromium.org/10317002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135324 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 May, 2012 1 commit
-
-
scottmg@chromium.org authored
Fix writing ninja log header multiple times. Fix normalization of paths on different drives. TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10345005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134993 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 May, 2012 2 commits
-
-
maruel@chromium.org authored
Rietveld self-corrupts its status all the time, there is not point in bailing just because of that. So just assume it's an 'M' and it'll work fine. In any case, the diff is properly parsed to detect what was the real operation. Add unit test that correctly process a deleted file with status:null. TBR=nsylvain@chromium.org BUG= TEST=A corrupted patchset can still be committed with the Commit Queue. Review URL: http://codereview.chromium.org/10272024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134733 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
Until recently, no proper Git clone of depot_tools existed. All Git clones were set up locally via git svn clone. The way repos of that type are updated is via 'git svn rebase'. Now, a supported Git clone of depot_tools exists. The update process for repos of this type is via 'git fetch' and 'git rebase'. Modify the update_depot_tools* scripts so they can update depot_tools for git cloned or git svn cloned methods. This also means that git svn is no longer required, so move that test after we check for git cloned repos. R=maruel@chromium.org TEST=Linux + git clone: on Linux, git clone https://git.chromium.org/chromium/tools/depot_tools.git. Apply and commit this patch locally. Note commit hash of HEAD. Run 'git reset --hard "HEAD^^^"'. Run 'git cherry-pick HASH_OF_UPDATE_CHANGE'. Run './update_depot_tools'. Verify depot_tools is updated to latest available revision + this change. TEST=Linux + git svn clone: on Linux, git svn clone svn://svn.chromium.org/chrome/trunk/tools/depot_tools. Apply and commit this patch locally. Note commit hash of HEAD. Run 'git reset --hard "HEAD^^^"'. Run 'git cherry-pick HASH_OF_UPDATE_CHANGE'. Run './update_depot_tools'. Verify depot_tools is updated to latest available revision + this change. TEST=Windows command prompt + git clone: on Windows command prompt, run Linux+git clone test, except use update_depot_tools.bat. Verify depot_tools is updated to latest available revision + this change. TEST=Windows command prompt + git svn clone: on Windows command prompt, run Linux+git svn clone test, except use update_depot_tools.bat. Verify depot_tools is updated to latest available revision + this change. TEST=Windows cygwin + git clone: on Windows command prompt, run Linux+git clone test. Verify depot_tools is updated to latest available revision + this change. TEST=Windows cygwin + git svn clone: on Windows command prompt, run Linux+git svn clone test. Verify depot_tools is updated to latest available revision + this change. Review URL: https://chromiumcodereview.appspot.com/10263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134732 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2012 1 commit
-
-
rogerta@chromium.org authored
Apply upstream changes from http://code.google.com/p/rietveld/source/detail?r=2972a6fd9a4713862609a49d6bc953ca76fa2339&name=chromium Review URL: http://codereview.chromium.org/10269009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134574 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Apr, 2012 2 commits
-
-
thakis@chromium.org authored
On Linux, I did a full ninja checkout and then ran: python bootstrap.py ./configure.py --with-gtest=../chrome/src/testing/gtest ./ninja ninja_test ./ninja_test # (all tests passed) strip ninja I timed empty builds of 'chrome' with the old and the new version, both took 1.1s for that. Binary size comparison: 121632 bytes old binary 129920 bytes new binary I used gcc 4.4.3 to build ninja. On Mac, I updated an existing checkout to the latest version and then ran: CXX=../chrome-git/src/third_party/llvm-build/Release+Asserts/bin/clang++ \ ./configure.py --with-gtest=../chrome-git/src/testing/gtest ./ninja ./ninja ninja_test # (all tests passed) strip ninja I timed empty builds of 'chrome' with the old and the new version, both took 1.1s for that. Binary size comparison: 128976 bytes old binary 120904 bytes new binary I used clang r155352 to build ninja. Last time I used gcc 4.2, which explains the size drop. The major new features in this update are: * ninja cleans up files when interrupted mid-build * NINJA_STATUS environment variable to tweak the status line (see ninja manual) Also set svn:mimetype to application/octet-stream on both files. Review URL: https://chromiumcodereview.appspot.com/10221020/ git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134307 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
This ability is useful for versions of Chromium (i.e. Android) which want to cross-compile to another platform that has a fixed set of custom dependencies. Review URL: http://codereview.chromium.org/10127004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134280 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2012 1 commit
-
-
scottmg@chromium.org authored
Merges recent upstream changes from martine/master: - Adds -d explain for debugging; - Adds support for NINJA_STATUS to configure output (see ninja manual); - Other minor fixes. TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10235008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134119 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Apr, 2012 1 commit
-
-
scottmg@chromium.org authored
Previously when ninja.bat was run from a prompt that already had VS vars available, it was adding them a second time. Depending on what else the user had in the path, this could cause the path to become too long and so things at the end wouldn't be found. To avoid this, check if the compiler is available first, and don't run the environment set up in that case. R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10222010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@133940 0039d316-1c4b-4281-b951-d872f2087c98
-