- 29 Jun, 2021 1 commit
-
-
Josip Sokcevic authored
Bug: 1118433 Change-Id: I55d4c1cecf881d39c3189ed4fa4ef71db6eede08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2981113 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 28 Jun, 2021 4 commits
-
-
Bruce Dawson authored
This reverts commit fc3fb20e. Reason for revert: Previous versions of this changed used %scriptdir% in goma_ctl.bat and goma_auth.bat but never defined it. This eluded manual testing because these scripts would work properly as long as they were run from the depot_tools directory, but would fail when run from elsewhere. The fix to make this reland work can be found by comparing patchset 1 to patchset 3. Original change's description: > Revert "Reland "use python3 for goma related scripts"" > > This reverts commit 2a6dffaf. > > Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get > "The system cannot find the path specified." > > Original change's description: > > Reland "use python3 for goma related scripts" > > > > This reverts commit 59140d43. > > > > Reason for revert: > > Make this works in git bash. > > > > Original change's description: > > > Revert "use python3 for goma related scripts" > > > > > > This reverts commit 138ec7c5. > > > > > > Reason for revert: > > > This might have caused the following issue: > > > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233 > > > > > > Original change's description: > > > > use python3 for goma related scripts > > > > > > > > This uses python3 like autoninja{,.bat}. > > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja > > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat > > > > > > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069 > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > > > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023 > > > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > > Bug: 1221233 > > Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560 > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Bug: 1221233 > Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Bug: 1221233 Change-Id: I50412a5ea62f1607660cb7a7ab8851251c3dfe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992151Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
This reverts commit 2a6dffaf. Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get "The system cannot find the path specified." Original change's description: > Reland "use python3 for goma related scripts" > > This reverts commit 59140d43. > > Reason for revert: > Make this works in git bash. > > Original change's description: > > Revert "use python3 for goma related scripts" > > > > This reverts commit 138ec7c5. > > > > Reason for revert: > > This might have caused the following issue: > > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233 > > > > Original change's description: > > > use python3 for goma related scripts > > > > > > This uses python3 like autoninja{,.bat}. > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat > > > > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069 > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023 > > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Bug: 1221233 > Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Bug: 1221233 Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Josip Sokcevic authored
This is a reland of e53a5939 Additional bug fixes: * handle race condition in gsutil when creating its directory * limit to one gsutil process on darwin due to bug in python3 Original change's description: > Reland "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit af121aee. > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > Original change's description: > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit f059ec93. > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > Original change's description: > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > This CL updates the gsutil.py wrapper to download and use > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > v4.61 appears to be fully self-contained and have all of the > > > packages it needs vendored into it. So, there's no reason to > > > use vpython anymore, and this CL removes that. > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > the ability to force a version switch, as this should no > > > longer be necessary (it was added for a migration back in 2014 > > > but apparently this code was never removed afterwards). > > > > > > This CL also updates download_from_google_storage.py and > > > upload_to_google_storage.py to similarly not have the version flags > > > and to just use regular python3, not vpython3. > > > > > > Bug: 1184108 > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Takuto Ikuta authored
This reverts commit 59140d43. Reason for revert: Make this works in git bash. Original change's description: > Revert "use python3 for goma related scripts" > > This reverts commit 138ec7c5. > > Reason for revert: > This might have caused the following issue: > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233 > > Original change's description: > > use python3 for goma related scripts > > > > This uses python3 like autoninja{,.bat}. > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat > > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023 > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> Bug: 1221233 Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
- 26 Jun, 2021 1 commit
-
-
Fabrice de Gans authored
A bug in the logic enabling tests to be run on python3 resulted in tests never being run in python3 unless they also have a shebang line pointing to python3. Since this bug was introduced, effectively, most tests that are supposed to be run on python3 do not run at all. Since then a lot of python3 tests have regressed in Chromium. In order to fix the issue moving forward, this introduces a new argument that skips the shebang check to run a test in python3. Tests will be re-enabled one by one until every single instance in Chromium has been updated. Bug: 1223478 Change-Id: I91a0688c6f4d9b4fbf18e3d446366cded8c7f2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2986400Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Fabrice de Gans <fdegans@chromium.org>
-
- 25 Jun, 2021 1 commit
-
-
Dirk Pranke authored
This CL adds a new field to the codereview.settings file used by git_cl for project-wide defaults. If `USE_PYTHON3` is set to True, then we will run the PRESUBMIT checks under Python3 by default instead of Python2, unless the PRESUBMIT.py file contains `USE_PYTHON3 = False` on a line by itself (as opposed to now, where we'll use Python2 by default unless the file contains `USE_PYTHON3 = True`). This will allow us have Python3 be the default for new files and to eventually eliminate any uses of `USE_PYTHON3` from the individual presubmit files. Of course, you will have to go in and explicitly add `USE_PYTHON3 = False` to any Py2-only files prior to enabling this. Bug: 1207012 Change-Id: Id8ec45b43940e5bcffeee196398c711c541e733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2917747Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
- 24 Jun, 2021 2 commits
-
-
Raphael Kubo da Costa authored
Some HTTP proxies may return an HTTP error such as 503 when DNS resolution fails for GceAuthenticator._INFO_URL (http://metadata.google.internal), which causes e.g. git-cl to throw an exception rather than falling back to checking for .netrc or .gitcookies. Make GceAuthenticator._get() also consider an httplib2 proxy error a sign that the code is not running in GCE. Change-Id: Icc094829f9b044176be44e51f3cad49d4a374f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2982611 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f6ae625286ab3507b2cfeea218398e3435d23027 f6ae625 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 34b847e00d95 to bcbbe2d4b506 More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I304bec5b4b3e969e87e5bb06dbd239fada1a8fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2983608 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 23 Jun, 2021 4 commits
-
-
Nodir Turakulov authored
This reverts commit 74ef838a. Reason for revert: b/191388102 Original change's description: > [dirmd] Roll dirmd > > This CL picks up > 1. DIR_METADATA discovery optimization, based on git-ls-files > 2. Mixin support > 3. New subcommand "read" that supersedes "export" and "compute" > > Last time it was reverted because depot_tools->src got blocked, because > dirmd was used in Swarming task. The latter was resolved in > https://chromium-review.googlesource.com/c/chromium/src/+/2921324 > > Bug: 1201822, 1179786 > Change-Id: I76a580c5d60b506c1f015890fc07817de553975d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2965866 > Commit-Queue: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> Bug: 1201822, 1179786 Change-Id: I6d73267278802a424a6513357f0adda191317535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2983385 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fd22f03f112f57d043d43c06de423bf1f3215b2a fd22f03 (tikuta@chromium.org) cas: simplify _version a bit More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7bcc5475771058089733f5607cf026045f6e64cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2982759 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Song Fangzhen authored
This change updates the output format of `git cl split` when `description_file` has no footers. Bug: 1215852 Change-Id: I69764885337ec31134f2b5e2d861930e0bc8cd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2936161Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Fangzhen Song <songfangzhen@bytedance.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fe59faf05ee40c253aed7864cf238a23fbe2b0e4 fe59faf (tikuta@chromium.org) cas: get cipd package revision from file More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4d37e4bee7bffcd67cb79fefa67760a9c2bf2390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2981358 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 22 Jun, 2021 1 commit
-
-
Edward Lesmes authored
Before crrev.com/c/2876082, DEPOT_TOOLS_METRICS=0 was the env var used to disable metrics collection. Bug: b/191388102 Change-Id: I0db9d034562f2eb1afb53818b3853cef50c09826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2980230 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jack Neus <jackneus@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Jack Neus <jackneus@google.com>
-
- 21 Jun, 2021 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/31016748af891d72046ab90841d91a52d65e0415 3101674 (chanli@chromium.org) Reland "[recipe-py] rdb query: support tr_fields" More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia743c0d34196a920480f3e7bde512c7361bf3e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976865 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c3be45efdc6968f92f0e7376c3740b8413fca76a c3be45e (chanli@chromium.org) Revert "[recipe-py] rdb query: support tr_fields" More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib29ccd4ecec4fed441efcee44c5b9af9708df0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976855 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7c7d1692a27912d9750f8ddcdb06300b66f3939a 7c7d169 (chanli@chromium.org) [recipe-py] rdb query: support tr_fields More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia8f90a98006ceee927e7939341303cfe6e70077b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976854 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Chan Li authored
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2973340 Bug: 1166491 Change-Id: I1ab50fbc86542916e779e9ef5dc49a7588285a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976851Reviewed-by: Scott Lee <ddoman@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/349e1d966fa1f510f08bc268b6f9771a99e61f4d 349e1d9 (chonggu@google.com) [cipd] Add verification timeout as a passable flag. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I973cc0c7e0cf0612a70c03a092864fa74dd9a7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976852 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Scott Lee authored
This is to deploy the changes of https://crrev.com/c/2973339. Change-Id: If6f39f88e923d06e68e1f320438c3f21784b0dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2973672Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org>
-
- 18 Jun, 2021 2 commits
-
-
Chong Gu authored
For Fuchsia official builders, we need a way to increase the verification timeout so that our packages are uploaded successfully Bug:1215771 Change-Id: Ie59dc149e2b88864afea1aaf6700a94324593196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2973226 Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
Yoshisato Yanagisawa authored
This reverts commit 138ec7c5. Reason for revert: This might have caused the following issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1221233 Original change's description: > use python3 for goma related scripts > > This uses python3 like autoninja{,.bat}. > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat > > Fixed: 1203012 > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
- 17 Jun, 2021 1 commit
-
-
Takuto Ikuta authored
This uses python3 like autoninja{,.bat}. https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat Fixed: 1203012 Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
- 16 Jun, 2021 2 commits
-
-
Nodir Turakulov authored
This CL picks up 1. DIR_METADATA discovery optimization, based on git-ls-files 2. Mixin support 3. New subcommand "read" that supersedes "export" and "compute" Last time it was reverted because depot_tools->src got blocked, because dirmd was used in Swarming task. The latter was resolved in https://chromium-review.googlesource.com/c/chromium/src/+/2921324 Bug: 1201822, 1179786 Change-Id: I76a580c5d60b506c1f015890fc07817de553975d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2965866 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
Peter Wen authored
Bug: 1157931 Change-Id: I42d1b5be0e7983e1d8311b59e841468cc33fa378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2966637 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com>
-
- 15 Jun, 2021 7 commits
-
-
Fumitoshi Ukai authored
This reverts commit ecdc3625. Reason for revert: http://b/191118784 was not reproduced. Original change's description: > Revert "Roll out new goma client binary VERSION=224" > > This reverts commit 6ec423c7. > > Reason for revert: http://b/191118784 > > Original change's description: > > Roll out new goma client binary VERSION=224 > > > > Bug: b/190680102 > > Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Fumitoshi Ukai <ukai@google.com> > > Bug: b/190680102, b/191118784 > Change-Id: I732413b6b639f440383a89cfeb6b35d8ece995c0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960304 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: b/190680102, b/191118784 Change-Id: I6152af3c21d77454c0f7ef564f8a9b433996a15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2963795 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
Mike Frysinger authored
We deleted this in chromite back in 2013. Looks like we forgot to clean up depot_tools. Bug: 216050 Change-Id: I7e7591aaa319ab1aeb7cc3f34e33b313b5029257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812199Reviewed-by: Stephane Belmon <sbelmon@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/caa777138987d83c540887e5fe3256f69ad0315a caa7771 (yuanjunh@google.com) [python3] Support recipe fetch and bundle to run in py2 and py3... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org, tandrii@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia920ce72e2e64c9e9052aa236e10c3a641c28ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2964481 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Takuto Ikuta authored
This reverts commit 6ec423c7. Reason for revert: http://b/191118784 Original change's description: > Roll out new goma client binary VERSION=224 > > Bug: b/190680102 > Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Fumitoshi Ukai <ukai@google.com> Bug: b/190680102, b/191118784 Change-Id: I732413b6b639f440383a89cfeb6b35d8ece995c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960304 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Fumitoshi Ukai authored
Bug: b/190680102 Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
Bruce Dawson authored
If you copy\paste a license header in such a way that \r\n line endings are used (I have done this) then CheckLicense would fail. This is quite confusing because the license looks perfect in most text editors. This change tells CheckLicense to treat \r\n line endings as equivalent to \n and let CheckForWindowsLineEndings do its job of warning about the \r\n line endings. This avoids confusing presubmit messages. Bug: 801033 Change-Id: I37fa4a6d9cd0f1a4dcce1267175f4b8fd298b906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2951788Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0afd693c9bf53a74e7c575891001a7e0d7491fae 0afd693 (gbeaty@chromium.org) Update StepCommandContains to support regexes. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8cb750a0ca5a4a3f4bae499d59711d9c83b24c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2961794 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 14 Jun, 2021 1 commit
-
-
Greg Guterman authored
Quick run is only set when the -q flag is passed. It is not set to 0 by other flags because only Chromium has Quick run and there are other depot_tools users. We rely on the CQ to set the flag back to 0. Bug: 1192827 Change-Id: I3310c9f005343f7d3eea56eaad5f19c7ba751921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927818 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 11 Jun, 2021 2 commits
-
-
Dirk Pranke authored
This reverts commit e53a5939. Reason for revert: Speculative revert for build failures on Mac11 bots: crbug.com/1219065. Original change's description: > Reland "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit af121aee. > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > Original change's description: > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit f059ec93. > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > Original change's description: > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > This CL updates the gsutil.py wrapper to download and use > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > v4.61 appears to be fully self-contained and have all of the > > > packages it needs vendored into it. So, there's no reason to > > > use vpython anymore, and this CL removes that. > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > the ability to force a version switch, as this should no > > > longer be necessary (it was added for a migration back in 2014 > > > but apparently this code was never removed afterwards). > > > > > > This CL also updates download_from_google_storage.py and > > > upload_to_google_storage.py to similarly not have the version flags > > > and to just use regular python3, not vpython3. > > > > > > Bug: 1184108 > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: Ib0757e0873d6e6b39621d50d327d959f0fa43720 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2957473 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Brian Ryner authored
This contains https://chromium-review.googlesource.com/c/infra/infra/+/2943752 , a stability fix for Mac (and potential startup performance improvement). Bug: 1215121 Change-Id: I77a90b8b00ddf0570dc8e0e5821c0b31b60ab79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2951423Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Brian Ryner <bryner@google.com>
-
- 10 Jun, 2021 5 commits
-
-
Dirk Pranke authored
This reverts commit af121aee. Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. Original change's description: > Revert "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit f059ec93. > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > Original change's description: > > Update gsutil to use gsutil version 4.61, python3. > > > > This CL updates the gsutil.py wrapper to download and use > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > v4.61 appears to be fully self-contained and have all of the > > packages it needs vendored into it. So, there's no reason to > > use vpython anymore, and this CL removes that. > > > > Also, this CL removes the 'fallback' option to gsutil and > > the ability to force a version switch, as this should no > > longer be necessary (it was added for a migration back in 2014 > > but apparently this code was never removed afterwards). > > > > This CL also updates download_from_google_storage.py and > > upload_to_google_storage.py to similarly not have the version flags > > and to just use regular python3, not vpython3. > > > > Bug: 1184108 > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Roberto Carrillo authored
This is to pick up crrev.com/c/2921147 Bug: 1169866 Change-Id: I7e1d78536fd7820c54066bc675fa0c7404454783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2930649Reviewed-by: Scott Lee <ddoman@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
-
Edward Lesmes authored
Change-Id: I34eed860f9fd68c2382cdcf955f2f5e10ebb31c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946936 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com>
-
Edward Lesmes authored
When running using led, DEPOT_TOOLS_REPORT_BUILD might not be set, and bots will try to collect metrics. Set DEPOT_TOOLS_COLLECT_METRICS so metrics are not collected on this case. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chromiumos Change-Id: I8b1083b31ef6daf87d24544a990bee863543aa1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946935Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Fumitoshi Ukai authored
Bug: b/190141502 Change-Id: I6c5074a2d91082fee398e80e6fd1682e07997dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2950609Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-