- 08 Jan, 2019 1 commit
-
-
Avi Drissman authored
Using base/std::size and std::extent does not result in the creation of a VLA; cpplint should not warn on their use. BUG=837308 Change-Id: Ie133b2144b6c1c9f4f5e406144f28b333a212197 Reviewed-on: https://chromium-review.googlesource.com/c/1399961Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org>
-
- 07 Jan, 2019 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1f61472de5efab2217261a2912af7682f0e5c62e [isolated] Allow ability to isolate a given root directory. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie2bef3cefb24a9df75ba14608337897addd3d71d Reviewed-on: https://chromium-review.googlesource.com/c/1398623Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 04 Jan, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c1b615b6808b8aa8001b5e4e1d5d234233ad8266 [buildbucket] Add set_output_gitiles_commit (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia34028e3fe28469bf8202948ccaafdf38e15b9eb Reviewed-on: https://chromium-review.googlesource.com/c/1396583Reviewed-by:
-
Nodir Turakulov authored
This bug caused https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8925230260185002096/+/steps/presubmit/0/stdout Tested locally R=vadimsh@chromium.org Change-Id: I9c42b7d7e9a1366e00fe40ca8a9f18ff0629663a Reviewed-on: https://chromium-review.googlesource.com/c/1396527 Auto-Submit: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/be3df181ebe1e4a67251ef904e4396553b959506 [buildbucket] Parse created_ts from string (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idfeb2ea0aca20da3dfba0398057404c6c20adf26 Reviewed-on: https://chromium-review.googlesource.com/c/1396099Reviewed-by:
-
- 03 Jan, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/77f5f049d615d9086198660ebe9539ce7abbf7ff [buildbucket] Parse created_ts (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1f7a27a53b534b50f7c21b2c99b50530de07f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/1394816Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1e2a5440207a57b828e58d3998501b2a45679ada [isolated] Roll the isolated CLI tool version (nmulcahey@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3f89db3268f1ae2790628695d2a91b8f0925cba2 Reviewed-on: https://chromium-review.googlesource.com/c/1394805Reviewed-by:
-
- 21 Dec, 2018 1 commit
-
-
Edward Lemur authored
Fix CheckOwnersFormat so that it checks the new OWNERS files instead of the original ones. Change-Id: I4abb1cfc847bd28f45b9948fe7775c10dcc8a420 Reviewed-on: https://chromium-review.googlesource.com/c/1382946Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 20 Dec, 2018 7 commits
-
-
Mike Frysinger authored
This rolls a few changes from upstream noticed by early testing. Bug: 900461 Change-Id: Iea568be41e3149a667fba655576bdd591b353079 Reviewed-on: https://chromium-review.googlesource.com/c/1387706Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/354bb02e9c0b74eea43faa883ac1aa134c435e3c [swarming] Add support for environment variables. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iacd8293734181d6d5cdfb8af38c1824ab9cfe586 Reviewed-on: https://chromium-review.googlesource.com/c/1387704Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/19c28875c9f1519cac7156e07dbb8e59ff40f7c1 [isolated] Add download method (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I62be38022b84c35c5c17d4b18fd411af2ce176ad Reviewed-on: https://chromium-review.googlesource.com/c/1387567Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1236ebd26cbcfae759c3857b26bd9bd1cf3547d2 [file] Introduce SymlinkTree (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5ff1123b7289e134a765e20a6c4e9dc2f8e6c142 Reviewed-on: https://chromium-review.googlesource.com/c/1387566Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0fad0863959ecf172fb460a7008eeabf8c8f078d [swarming] Minor clean-up and typo fixes. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id98f511e9d4344f8625ff5d3732d792e669e4850 Reviewed-on: https://chromium-review.googlesource.com/c/1387565Reviewed-by:
-
Clemens Hammacher authored
This also allows digits in class decorators, to also match macros like V8_EXPORT_PRIVATE. Note: I uploaded a pull request for the (previous) upstream at https://github.com/google/styleguide/pull/422, but then was told that that repository is not maintained any more. R=jochen@chromium.org Bug: chromium:916550 Change-Id: I24cd1829b794b296be8e0c2829271c746751ee1c Reviewed-on: https://chromium-review.googlesource.com/c/1383472 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c3fbb33835795d43242ef673522148ade63a3cf0 [swarming,isolated] Add `on_path` methods. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I150752f2f6e26edb7c86969e93ae95a925fe2c8b Reviewed-on: https://chromium-review.googlesource.com/c/1385506Reviewed-by:
-
- 19 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
I added document explaining ninjalog collection. This document explains what type of data is collected and how the data will be used. Bug: 900161, b/120645342 Change-Id: If47517aaa7a5510e4a634b5ccc0e4127d014dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1381912 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Bruce Dawson authored
When non-Googlers try to build Chromium for the first time they get an error saying: Please follow the instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md However those instructions are quite long and it's not obvious to some users which part of the instructions they have forgotten. The most likely is that they didn't set DEPOT_TOOLS_WIN_TOOLCHAIN=0, so this changes the error message to suggest that directly. Auto-detecting the correct state for DEPOT_TOOLS_WIN_TOOLCHAIN was tried in crrev.com/c/1374833 but deemed impractical. Bug: 907300, angleproject:2712 Change-Id: I45a9f59babe90bbe2137d49c555884d7bbbcf170 Reviewed-on: https://chromium-review.googlesource.com/c/1382942Reviewed-by:
-
- 18 Dec, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com) R=iannucci@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1ce8de0ea0660d734f553d18a051ba0552d263e5 Reviewed-on: https://chromium-review.googlesource.com/c/1382977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org>
-
Mike Frysinger authored
This syntax seems to be invalid, so remove it to unblock others. Bug: 900461 No-Presubmit: True Change-Id: I16569b8f8236a14b6dc879c973e4925a99649ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1382975 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Mike Frysinger authored
Bug: 900461 Change-Id: I74bf2a048f766d95a8d11d74f5a97e67898299fe Reviewed-on: https://chromium-review.googlesource.com/c/1380591Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
This picks up the following changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/d052999e151b..20acb618582d/cipd R=tandrii@chromium.org, iannucci@chromium.org BUG=915278 Change-Id: Ibaa9d20456dcb513d9bbdaf0bca970390254ee67 Reviewed-on: https://chromium-review.googlesource.com/c/1381773Reviewed-by:
-
Don Garrett authored
R=-owners Bug: None Change-Id: I9ff818b65b1c9a2a3a19f65932ffac4957dab0cc Reviewed-on: https://chromium-review.googlesource.com/c/1382934 Auto-Submit: Don Garrett <dgarrett@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This function extracts build target from command line. Bug: 900161 Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c Reviewed-on: https://chromium-review.googlesource.com/c/1381911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I86b8b38db5dbbdec46efeeb929c937e193e489ea Reviewed-on: https://chromium-review.googlesource.com/c/1381274Reviewed-by:
-
- 17 Dec, 2018 3 commits
-
-
Takuto Ikuta authored
Use unittest module instead of doctest. Bug: 900161 Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1379441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Edward Lemur authored
Tbr: tandrii@chromium.org Bug: 914712 Change-Id: Iff8aecff346692ef36fd653f226b48270fefa304 Reviewed-on: https://chromium-review.googlesource.com/c/1380972Reviewed-by:
-
Edward Lemur authored
Bug: 914712 Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42 Reviewed-on: https://chromium-review.googlesource.com/c/1377295 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 15 Dec, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0d040fde89eac5b4762eab44a97e9556de6cffb8 [path] Add additional info to the assert in mkdtemp/mkstemp. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iedb912a8205792211f10f221518b94a53bc9fb34 Reviewed-on: https://chromium-review.googlesource.com/c/1378962Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d3f6d71aea0086eb34ae3cbbe7fbfd729d16b29f Fix README generation from a66cf68621e2c514b7684e5404cd700a700f1aba (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I542f25dbea97c7a25b714ed41d005a26b6234f9e Reviewed-on: https://chromium-review.googlesource.com/c/1378958Reviewed-by:
-
- 14 Dec, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a66cf68621e2c514b7684e5404cd700a700f1aba [swarming] Create minimal swarming module. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieeda3bddd24b2e839ce93a88bcfae45f6251e66e Reviewed-on: https://chromium-review.googlesource.com/c/1378956Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3 [depend_on] Remove "depend_on" functionality. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7b45506ea2a466d1773323a1d9e04471a10f3058 Reviewed-on: https://chromium-review.googlesource.com/c/1378955Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100 [stream_logdog] Remove old unused annotations.proto support. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id20b679d186819a4452271e4aa338892753fee00 Reviewed-on: https://chromium-review.googlesource.com/c/1378953Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07 [manual_roll] Add new manual_roll command. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7997ef3d51a412830ebbb97962445c90d7040c25 Reviewed-on: https://chromium-review.googlesource.com/c/1378926Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4 [protobuf] Update to protobuf 3.6.0. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2387dc2437bd0576850b73c20ef423cbed7e3fa5 Reviewed-on: https://chromium-review.googlesource.com/c/1378925Reviewed-by:
-
- 13 Dec, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/17552e0276fe41580387b0d2a720298ed497010a Reland "Remove old run code" (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie183466497539d00c1272d4ef7429cad289873ab Reviewed-on: https://chromium-review.googlesource.com/c/1377269Reviewed-by:
-
Bryce Thomas authored
Commit a185e2e3 removed the Rietveld code review implementation, albeit hasn't expunged all references to Rietveld. This leads to an assertion error when running |git cl format| on a non-Gerrit change. There appears to have been a recent attempt to articulate this error better in a185e2e3, albeit not fix the underlying issue. This change addresses the immediate issue by defaulting the code review implementation to Gerrit rather than Reitveld. R=joenotcharles@google.com, tandrii@chromium.org Bug: 914150 Change-Id: I64d33e5a172cc43339ec417f7f0a7820e0337772 Reviewed-on: https://chromium-review.googlesource.com/c/1372928Reviewed-by:
-
Robert Iannucci authored
This removes the '-mode' flag from the emitted job descriptions. TBR=nodir@chromium.org Bug: 914196,914926 Change-Id: I94ab67f0969b198164fa3fc3ef64a649dcf941bd Reviewed-on: https://chromium-review.googlesource.com/c/1376657Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
Change-Id: I00f1d6716ca5ece647d7ac15471ded25c1f164b2 Reviewed-on: https://chromium-review.googlesource.com/c/1370125Reviewed-by:
-
Clemens Hammacher authored
Include verbose output of `git map-branches` to make visible what the state of the different branches is. R=iannucci@chromium.org Change-Id: I4af03ef15b39e4ba84a41c01d1ec801e7bb4bbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1360711Reviewed-by:
-
Clemens Hammacher authored
Document the -v and --no-color options. R=iannucci@chromium.org Change-Id: I07624403f591b23cc5701aa8201124fdfdb65781 Reviewed-on: https://chromium-review.googlesource.com/c/1360710Reviewed-by:
-
