- 02 Apr, 2018 6 commits
-
-
Edward Lesmes authored
We should apply the patch only when gerrit_repo and gerrit_ref are passed, instead of using only the --apply-patch-on-gclient flag. R=agable@chromium.org Bug: 643346 Change-Id: I28547aed9daeefa2657a108e0bacbfd4fc9fa07e Reviewed-on: https://chromium-review.googlesource.com/989667Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Aaron Gable authored
TBRs bypass owners checks, but are also semi-suspicious: a contributor TBRing many changes in a row to submit code to a directory they don't own would be seen, frowned upon, and inquired into. However, a contributor could bypass this by simply TBRing a single change to add themselves to an OWNERS file, and then contributing as normal from there. This CL removes that loophole. This will not affect sheriffs who TBR reverts for two reasons: first, it is rare that a chance touches both code and an OWNERS file, and therefore it is rare that OWNERS changes get reverted; second, quick reverts (the kind sheriffs do) bypass PRESUBMIT entirely, and therefore also skip OWNERS checks. Bug: 688115 Change-Id: If2b5c9d058c62caf95389287e0bb706aef721baf Reviewed-on: https://chromium-review.googlesource.com/982601 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Aaron Gable authored
git_cl.py uses auth.py to authenticate to cr-buildbucket, but when it does so, it caches the token under a key for the current codereview host, not the buildbucket hostname. This is confusing, but is the desired behavior, so that users can use different credentials (e.g. chromium and google) when communicating with buildbucket about CLs on different gerrit hosts (e.g. chromium and chrome-internal). To prevent other people from getting confused like I did, add some documentation to this effect. Change-Id: If16896d15423bbdecf9624393773ac01d0d16a66 Reviewed-on: https://chromium-review.googlesource.com/990674 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
Aaron Gable authored
Since no one can upload or land changes from Rietveld anymore, PRESUBMIT and its support files no longer need to be able to support it. R=tandrii@chromium.org Bug: 770408 Change-Id: I749092b66fdca16d5cef77e8cefc905aa5375b50 Reviewed-on: https://chromium-review.googlesource.com/693380 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Ravi Mistry authored
Bug: chromium:631551 Change-Id: I1f0c397d13d601a8ecac8328b6d7bf3c117c8297 Reviewed-on: https://chromium-review.googlesource.com/986286 Commit-Queue: Ravi Mistry <rmistry@chromium.org> Reviewed-by:
-
Edward Lesmes authored
If the variable doesn't already exist, gclient setdep will attempt to create a new variable with the given name and value as the first variable in the vars dict. R=agable@chromium.org, mmoss@chromium.org Bug: 760633 Change-Id: I2462e70c3695a730f87c58e56c639104efbfa54a Reviewed-on: https://chromium-review.googlesource.com/989282 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
-
- 31 Mar, 2018 3 commits
-
-
Sergio Villar Senin authored
Looks like the error codes issued by python's http library might vary between versions/distros. The code tries to reach an URL which is only valid inside GCE and in the event of getting an error it assumes the user is a non-googler. At least in this case, we're seeing: third_party.httplib2.socks.HTTPError: (404, 'No such domain') Adding this exception type allows the function to work correctly. Change-Id: I08d3656b25d9046f8b2fc0da2a2b7c7a698c1d92 Reviewed-on: https://chromium-review.googlesource.com/978212 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Edward Lesmes authored
file_list can be none if gclient runs with --nohooks. Fix apply_patch_ref so that it doesn't try to update file_list when it is None. TBR=agable@chromium.org Bug: 643346 Change-Id: If00547da004415edfe68196a44cbda753b4db017 Reviewed-on: https://chromium-review.googlesource.com/989279 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Michael Moss authored
This is useful for processing purely "local" DEPS files, with a command-line like: gclient revinfo --output-json /tmp/out \ --spec 'solutions=[{"name": ".", "deps_file": "myDEPS", "url": None}]' This is specifically to fix the "revinfo --output-json" case, but it also cleans up some errors in the 'flattening' test cases. Note that None values already work when using 'revinfo' with stdout output, it's just the json output that complains. BUG=825063 Change-Id: If5f69ba51cb9d0aa0f2b48a2f9b4ed8706b4c738 Reviewed-on: https://chromium-review.googlesource.com/989022 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
-
- 30 Mar, 2018 5 commits
-
-
John Budorick authored
in particular, https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/987630 Bug: 643346 Change-Id: I629f0ee3fe43133d007c7d8059f3ff8616ec782a Reviewed-on: https://chromium-review.googlesource.com/989032Reviewed-by:
-
Edward Lesmes authored
Add support for more ways to express revisions in DEPS files, notably "<origin-url>@<revision>" which is needed for src-internal. Bug: 760633 Change-Id: I86724b9c077c6101a0c424d80460123d15533da8 Reviewed-on: https://chromium-review.googlesource.com/988493 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Anatoly Matyukhin authored
cipd.bat is called from bootstrap/win/win_tools.bat. ERRORLEVEL in win_tools.bat script should not mean return code of cipd.bat. Bug: none Change-Id: Ia425d5054fa9c1e1f84b4a10decc265669911646 Reviewed-on: https://chromium-review.googlesource.com/987954Reviewed-by:
-
Edward Lesmes authored
The URLs for the dependencies in DEPS files might end in '.git', so search for them too. R=agable@chromium.org Bug: 643346 Change-Id: I955c2750179b54fec26423f5123b3fa7eea38d96 Reviewed-on: https://chromium-review.googlesource.com/987630 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Bug: 797463 Change-Id: Ia8f565997dfe2180586a8777c51f1f32229dbf3b Reviewed-on: https://chromium-review.googlesource.com/986922Reviewed-by:
-
- 28 Mar, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/583ce62f5f4bb3a2d4821bc0568e39810c043b14 [buildbucket] add build_input property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia802c79ca5aee4a715da1871645633725c36659d Reviewed-on: https://chromium-review.googlesource.com/984740Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Nico Weber authored
Add some other people to recipes/OWNERS Change-Id: I554d1fd354e628d2e62629be7ce20e899364c4a9 Reviewed-on: https://chromium-review.googlesource.com/984972 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Nico Weber authored
To be used in https://chromium-review.googlesource.com/c/chromium/tools/build/+/984433 Bug: 820421 Change-Id: I76d32ed9f7b5caa256bfa85220ac0c256bbc1a48 Reviewed-on: https://chromium-review.googlesource.com/984692Reviewed-by:
-
Edward Lesmes authored
This is a reland of 88f9c40e We no longer need the vars dict to be declared before vars can be used. This was causing problems because gclient flatten printed vars after deps, breaking the above assumption. Original change's description: > gclient eval: Expand vars while parsing DEPS files > > Introduce a Parse function that takes care of expanding vars while parsing > the DEPS file. > > It wraps Exec and exec calls, and supports deferring the expansion until > later, so gclient flatten gets access to the unexpanded version. > > Bug: 821199 > Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2 > Reviewed-on: https://chromium-review.googlesource.com/973749 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> Bug: 821199 Change-Id: I583df23558f91871e1a2aa2574c20d35e54635f6 Reviewed-on: https://chromium-review.googlesource.com/981086 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Sergey Berezin authored
Bug: 803158 Change-Id: Ie42a726a85d86ff4d62d141a6413886787760835 R=martiniss@chromium.org Reviewed-on: https://chromium-review.googlesource.com/982599Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
- 27 Mar, 2018 3 commits
-
-
Aaron Gable authored
None of these repos has had a .DEPS.git file in over 3.5 years. R=ehmaldonado Bug: 824734 Change-Id: I768e247eee5a8eff9fcf8f1891497840909ec9fa Reviewed-on: https://chromium-review.googlesource.com/982521Reviewed-by:
-
Michael Moss authored
This will make it easier to programmatically determine where a flattened entry originated, which is needed for recursively branching and unpinning DEPS files. BUG=825063 R=dpranke@google.com Change-Id: Id280c0b0a95b8664602e0ec4513722fe4d6d1ebf Reviewed-on: https://chromium-review.googlesource.com/977326Reviewed-by:
-
Edward Lesmes authored
Is easier to configure experimental bots this way. Bug: 643346 Change-Id: Idb6d3a68b02949dce71dbcba38e8ef756c467830 Reviewed-on: https://chromium-review.googlesource.com/981515 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 26 Mar, 2018 2 commits
-
-
Edward Lesmes authored
This adds a --enable-gclient-experiment flags that tells bot_update.py to skip applying the patch, and instead forward the flags to gclient. Bug: 643346 Change-Id: Ia4275a126e6adba54dfcc894d224c50c166db90e Reviewed-on: https://chromium-review.googlesource.com/962938 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Egor Pasko authored
This reverts commits: dbbf350a Fix trailing whitespace test. b4f1d449 Fix actual pylint errors. 0d9ecc92 Reland "gclient eval: Expand vars while parsing DEPS files" Reason: http://crbug.com/825724 Clank Official Build Failure - 65.0.3325.193 TBR=agable@chromium.org Bug: 825724 Change-Id: Icef2d0ccc8a13b782a8e3d6b474b1281820947b5 Reviewed-on: https://chromium-review.googlesource.com/980334 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 24 Mar, 2018 1 commit
-
-
Robert Iannucci authored
And write the test better to avoid overzealous editor plugins :) TBR=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org Bug: 825290,825174 Change-Id: I0541d4d70bcb256c24cb659bae256fa0aacb6806 Reviewed-on: https://chromium-review.googlesource.com/979116 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
- 23 Mar, 2018 5 commits
-
-
Robert Iannucci authored
TBR=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org Bug: 825290,825174 Change-Id: Ide4f03b0f9100a2110bad9d510921b46b2d4e43a Reviewed-on: https://chromium-review.googlesource.com/979112Reviewed-by:
-
Robert Iannucci authored
Again, sys.path shouldn't ever be exported into PYTHONPATH :) R=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org Bug: 825290,825174 Change-Id: Ia0594da3ff25972a08fdf74ae2aef5be79cbf3af Reviewed-on: https://chromium-review.googlesource.com/978594Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Edward Lesmes authored
This is a reland of 88f9c40e Original change's description: > gclient eval: Expand vars while parsing DEPS files > > Introduce a Parse function that takes care of expanding vars while parsing > the DEPS file. > > It wraps Exec and exec calls, and supports deferring the expansion until > later, so gclient flatten gets access to the unexpanded version. > > Bug: 821199 > Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2 > Reviewed-on: https://chromium-review.googlesource.com/973749 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> Bug: 821199 Change-Id: Ic04af0cae59abc01a0382e2de3497a91cf7e62fd Reviewed-on: https://chromium-review.googlesource.com/978561Reviewed-by:
-
Sergiy Byelozyorov authored
When specified it will skip any issues that were not modified in the specified time period even if they are owned by the user. R=tandrii@chromium.org Change-Id: I230c8fa6cbc517c32edb8618a831a62ec6e45405 Reviewed-on: https://chromium-review.googlesource.com/978170Reviewed-by:
-
Robert Iannucci authored
On buildbot (only), we don't trust PYTHONPATH, so we have set VPYTHON_CLEAR_PYTHONPATH to make the first invocation of vpython in a given chain of python invocations clear PYTHONPATH. This has the unfortunate side-effect that python scripts that set PYTHONPATH and then call into vpython (like presubmit) end up having their PYTHONPATH modifications removed. As a workaround (until I clean up PYTHONPATH in buildbot for real), fix presubmit_canned_checks so that it clears VPYTHON_CLEAR_PYTHONPATH when it adjusts PYTHONPATH. R=charlie@chromium.org, nodir@chromium.org, vadimsh@chromium.org Bug: 825290,825174 Change-Id: Ib5f73add1726fdf3c335d26fc0af76cfe3b747b2 Reviewed-on: https://chromium-review.googlesource.com/978632Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 22 Mar, 2018 6 commits
-
-
Benjamin Pastene authored
This reverts commit 88f9c40e. Reason for revert: suspected to be causing update scripts failures and prevent gce bots from connecting https://build.chromium.org/deprecated/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/128479/steps/update_scripts/logs/stdio Original change's description: > gclient eval: Expand vars while parsing DEPS files > > Introduce a Parse function that takes care of expanding vars while parsing > the DEPS file. > > It wraps Exec and exec calls, and supports deferring the expansion until > later, so gclient flatten gets access to the unexpanded version. > > Bug: 821199 > Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2 > Reviewed-on: https://chromium-review.googlesource.com/973749 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> TBR=agable@chromium.org,dpranke@chromium.org,ehmaldonado@chromium.org Change-Id: Ib9b84c13ef9b56735fd8f714b74a6601c61715e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821199 Reviewed-on: https://chromium-review.googlesource.com/976721Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
-
Edward Lesmes authored
Introduce a Parse function that takes care of expanding vars while parsing the DEPS file. It wraps Exec and exec calls, and supports deferring the expansion until later, so gclient flatten gets access to the unexpanded version. Bug: 821199 Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2 Reviewed-on: https://chromium-review.googlesource.com/973749 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Robert Iannucci authored
To make sure that the following CL actually rolls into downstream recipes: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/961865 TBR=nodir@chromium.org, vadimsh@chromium.org Bug: 821669 Change-Id: Ia530a619e355291a15d849e09c449fc82e31534b Reviewed-on: https://chromium-review.googlesource.com/976558Reviewed-by:
-
Robert Iannucci authored
Currently in LUCI `git cl` is invoked on chromium_presubmit using vpython. This means that it operates under the depot_tools .vpython environment (which is blank). Some features in presubmit_support allow invocation of python subprocesses, and previously they would use `sys.executable` (especially on windows, but occasionally on non-windows as well). In non-vpython environments, this just picks up the system python and whatever modules happen to be installed there. Some python unittests work around this on non-windows systems by having a shebang line which explicitly invokes vpython. This CL changes presubmit_support so that invocations of 'python', or executions of '.py' scripts will always end up invoking vpython. In the best case, this will pick up the invoked scripts' vpython environment. In the worst case, this will invoke the script under an empty vpython environment (aka "stock python"). R=dpranke@chromium.org, jbudorick@chromium.org, tandrii@chromium.org, tikuta@chromium.org Bug: 821669 Change-Id: I5d2d5dfd0364022d56833c2c8af4983553a29c7a Reviewed-on: https://chromium-review.googlesource.com/961865Reviewed-by:
-
Edward Lesmes authored
Mimics bot_update's functionality to apply gerrit refs in gclient via --gerrit-ref flags. When the patch fails to apply, gclient sync will return exit code 2. The idea is to move this logic from bot_update to gclient sync to deal when patches for projects like ANGLE are tried on Chromium bots. This way the patch is applied before recursively parsing and syncing ANGLE’s DEPS.chromium file, which doesn't currently happen. Bug: 643346 Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18 Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by:
-
Lei Zhang authored
This reverts commit 33bf4953. Reason for revert: Done debugging. Original change's description: > Add debugging info when gclient deletes an old DEPS entry. > > To help figure out why it decided to do so. > > BUG=823586 > > Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6 > Reviewed-on: https://chromium-review.googlesource.com/970082 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=thestig@chromium.org,agable@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823586 Change-Id: I476cbe423b849582f8684426653f0c08062e89e9 Reviewed-on: https://chromium-review.googlesource.com/974458Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
-
- 21 Mar, 2018 4 commits
-
-
Edward Lesmes authored
Since we only support Var, and Var only does one thing, we hard code that into the parser. Then, we don't need global_scope. local_scope hasn't been needed for a while. Bug: 760633 Change-Id: I21b171a8b71e7dcaf8e29c780ca88b9f46f368e8 Reviewed-on: https://chromium-review.googlesource.com/972611Reviewed-by:
-
Andrii Shyshkalov authored
The main purpose is to avoid running slow and useless operation in chromium/src checkouts. Ideally, this should be done in every DEPS-ed repo, too, but that requires substantially more changes in gclient. Thus, this CL provides biggest bang for the buck. Example led build: https://ci.chromium.org/swarming/task/3c62efb31ed3a910?server=chromium-swarm.appspot.com R=hinoka@chromium.org Bug: 822437 Change-Id: I347d85e5cb5158b77969a755b67ca2289fb39d40 Reviewed-on: https://chromium-review.googlesource.com/973900 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org>
-
Sergiy Byelozyorov authored
R=tandrii@chromium.org Change-Id: Id4fa494c8225c8edefecba064445504065581478 Reviewed-on: https://chromium-review.googlesource.com/966564 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org>
-
Sergiy Byelozyorov authored
This also parallelises get_changes, get_issues and get_reviews. R=tandrii@chromium.org Change-Id: I8ebc69fc6e59637ec576057abf1d9068a340b71a Reviewed-on: https://chromium-review.googlesource.com/966563 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
