Commits · d5c7b7adbd6fa011efa03a716f0963a55f630230 · Linshizhi / Chromium_Depot_tools

13 Jul, 2016 4 commits

Roll recipe dependencies (trivial). · d5c7b7ad

recipe-roller authored Jul 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3de962bcccb8eac10810d7247618c5c9089b8fe7 shutil.rmtree: transition everything to new implementation. (tandrii@chromium.org)

R=phajdan.jr@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=584783

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2148793002

d5c7b7ad

git cl try: Trigger CQ Dry Run by default. · 9de9ec66

tandrii authored Jul 13, 2016

If bots are specified manually on command line OR in PRESUBMIT.py,
then old behavior remains, namely triggering just those bots.

Otherwise, git cl try will now trigger CQ Dry Run. This is a good
default and also resolves several bugs:

 * https://crbug.com/581150 where git cl try used to load cq.cfg
   from infra/config, but that's not always correct for all projects.

 * https://crbug.com/625697 where even if cq.cfg is in default location.
   it might be outdated.

 * https://crbug.com/585237 where git cl try would ignore special
   in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ,
   but not git cl try.

BUG=625697,585237,581150
R=sergiyb@chromium.org,emso@chromium.org

Review-Url: https://codereview.chromium.org/2147563003

9de9ec66

Fix git cl set-commit --clear. · d9e5ce51

tandrii authored Jul 13, 2016

  aka sergiyb@ was right.

R=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2141283002

d9e5ce51

Roll recipe dependencies (trivial). · 83e44427

recipe-roller authored Jul 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6bf9ca763de94c641328900358642ec44cf3932e Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143373002

83e44427

12 Jul, 2016 10 commits

Roll recipe dependencies (trivial). · 25f1dc30

recipe-roller authored Jul 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2b31483ac5f58781c138af391a35ccf3a3f63245 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org)

R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2135383006

25f1dc30

Roll recipe dependencies (trivial). · c290ab04

recipe-roller authored Jul 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c3683107b331a0f9f0392c0a376ecf8143b1e2ac Revert of shutil recipe_module: port chromium_utils rmtree implementation. (patchset #2 id:20001 of https://codereview.chromium.org/2146523003/ ) (tandrii@chromium.org)

R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2147703002

c290ab04

Roll recipe dependencies (trivial). · 4b996720

recipe-roller authored Jul 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/774c69370e740a8a5c85dce90f88a2bbd11911f5 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org)

R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2148493002

4b996720

Gerrit CQ will not allow customization of CQ label values. · 6b410ec4
tandrii authored Jul 12, 2016
```
R=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2135313005
```
6b410ec4

Roll recipe dependencies (trivial). · a406fc88

recipe-roller authored Jul 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6ce1c413a63efd635af9cac02d21f52228c97bd Make Step API support type long in commands (borenet@chromium.org)

R=borenet@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2147623003

a406fc88

git cl upload: remove no longer aplicable message. · 2bdadf1e
tandrii authored Jul 12, 2016
```
R=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2143693002
```
2bdadf1e

Fix CQ.cfg for Gerrit. · 45f10aec

tandrii authored Jul 12, 2016

Follow up of https://codereview.chromium.org/2144723002.

BUG=627540
TBR=andybons@chromium.org

Review-Url: https://codereview.chromium.org/2139603004

45f10aec

Enable Gerrit CQ on depot_tools project. · 875a0123

tandrii authored Jul 12, 2016

TBR=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2144723002

875a0123

tryserver: make it possible to override cwd for get_files_affected_by_patch · 27726869
phajdan.jr authored Jul 12, 2016
```
BUG=584079, 593999

Review-Url: https://codereview.chromium.org/2144473003
```
27726869

Roll recipe dependencies (trivial). · 00c2cdbf

recipe-roller authored Jul 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ce485a8a394dcc1561b5ecdd337a85002083de5b Fix bootstrap on windows (martiniss@chromium.org)
  https://crrev.com/ba76686b6729174d9b7c7900ada4946ea5329632 Revert of Fix bootstrap on windows (patchset #2 id:20001 of https://codereview.chromium.org/2136303002/ ) (martiniss@chromium.org)

R=dnj@chromium.org,martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2138293002

00c2cdbf

11 Jul, 2016 2 commits

Roll recipe dependencies (trivial). · 8cd13991

recipe-roller authored Jul 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0a6ab680699355151bf3387074f4656c48698d72 Fix bootstrap cwd (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2137253002

8cd13991

Manually roll recipes.cfg recipe_engine 2c5509f:9d78ba3 · b2580abf

phajdan.jr authored Jul 11, 2016

TBR=estaab, iannucci, martiniss

BUG=chromium:593999

Review-Url: https://codereview.chromium.org/2132363002

b2580abf

08 Jul, 2016 4 commits

Roll recipe dependencies (trivial). · dee56dd7

recipe-roller authored Jul 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2c5509f0c2cd87af90844ed597d9aaa108194943 Fix pylint warnings (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2131183002

dee56dd7

update recipe bootstrap script (2c5509f) · 90b9f5f4
phajdan.jr authored Jul 08, 2016
```
BUG=chromium:618127

Review-Url: https://codereview.chromium.org/2131153002
```
90b9f5f4

Roll recipe dependencies (trivial). · 6874ac10

recipe-roller authored Jul 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/02034be07bc11acb23994feb2ce3a40d94782d5d Retry all errors in recipe bootstrap script (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:618127

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2136483002

6874ac10

Roll recipe dependencies (trivial). · d914e91a

recipe-roller authored Jul 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ab4c628b8432cb3d3dbcee32a539f486115a329b Retry errors during fetch (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:618127

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2135563002

d914e91a

07 Jul, 2016 2 commits

Added '.m' pattern to git cl format files to be covered. · bf47014c
zengster authored Jul 07, 2016
```
BUG=

Review-Url: https://codereview.chromium.org/2123283005
```
bf47014c

Roll recipe dependencies (trivial). · c55ba20c

recipe-roller authored Jul 07, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5f18b96cc381e6c9df75bab13cdb99004e8b6779 Add recipe developer workflow doc. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=584182

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2131443002

c55ba20c

06 Jul, 2016 2 commits

Implement git cl upload --dry-run or --use-commit-queue for Gerrit. · 4d0545a4

tandrii authored Jul 06, 2016

Previously, it only worked for Rietveld.

BUG=622828
R=emso@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2117183004

4d0545a4

Implement git cl set-commit --dry-run for Rietveld. · 4b233bdb

tandrii authored Jul 06, 2016

BUG=622828
R=emso@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2127633003

4b233bdb

05 Jul, 2016 1 commit
- Report keyboard interrupt as abnormal (infra) failure · f8a3b38c
  sergiyb authored Jul 05, 2016
```
R=tandrii@chromium.org
BUG=579589

Review-Url: https://codereview.chromium.org/2125713002
```
  f8a3b38c
04 Jul, 2016 1 commit

remove blink_or_chromium gclient config · 7dba71bf

phajdan.jr authored Jul 04, 2016

It's not needed after blink merge.

TBR=emso, sergiyb, tandrii

BUG=none

Review-Url: https://codereview.chromium.org/2117063002

7dba71bf

01 Jul, 2016 1 commit

Implement git cl upload -b BUG --bug=BUG. · f9aefb77

tandrii authored Jul 01, 2016

CC=friedman@chromium.org
R=sergiyb@chromium.org
BUG=500658

Review-Url: https://codereview.chromium.org/2117483002

f9aefb77

30 Jun, 2016 4 commits

Roll recipe dependencies (trivial). · 70c04847

recipe-roller authored Jun 30, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/97de2622765bdf58b51b827f9e9ba07b19e0a1e2 Fix raw_io input placeholders not using unicode. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2115603003

70c04847

Roll recipe dependencies (trivial). · 44118b11

recipe-roller authored Jun 30, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/52e644c188ec824afb9ca763ffd6c11d2ff9db60 Add expanduser to path recipe module. (bpastene@chromium.org)

R=bpastene@chromium.org
BUG=624502

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2112883003

44118b11

Allow git_cl to be called when no default server is given · 6eda05f9
martiniss authored Jun 30, 2016
```
Review-Url: https://codereview.chromium.org/2109253002
```
6eda05f9
Remove old compatibility for git_cl_upload branches. · d0b10a0b
tandrii authored Jun 30, 2016
```
R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2116493002
```
d0b10a0b

29 Jun, 2016 4 commits

Do not remove issue from branch after it is landed manually · 2546dcc0

sergiyb authored Jun 29, 2016

This is consistent with the way CQ works. Also git-cl-archive won't work if
branch looses info about its matching CL.

R=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2111543002

2546dcc0

Roll recipe dependencies (trivial). · ced6ad93

recipe-roller authored Jun 29, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7efa94d613f430f85af7f8c8364f85319ee9fa94 Make it possible to use 'cwd' in api.step.context (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:593999,chromium:585401

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2112533002

ced6ad93

infra_paths: keep cache paths super short to avoid long path issues (attempt #2) · 4f00aa0b

phajdan.jr authored Jun 29, 2016

This is a reland of https://codereview.chromium.org/2102613002/ .

See https://goto.google.com/ljfzu (Google-internal) for more context. Summary:
- the only builders with chromium checkout affected by this are on chromium.fyi
- we can't clean up old cache directories before switching to new ones

Also see https://goto.google.com/oyxwm why so short directory names are OK.
Similarly https://codereview.chromium.org/2061213002 .

BUG=623575

Review-Url: https://codereview.chromium.org/2102403002

4f00aa0b

bot_update: Allow patch_oauth2 to work in kitchen · 575e6766

martiniss authored Jun 29, 2016

site config is not present on builders which use kitchen, so we need to use credentials provided by puppet in the /creds directory.

BUG=624212
TBR=hinoka

Review-Url: https://codereview.chromium.org/2108073002

575e6766

28 Jun, 2016 5 commits

Switch gclient config to default to unmanaged mode. · d4aedc81
agable authored Jun 28, 2016
```
BUG=339055
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2099153003
```
d4aedc81

Add upload and issue to git_cl recipe module · 808d7ea4

martiniss authored Jun 28, 2016

Depends on https://codereview.chromium.org/2088343002

Review-Url: https://codereview.chromium.org/2087093002

808d7ea4

Slight fix for gclient readability · 8c51b6f1
agable authored Jun 28, 2016
```
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2103663004
```
8c51b6f1

Restore --head/-H to gclient · 2697cd19

agable authored Jun 28, 2016

R=dmazzoni@chromium.org, maruel@chromium.org
BUG=109184

Review-Url: https://codereview.chromium.org/2105493002

2697cd19

Roll recipe dependencies (trivial). · 42cb56e1

recipe-roller authored Jun 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/94866be976d923ef7647641cec47baf345962c15 Add logging to recipe bootstrap script (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:618127

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2104853003

42cb56e1