- 06 Aug, 2019 2 commits
-
-
Edward Lemur authored
This is a reland of 3a98df0b Original change's description: > depot_tools: Move six to depot_tools' .vpython > > Bug: 984182 > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> Bug: 984182 Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5d464559eb518abe977bcccf2c5d95b6c76b0cc8 Output the command one argument per line in execution details. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I08a98f6d15eeae0ae063039b0651f21d12f43c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739570Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 05 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d4f1140c8ec95a5fd04ada8bb8a87aa2e9b6e98e Account for raw_io output backing file not existing when reading it. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I58f0d9387b1c9a2e49d97ae0819d85e11260d6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1737467Reviewed-by:
-
Mike Frysinger authored
This is mostly for Python 3 improvements. Bug: gerrit:10418 Change-Id: Ice96b8dc5f700015ae6ec53c0e5b86700bcf6532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1734587 Auto-Submit: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Alex Klein <saklein@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 03 Aug, 2019 1 commit
-
-
Edward Lemur authored
Bug: 984182 Change-Id: I5d1b5626eb799975539560ca1508af92df326d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1721916 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 01 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/218f005d8f06d6e223cecd87864545b51c544884 [internal/engine] Restore conditional print for negative error codes. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9231df76c4d9eeaa984a83ca74b5e9272566c7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1731978Reviewed-by:
-
Edward Lemur authored
- Merge CheckCallAndFilter[AndHeader] - print_stdout will cause command output to be redirected to sys.stdout. - Made compatible with Python 3. Bug: 984182 Change-Id: Ida30e295b872c8c1a1474a376a90aecea924f307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1727404 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 31 Jul, 2019 2 commits
-
-
smut authored
Newer builds of vpython contain vpython3 as well. Bug: 898348 Change-Id: I63b197690e2ae47bd4c6cd50894c4769e1a18334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1727581Reviewed-by:
-
Edward Lemur authored
- appengine_mapper.py - checkout.py - patch.py - testing_support/gerrit_test_case.py - testing_support/patches_data.py - tests/checkout_test.py - tests/patch_test.py Bug: 984182 Change-Id: I2d1ccb1dc41d7034f63043aa87bca3bca4e18294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1727401Reviewed-by:
-
- 29 Jul, 2019 2 commits
-
-
Edward Lesmes authored
This reverts commit 602076dc. Reason for revert: It fails on input 0xe2 0x9c 0x94 which is a utf-8 heavy check mark. Problem is that CheckCallAndFilter is processing output byte by byte, so trying to decode only one of utf-8 bytes in sequence will always fail. Original change's description: > depot_tools: Make gclient_utils Python 3 compatible. > > Bug: 984182 > Change-Id: Ifb93466dcb7541f46c31c9b298049c425dd150d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1715472 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 984182 Change-Id: Ieae421acc430a031621db3329223c1da85506e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1724730Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Tamer Tas authored
{_resolve_fixed_revisions} resolves every revision property. After a test failure, we don't want to resolve every revision always. This CL allows updating a subset of revisions for a new checkout. R=machenbach@chromium.org TBR=tandrii@chromium.org Bug: 950731, 982711 Change-Id: I3cdc5cdb882009886b82557427fdf9b02e860b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1720929 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:Michael Achenbach <machenbach@chromium.org>
-
- 27 Jul, 2019 3 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: Ia413435af80d03dcfa01bb2ab7480cd6a37b4161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717496Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 984182 Change-Id: I9485614658efa0ea9d50ea666210af63c3b97adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1716131Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Ifb93466dcb7541f46c31c9b298049c425dd150d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1715472Reviewed-by:
-
- 26 Jul, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/39c2db1744c62991c56348ba14b127bfa009925d Look for path components for mock paths rather than just a string prefix. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7e9b07036b8d2c7828dde6ce20dd48a236a2deb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1721177Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/11077013dc5ac1cf8fa7971965046b0e67c0dd5f [swarming] Make TaskResult.output_dir a Path (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I22223285a1ca55b61bac72a811170b23981eced4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1719956Reviewed-by:
-
- 25 Jul, 2019 3 commits
-
-
Edward Lesmes authored
This reverts commit 3a98df0b. Reason for revert: Can't roll into skia and build_internal Original change's description: > depot_tools: Move six to depot_tools' .vpython > > Bug: 984182 > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: I51e502e6f7633a6f26898f1ecbcd86ccf9c7c123 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1718996Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: I34a242c8607624beb0f06a27c563e413dec99790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
Quinten Yearsley authored
Change-Id: I5195762d493e3c00d1656004fb2e800524ee9637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710950Reviewed-by:
-
- 24 Jul, 2019 1 commit
-
-
Edward Lemur authored
Bug: 984182 Change-Id: Ib28cec16883bb5269453c27c74d8124fbfba8920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717248Reviewed-by:
-
- 22 Jul, 2019 4 commits
-
-
Quinten Yearsley authored
Change-Id: I6a4bbd300e8343671c9d595844de2c6ab24a00d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710941 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
-
Edward Lemur authored
Change-Id: Iee0b783d725f15fbe3ab3d41ce2303a2ab1807af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713218Reviewed-by:
Andy Perelson <ajp@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 984182 Change-Id: I55e9e83d01d5a86464cc234c083e4212f0ba4a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713217 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Robert Iannucci authored
I was the only one left :) TBR=ehmaldonado@chromium.org Change-Id: I66893b6de9231e09ef3a10cf0b02c8836d1ad012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713221Reviewed-by:
-
- 20 Jul, 2019 1 commit
-
-
Edward Lemur authored
Bug: 984182 Change-Id: Ia85f9bdb88b343776540556921890bc3ea73f2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710957Reviewed-by:
-
- 19 Jul, 2019 2 commits
-
-
Quinten Yearsley authored
Change-Id: Ief9948f5331945359696de8e158af021a6ade7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1709804Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/bf2840613e4e2be9581a36c7f4e4a0cf14695578 Remove final jsonResult reference (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id64a7623e57aecf2beb34ae00ba9d41d273c28ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710953Reviewed-by:
-
- 18 Jul, 2019 2 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: I0ad2f612f681644b78353195e451e43da936ac9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1709640 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/da55db0ed58e23a8a3ee76fd3f1d4aa95a9db0c8 [commands/test] Use "." instead of checkmark for success, even with emoji. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iee2884132938cfb759d59d27d7da03821364d095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1708153Reviewed-by:
-
- 16 Jul, 2019 7 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: I2b7e4be6131558019d461e09d062b52085f330ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702855Reviewed-by:
-
Edward Lemur authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702495 It is used by my_activity.py (via rietveld) Bug: 984745, 984182 Change-Id: Ic9a3e59a2ffb4b500666f9ad2ee076c8bb81a3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1703390Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/44c14e31274e6d1c84cad9bc0df608fbdf03e575 Clean up the read hack, which is now immortalized forever. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id7a259823a505aff80827472dbd22dc778570371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1704657Reviewed-by:
-
Debrian Figueroa authored
Changed all headers in message to be the size of header 4 tags. Made sure there is always a new line after code tag(```). Change-Id: I772941a8bbf0634c9496ec648533110997e23cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702293 Commit-Queue: Debrian Figueroa <debrian@google.com> Reviewed-by:
-
Raul Tambre authored
The unicode type doesn't exist in Python 3, because everything's Unicode. This would resulted in the following error on Python 3: <Unicode console <stderr>>.write: NameError("name 'unicode' is not defined") Bug: 942522 Change-Id: I3e90d078df64abcec2c79aa69881deea40ff7d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701401Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee>
-
Raul Tambre authored
In Python 3 the output of a subprocess is bytes, so they need to be decoded to be used as a string. This previously caused the following error if there was an existing checkout during a fetch: Traceback (most recent call last): File "C:\Google\depot_tools\\fetch.py", line 318, in <module> sys.exit(main()) File "C:\Google\depot_tools\\fetch.py", line 313, in main return run(options, spec, root) File "C:\Google\depot_tools\\fetch.py", line 299, in run if not options.force and checkout.exists(): File "C:\Google\depot_tools\\fetch.py", line 98, in exists return (os.path.exists(os.path.join(gclient_root, b'.gclient')) or File "C:\Program Files\Python38\lib\ntpath.py", line 109, in join genericpath._check_arg_types('join', path, *paths) File "C:\Program Files\Python38\lib\genericpath.py", line 151, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components Bug: 939847 Change-Id: Ibf5b4923268595ba439586d688894f92696ecbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701403 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by: -
Raul Tambre authored
This causes an error since Python 3.5 due to a regression (https://bugs.python.org/issue32745): Traceback (most recent call last): File "C:\Google\depot_tools\metrics.py", line 267, in print_notice_and_exit yield File "C:\Google\depot_tools\gclient.py", line 3153, in <module> sys.exit(main(sys.argv[1:])) File "C:\Google\depot_tools\gclient.py", line 3136, in main setup_color.init() File "C:\Google\depot_tools\setup_color.py", line 70, in init buf = ctypes.create_string_buffer('\0', 1024) File "C:\Program Files\Python38\lib\ctypes\__init__.py", line 63, in create_string_buffer raise TypeError(init) TypeError: <Unicode console <stderr>>.write: ArgumentError("argument 2: <class 'ValueError'>: embedded null character") Simply not filling the buffer with NULLs doesn't change the behaviour. Bug: 942522 Change-Id: I1feb81555e995597b0b70f4aee9151fea755510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701402 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
- 15 Jul, 2019 3 commits
-
-
Andrii Shyshkalov authored
CQ will soon start canceling tryjobs it triggered on no-longer-latest patchsets if these tryjobs won't be re-used. New option can be used by developers who upload new patchsets but actually care for prior CQ-triggered tryjobs to complete. This footer is effectively sticky, unless someone removes it by hand later. We need to have the footer one way or another to tell the CQ what to do (and provide a visible audit trail). We may revisit the stickiness later based on accumulated usage data s.t. the following uploads remove the footer unless the flag is passed. Bug: 909895 Test: git cl upload --preserve-tryjobs Change-Id: Ibbc6e917504c31eab8ab85296b3ecafd3add46df Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701506Reviewed-by:
-
Andrii Shyshkalov authored
Change-Id: If61260b1f4951d3c881fff46a0bde2dac47d593b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701503Reviewed-by:
-
Edward Lemur authored
Remove: - third_party/boto - third_party/fancy_urllib - third_party/protobuf26 - third_party/simplejson - third_party/upload.py Change-Id: I08488325f15ca04876fcff611eb766979299806b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702495Reviewed-by:
-
- 12 Jul, 2019 1 commit
-
-
Debrian Figueroa authored
Change-Id: I6f7b0791172f9f4e7af278f8acb3f1ca986789d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700390 Commit-Queue: Debrian Figueroa <debrian@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
