gclient_scm_test.py throws randomly gclient_utils.Error.
Simply update the test expectation. It has no effect on runtime.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7828024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99436 0039d316-1c4b-4281-b951-d872f2087c98

Verify correctness with a unit test written explicitly to verify all corner cases.

BUG=60725
TEST=new unit test

Review URL: http://codereview.chromium.org/6598087

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99234 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation to support file rename, as a source_filename needs to be
added and processed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7809001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99185 0039d316-1c4b-4281-b951-d872f2087c98

That means some properties will being to be applied.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98

Well, the funny thing is that it doesn't find the bug but the framework is
already good enough as-is to be worth checked-in, so the next commit can show
the relevant difference.

R=dpranke@chromium.org
BUG=60725
TEST=

Review URL: http://codereview.chromium.org/7773001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98869 0039d316-1c4b-4281-b951-d872f2087c98

Unit test follow in next CL.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7766005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98480 0039d316-1c4b-4281-b951-d872f2087c98

Still not enough to fix presubmit checks on commit queue but a step in the
right direction.
Review URL: http://codereview.chromium.org/7748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98445 0039d316-1c4b-4281-b951-d872f2087c98

It's mostly for debugging when testing with a leaking service. It's going to be
rarely used but I used it often enough to warrant it being committed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7744030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98438 0039d316-1c4b-4281-b951-d872f2087c98

(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Review URL: http://codereview.chromium.org/7747023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98421 0039d316-1c4b-4281-b951-d872f2087c98

---

Trap failure to get password from keyring

It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7715013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7709021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=run it
Review URL: http://codereview.chromium.org/7605017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@96223 0039d316-1c4b-4281-b951-d872f2087c98

* Add a new version of the chromite wrapper as chromite_wrapper
* Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it

TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot
Review URL: http://codereview.chromium.org/7484062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94011 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7493050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94004 0039d316-1c4b-4281-b951-d872f2087c98

This prevents bots waiting 20 minutes and failing the update step.
Review URL: http://codereview.chromium.org/7492019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93678 0039d316-1c4b-4281-b951-d872f2087c98

Chromium's presubmit check assumes the author is an email address.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7484002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7488015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=

Review URL: http://codereview.chromium.org/7277035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93611 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93451 0039d316-1c4b-4281-b951-d872f2087c98

It result in less code, forces uploading the change for eventual review and most
importantly enables the commit queue to correctly handle this.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7253015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98

This may include Makefile but it's saner to not include it by default

R=dpranke@chromium.org
BUG=
TEST=updated

Review URL: http://codereview.chromium.org/7251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@90403 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7215025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89884 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Rewrote the unit test to catch that case.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89700 0039d316-1c4b-4281-b951-d872f2087c98

Improve the list of exception to include very_long_symbol_names.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7097012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89696 0039d316-1c4b-4281-b951-d872f2087c98

See related repo change:
  https://review.source.android.com/#change,22722

Review URL: http://codereview.chromium.org/7111045
Patch from Doug Anderson <dianders@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89361 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7178001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89268 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7172033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89261 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7172014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89208 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7111049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89036 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors the git-cl changes by first moving git-try
to git_try.py (which git cl already had), then copying
git-cl to git-try and updating all references to git-cl
and git_cl.py to the corresponding git try references.

The main issue is that in the MINGW/Msysgit case we want
to use the Python in depot_tools since that is 100%
compatible with the Command Prompt.  Hence we need
to call it directly and then pass it the name of the
git_try.py script.

Note that 'git-try' will not (ever) work on Windows,
and users should only ever run 'git try'.  Hence the
need to modify the output of the command to avoid
further confusion.
Review URL: http://codereview.chromium.org/7114002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98

It was broken in 88979. Someone my limited testing missed that.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7147016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88987 0039d316-1c4b-4281-b951-d872f2087c98

This will be used in commit queue tests.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7046110

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88986 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Add PanProjectChecks unittest, there was none.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7104141

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88982 0039d316-1c4b-4281-b951-d872f2087c98

Properly load --contributor value or use the git config user.email value.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7134097

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88979 0039d316-1c4b-4281-b951-d872f2087c98

'Cause linux2 is so last decade.

TBR=evan@chromium.org
BUG=85845
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88788 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
TEST=few
BUG=

Review URL: http://codereview.chromium.org/6995115

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88779 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7044090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88777 0039d316-1c4b-4281-b951-d872f2087c98

R=evan@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7129059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7024021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88160 0039d316-1c4b-4281-b951-d872f2087c98