The fallback code was parsing DEPS entries improperly.

BUG=None

Review URL: https://codereview.chromium.org/1699333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298839 0039d316-1c4b-4281-b951-d872f2087c98

With this change, fix_encoding can be imported in python3.
fix_encoding.fix_encoding() returns False because, at least on my Ubuntu 14.04
system running python 3.4.3;

  sys.getdefaultencoding() == 'utf-8'

The Windows specific code hasn't been tested on python3 and is expected to
require fixes.

R=vapier@chromium.org
BUG=61357

Review URL: https://codereview.chromium.org/1710553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298834 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Separating change into smaller changes.

Original issue's description:
> Bot update cleanup
> 
> * Remove activation check
> * Remove messages
> * Remove deps2git
> * Remove build_internal pointer by:
> ** Moving chrome svn url into bot_update.py (This isn't secret anyways.)
> ** Move patch.exe into depot_tools (No reason this should've been internal...)
> ** Default everything to active, so no need for checks anyways.
> 
> BUG=
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298809

TBR=martiniss@chromium.org,eseidel@chromium.org,estaab@chromium.org,iannucci@chromium.org,hinoka@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review URL: https://codereview.chromium.org/1706893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298826 0039d316-1c4b-4281-b951-d872f2087c98

* Remove activation check
* Remove messages
* Remove deps2git
* Remove build_internal pointer by:
** Moving chrome svn url into bot_update.py (This isn't secret anyways.)
** Move patch.exe into depot_tools (No reason this should've been internal...)
** Default everything to active, so no need for checks anyways.

BUG=

Review URL: https://codereview.chromium.org/1686273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298809 0039d316-1c4b-4281-b951-d872f2087c98

From infra_internal, revisions 6f979a..cd0150f.

TBR=sergiyb@chromium.org,machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1697053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298789 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1699803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298787 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1701453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298781 0039d316-1c4b-4281-b951-d872f2087c98

R=dnj@chromium.org, hinoka@chromium.org, luqui@chromium.org, martiniss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1693993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298774 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1692063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298750 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@chromium.org,andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1692513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298733 0039d316-1c4b-4281-b951-d872f2087c98

Reland of http://crrev.com/1689633002#ps20001 without breaking other
repos by means of keeping breakpad.py importable, but otherwise a no-op.

R=maruel@chromium.org
BUG=585837

Review URL: https://codereview.chromium.org/1687923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298731 0039d316-1c4b-4281-b951-d872f2087c98

This will hopefully make Rietveld._send retry 500s like it promises to

BUG=585632

Review URL: https://codereview.chromium.org/1681333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298726 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org, sebmarchand@chromium.org
BUG=495204,585829

Review URL: https://codereview.chromium.org/1689723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298720 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Finally get rid of depot_tools' breakpad. (patchset #2 id:20001 of https://codereview.chromium.org/1689633002/ )

Reason for revert:
All chromium bots depend on this: 

________ running '/usr/bin/python src/build/android/play_services/update.py download' in '/b/build/slave/linux/build'
Traceback (most recent call last):
  File "src/build/android/play_services/update.py", line 29, in <module>
    import find_depot_tools  # pylint: disable=import-error,unused-import
  File "/b/build/slave/linux/build/src/build/find_depot_tools.py", line 49, in <module>
    import breakpad
ImportError: No module named breakpad

https://www.google.com/url?hl=en&q=http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144739&source=gmail&ust=1455209366639000&usg=AFQjCNH42SEVcJg4J6dX0J9HF0Rcqv81eA

Original issue's description:
> Finally get rid of depot_tools' breakpad.
> 
> R=maruel@chromium.org
> BUG=
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298710

TBR=maruel@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1683173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298712 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1689633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=585632
TBR=agable

Review URL: https://codereview.chromium.org/1686753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298693 0039d316-1c4b-4281-b951-d872f2087c98

This will hopefully make Rietveld._send retry 500s like it promises to

BUG=

Review URL: https://codereview.chromium.org/1683603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298688 0039d316-1c4b-4281-b951-d872f2087c98

rogerta@ has indicated that he should no longer be an owner of
depot_tools.

Review URL: https://codereview.chromium.org/1673313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298683 0039d316-1c4b-4281-b951-d872f2087c98

The vs_files directory is used for VS 2015 builds and needs to be in
.gitignore, along with vs2013_files.

The naming convention for timestamps is changed and .gitignore needs to
be updated for that.

Finally, the .pylint.d directory keeps being created and should be
ignored.

Review URL: https://codereview.chromium.org/1667853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1661043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298654 0039d316-1c4b-4281-b951-d872f2087c98

The UCRT is now optional and it failed to install on one builder.
Making optional to fix build break

If this doesn't fix the break on the waterfall then the switch
to VS 2015 will need to be reverted (crrev.com/1598493004).

TBR=scottmg@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1680433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298634 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1675863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298631 0039d316-1c4b-4281-b951-d872f2087c98

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689

Review URL: https://codereview.chromium.org/1673543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298622 0039d316-1c4b-4281-b951-d872f2087c98

Always formats full GN files that are modified since the format should
be canonical.

I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.

TEST=Works running locally.
BUG=

Review URL: https://codereview.chromium.org/1666403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1676473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1673603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298612 0039d316-1c4b-4281-b951-d872f2087c98

Previously, when a commit was skipped, it would be blamed on the line
number the line had *after* the skipped commit. This could mean a
totally unrelated commit gets blamed. Now, a heuristic analyses the diff
of the skipped commit to discover approximately what line number the
line had *before* the skipped commit, so it can hopefully be blamed on
the right commit.

BUG=574290

Review URL: https://codereview.chromium.org/1629253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=584197

Review URL: https://codereview.chromium.org/1665233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298599 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1666313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298598 0039d316-1c4b-4281-b951-d872f2087c98

Right now I get

Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...

which isn't very informative (or at least a bit confusing as to why it's
doing the same thing 6 times).

R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1671433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=584197

Review URL: https://codereview.chromium.org/1668803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/1670503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298586 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the option to use the current issue number, if any,
when doing a git cl patch. Instead of doing git cl issue (copy the
number) git cl patch <number>, one can simply do git cl patch -i

BUG=

Review URL: https://codereview.chromium.org/1641903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=440500

Review URL: https://codereview.chromium.org/1663753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298580 0039d316-1c4b-4281-b951-d872f2087c98

Gerrit doesn’t support patch titles.

BUG=579178

Review URL: https://codereview.chromium.org/1659633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298573 0039d316-1c4b-4281-b951-d872f2087c98

Original attempt: https://codereview.chromium.org/1660943002

Now adds depot_tools at the end of PATH to avoid issues with python
on Windows.

TBR=jochen

BUG=437264

Review URL: https://codereview.chromium.org/1661953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298562 0039d316-1c4b-4281-b951-d872f2087c98

Revert of bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (patchset #1 id:1 of https://codereview.chromium.org/1660943002/ )

Reason for revert:
I believe this breaks trybot patching on Windows. 

Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811

Error: 
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command,
operable program or batch file.

I'm speculatively reverting.

Original issue's description:
> bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
> 
> BUG=437264
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556

TBR=jochen@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437264

Review URL: https://codereview.chromium.org/1662763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1634923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1660943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298556 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1660403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298554 0039d316-1c4b-4281-b951-d872f2087c98