Commits · d3a987159d00ffb6c7854342777213abf67654d2 · Linshizhi / Chromium_Depot_tools

10 Jun, 2021 2 commits

Roll out new goma client binary VERSION=223 · d3a98715

Fumitoshi Ukai authored Jun 10, 2021

Bug: b/190141502
Change-Id: I6c5074a2d91082fee398e80e6fd1682e07997dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2950609Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

d3a98715

Roll recipe dependencies (trivial). · 415b1142

recipe-roller authored Jun 10, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7dd172078b903b9a3639400d449d34478591deec
  7dd1720 (chanli@chromium.org)
      [resultdb] support exonerate_unexpected_pass

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieef8f3f630d9df87105fa53491ee90da5d5e017a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2952065
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

415b1142

09 Jun, 2021 4 commits

[py3] Decode stdout in presubmit runs · b4a7cffc

Josip Sokcevic authored Jun 09, 2021

Bug: 1215375
Change-Id: I068801f5e7482cf13cf70dd6c3a70c39f22a39f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2949974
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

b4a7cffc

Use py3 with gerrit_client.py · 84434e84

Josip Sokcevic authored Jun 09, 2021

R=ehmaldonado@chromium.org

Change-Id: I93a4c20121010e8644982aa7910ff41884734f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2949972
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

84434e84

ninjalog_uploader: ignore http.client.RemoteDisconnected · 4bb3a7d0

Takuto Ikuta authored Jun 09, 2021

Bug: b/190562569
Change-Id: Iaa8d119ad643e64bdf231fe5ae43ea4daa69996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947272
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>

4bb3a7d0

Roll recipe dependencies (trivial). · b14cdaeb

recipe-roller authored Jun 09, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c939f7671241f0841d03c507d7fadb09bef73f61
c939f76 (bpastene@chromium.org)
swarming: Allow resultdb_info to be optionally excluded in tests.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01e00af3920fcd91124423ce284ddf99cdce0e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2948201
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b14cdaeb

08 Jun, 2021 4 commits

Use input_api.sys instead of import sys · 104ca4d0

Josip Sokcevic authored Jun 08, 2021

Follow up on https://crrev.com/c/2929386

R=dpranke@google.com

Change-Id: Id977cfae561ecfb231372348387b084e098e6747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947981
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

104ca4d0

Roll depot_tools bleeding edge python versions. · b9236628

Brian Ryner authored Jun 08, 2021

This contains
https://chromium-review.googlesource.com/c/infra/infra/+/2943752 , a
stability fix for Mac (and potential startup performance improvement).

Bug: 1215121
Change-Id: Ifac20c066d7c6527574e9a128e4f5d60774824b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2944646
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

b9236628

[py3] Return list of strings in GitChange.AllFiles · 0b12346b

Josip Sokcevic authored Jun 08, 2021

Currently, GitChange.AllFiles returns a list of byte[]. This is
inconsistent with py2 and may cause issues when byte[] is used when
string is expected.

Change-Id: I3e73bc5f71aa787f55357b8139cdeeabee056047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946934
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

0b12346b

Roll recipe dependencies (trivial). · 680e077e

recipe-roller authored Jun 08, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/1b52b3c87b8ae1d93690a037fa362d27458e88d5
  1b52b3c (olivernewman@google.com)
      [file] Handle EnvironmentError with errno=None

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48c561b77eee78cf5f875621efb373179afd0222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947004
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

680e077e

07 Jun, 2021 3 commits

bot_update: Initialize synced_solutions before syncing. · b508ecd9

Edward Lesmes authored Jun 07, 2021

If sync fails, synced_solutions is not initialized, resulting in a
use-before-init error.

Bug: 1217352
Change-Id: I2367d0f8030faa571b5c2743d5d97aa4c0329a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2945663Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b508ecd9

Roll recipe dependencies (trivial). · 730b974e

recipe-roller authored Jun 07, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e2aec9bad49cba0b868dfc9c112c8360dbb0d437
  e2aec9b (yiwzhang@google.com)
      raw_io: fix the format of code block in raw_io doc

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I565df8639f03c4a3e5784fba4f987615bec97f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2945657
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

730b974e

recipes.cfg: update all branches to main · 965c544f

Josip Sokcevic authored Jun 07, 2021

All repositories have main branch and it's default branch

R=ehmaldonado@chromium.org

Change-Id: I1206574901124012254948095c5a3450b8449517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939020
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

965c544f

04 Jun, 2021 7 commits

Roll recipe dependencies (trivial). · a5b6b2f8

recipe-roller authored Jun 04, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9ab7500f8445230c5ad638838546c8281c4eee45
  9ab7500 (ihuh@google.com)
      [swarming] Fix cas_instance key name in cas_output_root.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I960ee0ac8bd5ddfb86b301d47f790e05a99cabba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941922
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a5b6b2f8

Roll recipe dependencies (trivial). · 3ba11d96

recipe-roller authored Jun 04, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f3a6a12aa6899544d8f16986e16a228fe3ca4c7d
  f3a6a12 (yuanjunh@google.com)
      [python3] Generate vpython3 compatible scripts in the bundle co...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2cce76fc73a025b5b3c84b122f0dbbd33c43c2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941672
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3ba11d96

Fix gclient_utils.FileRead() behavior for both 2 and 3. · 8b3bc259

Josip Sokcevic authored Jun 04, 2021

We always want gclient_utils.FileRead() to return a text
string these days, but the existing code didn't work
right for Python2 if you called it explicitly with mode='r'.

R=ehmaldonado@chromium.org

Bug: 1210746
Change-Id: If540746f31308b671f9101334b5cd9848a7e9257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2930626Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

8b3bc259

Fix GetPylint with USE_PYTHON3=True · a0b0f128

Dan Harrington authored Jun 04, 2021

kwargs['stdin'] is passed in to subprocess communicate(), which
expects bytes, not str.

Bug: 1215602
Change-Id: I95326eed08cffecd31abc6b0380de2a3c2ff3dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2929386Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dan H <harringtond@chromium.org>

a0b0f128

Roll recipe dependencies (trivial). · 93c73563

recipe-roller authored Jun 04, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2f91f3e786ddd6e5a582d475cfa9691532f26215
  2f91f3e (ihuh@google.com)
      [cas][swarming] Display CAS URL.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2547fb8a349b81df06c18bc4ef6b39094a066f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939011
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

93c73563

Revert "Roll out new goma client binary VERSION=222" · 88910921

Fumitoshi Ukai authored Jun 04, 2021

This reverts commit 681604eb.

Reason for revert: 
performance regression on windows.

Original change's description:
> Roll out new goma client binary VERSION=222
>
> Bug: b/189050323
> Change-Id: I003e38d71a9b40db7f4c0fcf43543205dd8da454
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939942
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>

Bug: b/189050323
Change-Id: I5f323ad15294a56c8884c4b5f9f1b9c40689c452
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939618
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

88910921

Roll out new goma client binary VERSION=222 · 681604eb

Fumitoshi Ukai authored Jun 04, 2021

Bug: b/189050323
Change-Id: I003e38d71a9b40db7f4c0fcf43543205dd8da454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939942Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

681604eb

03 Jun, 2021 5 commits

bot_update: Add experiment to avoid fetching if checked out revision is recent enough. · 9705687c

Edward Lesmes authored Jun 03, 2021

If checked-out revision is less than 6 hours old, skip fetching latest
revision.

Bug: 1199853
Change-Id: Ifd2a61055de286fe6fd94a5d43f80a1885a6931c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911015Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9705687c

Roll recipe dependencies (trivial). · 47080275

recipe-roller authored Jun 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ac7e7183a25bd2085ab205a93d47e68fedac65a7
  ac7e718 (olivernewman@google.com)
      [file] Catch IOErrors

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I70e76d7105174e7e9b04c7c4a98f8111f81fcdf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2937308
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

47080275

Add support for py3 presubmit · b7f797be

Josip Sokcevic authored Jun 03, 2021

Depot tools git cl presubmit supports py2 and py3. However, presumbit
recipe only runs py2. This patch adds support for running py3 presubmit
checks too.

Bug: 1214829
Recipe-Nontrivial-Roll: build
Change-Id: I089460eaf65d4b6f1238eea13eb087fadb21cad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2934371Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

b7f797be

Fix output flushing when getting warnings that should prompt in py3. · 7288f885

Dirk Pranke authored Jun 03, 2021

When presubmit checks create warnings that should raise a prompt
whether or not to continue, the output wasn't being flushed
properly under python3.

Bug: 1213316
Change-Id: Ibb4b4d965d49f0cd65ccc0737282e5f5b5f58004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921323Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

7288f885

Implemented suppport for getrelatedchanges endpoint in gerrit module · 85557a08

Marco Georgaklis authored Jun 03, 2021


The endpoint documentation can be found here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes

This involved adding support for the command in gerrit_client and
gerrit_util and then incorporating functionality and testing into
the gerrit recipe module.

The reasoning for this is to be able to identify chained builds for
improved accuracy of the new test identification for the FLake
Endorser project.

Bug:1204163
Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016
Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

85557a08

02 Jun, 2021 2 commits

gclient: Upload metrics for sync'd deps. · c8f63d39

Edward Lesmes authored Jun 02, 2021

Change-Id: I5340fa9b989cccda61e7a14b4cd30749e2f2c017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2935003Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c8f63d39

my_activity: Add config file option to add additional gerrit instances · cd3696cf

Nicolas Boichat authored Jun 02, 2021

my_activity can definitely be useful outside of Chromium, and the
gerrit instances are sometimes private. This allows users to carry
an additional list of instances in a json file (and possibly
monorail projects, but that seems like likely to be useful).

Change-Id: Ic0fec3bd4f815200f27cc0a8530cfd88f4328269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2925677
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

cd3696cf

01 Jun, 2021 2 commits

Fix error handling in case of unicode decode error. · 30cde45e

Greg Thompson authored Jun 01, 2021

Commit 6fc394f9 added some diagnostics, but it didn't quite work out the
way it was planned.

Bug: 1210746
Change-Id: Ia4f30606e87d3f8b1362441bd74bb7ed0f5ca886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928771
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

30cde45e

Bump the cpython version for bleeding_edge. · 424504a1

Brian Ryner authored Jun 01, 2021

There should be no functional changes for depot_tools. However, this
version contains a fix for building Python wheels, and we're trying to
standardize on this version everywhere.

Change-Id: Ibb8259028f0c7aa39f03a75ffdedbbb5349b4fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927689
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

424504a1

27 May, 2021 2 commits

Roll recipe dependencies (trivial). · 0694fa65

recipe-roller authored May 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d21e9df67973aae34d960eb10da3dd65272268de
d21e9df (mgeorgaklis@google.com)
Added option to not log builds in presentation for buildbucket...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I62a226159c98f0ae2b693cb50be77bb936fc6f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922983
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0694fa65

Roll recipe dependencies (trivial). · 57e20d2b

recipe-roller authored May 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fdd7ffd886e6077f80633fb7237401c2edd7c8e3
fdd7ffd (mgeorgaklis@google.com)
Created function for GetTestResultHistory rpc call in resultdb...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I33e406a81bb3db1fb797887c6626a2e06c7e4359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922982
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

57e20d2b

26 May, 2021 4 commits

Fix crash during presubmit checking. · 6fc394f9

Dirk Pranke authored May 26, 2021

If a presubmit happened to generate a crash, the logic we have
for reporting the presubmit check times would call `six.reraise()`
incorrectly, leading to a second crash.

This CL fixes the invocation of the second crash, and also adds
an error message to help users tripping over one possible source
of the first crash (reading a binary file as text).

Bug: 1210746
Change-Id: Ic46f38901b6acf2055b3feb7272dc751dc69037c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921322Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

6fc394f9

Reland "bot_update: Don't use gclient sync output and rely on gclient revinfo." · 50cd6e41

Edward Lesmes authored May 26, 2021

This is a reland of 856ccef0

Use a tempfile instead of stdout for gclient revinfo output

Original change's description:
> bot_update: Don't use gclient sync output and rely on gclient revinfo.
>
> In preparation for skipping gclient sync if there are no DEPS changes.
>
> Bug: 1199853
> Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1199853
Change-Id: Ib50c4e943cbb51e4a2463beee9b7d1dee824ad29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910950Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

50cd6e41

[mac_toolchain] Roll mac_toolchain in depot_tools to latest version · 6c7a6fee

Zhaoyang Li authored May 26, 2021

The roll in depot_tools enables new features of uploading iOS runtimes
to separate packages, etc, for human users using the tool to upload
Xcode.

Bug: 1191260
Change-Id: Id6334afd599c9345f05c7fefbd8407f3bc3f8124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2918693Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>

6c7a6fee

cpython 2.7.18.chromium.36 to full depot_tools release. · 72bc20ef

Brian Ryner authored May 26, 2021

Bug: 1208146
Change-Id: I9347a6f95454cfab58eecc08a636957a5fcdb35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2916176Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>

72bc20ef

25 May, 2021 3 commits

Add rest of the plugins to gclient config · 6d45691f

Gavin Mak authored May 25, 2021


Recipe-Manual-Change: infra
Bug: 1201483
Change-Id: Id57c2e93e028baad101416bfecbf41ce136ad5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904102Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

6d45691f

Revert "[dirmd] Roll dirmd" · 7fc02e84

Josip Sokcevic authored May 25, 2021

This reverts commit 1cf97004.

Reason for revert: roll fails https://crrev.com/c/2915655
Error: dirmd failed.

Original change's description:
> [dirmd] Roll dirmd
>
> Earlier git-ls-files-based optimizations was reverted
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692.
> Since then the root cause was fixed
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/2911979
> and this CL relands the optimization.
>
> This CL also picks up "mixins" feature which enables reducing duplication of metadata.
> See https://chromium-review.googlesource.com/c/chromium/src/+/2897943
>
> Bug: 1179786, 1201822
> Change-Id: I9697bae9342f6cdc947abe025bebce22b09b530e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912261
> Reviewed-by: Prakhar Asthana <pasthana@google.com>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

Bug: 1179786
Bug: 1201822
Change-Id: Iea5aad69382da9cfd3e32c74db10721f37aee930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2909617
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

7fc02e84

New python 2.7 version with likely fix for crbug/1208146. · 7fcae6e9

Brian Ryner authored May 25, 2021

Bug: 1208146
Change-Id: Ifb27636063a3fbe02f605f42af3f04b2dbda1529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2914233Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>

7fcae6e9

24 May, 2021 2 commits

Revert "bot_update: Don't use gclient sync output and rely on gclient revinfo." · e2d7d8cd

Stephen Martinis authored May 24, 2021

This reverts commit 856ccef0.

Reason for revert: Probably broke chrome os waterfall

Original change's description:
> bot_update: Don't use gclient sync output and rely on gclient revinfo.
>
> In preparation for skipping gclient sync if there are no DEPS changes.
>
> Bug: 1199853
> Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1199853
Change-Id: Ib893704dffc68b02dfa7f977e751e236003b7e0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910949
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>

e2d7d8cd

bot_update: Don't use gclient sync output and rely on gclient revinfo. · 856ccef0

Edward Lesmes authored May 24, 2021

In preparation for skipping gclient sync if there are no DEPS changes.

Bug: 1199853
Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

856ccef0